* [dpdk-dev] [PATCH] doc: announce modification in eventdev structure
@ 2021-04-15 9:08 gakhil
2021-04-18 9:11 ` Jerin Jacob
2021-04-23 10:53 ` Kinsella, Ray
0 siblings, 2 replies; 6+ messages in thread
From: gakhil @ 2021-04-15 9:08 UTC (permalink / raw)
To: jerinj, thomas, dev, mdr, david.marchand
Cc: abhinandan.gujjar, hemant.agrawal, nipun.gupta, sachin.saxena,
anoobj, matan, roy.fan.zhang, g.singh, erik.g.carrillo,
jay.jayatheerthan, pbhagavatula, harry.van.haaren, sthotton,
Akhil Goyal
From: Akhil Goyal <gakhil@marvell.com>
A new field ``ca_enqueue`` is added in ``rte_eventdev``
in the end to maintain ABI. It needs to be moved above
in the structure to align with other enqueue callbacks.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 2afc84c39..a973de4a9 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -127,6 +127,10 @@ Deprecation Notices
values to the function ``rte_event_eth_rx_adapter_queue_add`` using
the structure ``rte_event_eth_rx_adapter_queue_add``.
+* eventdev: The function pointer ``ca_enqueue`` in structure ``rte_eventdev``
+ will be moved after ``txa_enqueue`` so that all enqueue/dequeue
+ function pointers are adjacent to each other.
+
* sched: To allow more traffic classes, flexible mapping of pipe queues to
traffic classes, and subport level configuration of pipes and queues
changes will be made to macros, data structures and API functions defined
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure
2021-04-15 9:08 [dpdk-dev] [PATCH] doc: announce modification in eventdev structure gakhil
@ 2021-04-18 9:11 ` Jerin Jacob
2021-04-23 10:53 ` Kinsella, Ray
1 sibling, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2021-04-18 9:11 UTC (permalink / raw)
To: Akhil Goyal
Cc: Jerin Jacob, Thomas Monjalon, dpdk-dev, Ray Kinsella,
David Marchand, Gujjar, Abhinandan S, Hemant Agrawal,
Nipun Gupta, sachin.saxena, Anoob Joseph, Matan Azrad, Zhang,
Roy Fan, Gagandeep Singh, Erik Gabriel Carrillo, Jayatheerthan,
Jay, Pavan Nikhilesh, Van Haaren, Harry, Shijith Thotton
On Thu, Apr 15, 2021 at 2:39 PM <gakhil@marvell.com> wrote:
>
> From: Akhil Goyal <gakhil@marvell.com>
>
> A new field ``ca_enqueue`` is added in ``rte_eventdev``
> in the end to maintain ABI. It needs to be moved above
> in the structure to align with other enqueue callbacks.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 2afc84c39..a973de4a9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -127,6 +127,10 @@ Deprecation Notices
> values to the function ``rte_event_eth_rx_adapter_queue_add`` using
> the structure ``rte_event_eth_rx_adapter_queue_add``.
>
> +* eventdev: The function pointer ``ca_enqueue`` in structure ``rte_eventdev``
> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
> + function pointers are adjacent to each other.
> +
> * sched: To allow more traffic classes, flexible mapping of pipe queues to
> traffic classes, and subport level configuration of pipes and queues
> changes will be made to macros, data structures and API functions defined
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure
2021-04-15 9:08 [dpdk-dev] [PATCH] doc: announce modification in eventdev structure gakhil
2021-04-18 9:11 ` Jerin Jacob
@ 2021-04-23 10:53 ` Kinsella, Ray
2021-05-03 11:18 ` [dpdk-dev] [EXT] " Akhil Goyal
1 sibling, 1 reply; 6+ messages in thread
From: Kinsella, Ray @ 2021-04-23 10:53 UTC (permalink / raw)
To: gakhil, jerinj, thomas, dev, david.marchand
Cc: abhinandan.gujjar, hemant.agrawal, nipun.gupta, sachin.saxena,
anoobj, matan, roy.fan.zhang, g.singh, erik.g.carrillo,
jay.jayatheerthan, pbhagavatula, harry.van.haaren, sthotton
On 15/04/2021 10:08, gakhil@marvell.com wrote:
> From: Akhil Goyal <gakhil@marvell.com>
>
> A new field ``ca_enqueue`` is added in ``rte_eventdev``
> in the end to maintain ABI. It needs to be moved above
> in the structure to align with other enqueue callbacks.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 2afc84c39..a973de4a9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -127,6 +127,10 @@ Deprecation Notices
> values to the function ``rte_event_eth_rx_adapter_queue_add`` using
> the structure ``rte_event_eth_rx_adapter_queue_add``.
>
> +* eventdev: The function pointer ``ca_enqueue`` in structure ``rte_eventdev``
> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
> + function pointers are adjacent to each other.
> +
> * sched: To allow more traffic classes, flexible mapping of pipe queues to
> traffic classes, and subport level configuration of pipes and queues
> changes will be made to macros, data structures and API functions defined
>
I admire the disipline - but since you are not actually removing ca_enqueue,
just moving it in memory when the new ABI is declared in anycase, this is not required.
Thanks,
Ray K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure
2021-04-23 10:53 ` Kinsella, Ray
@ 2021-05-03 11:18 ` Akhil Goyal
2021-05-04 9:36 ` Kinsella, Ray
0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2021-05-03 11:18 UTC (permalink / raw)
To: Kinsella, Ray, Jerin Jacob Kollanukkaran, thomas, dev, david.marchand
Cc: abhinandan.gujjar, hemant.agrawal, nipun.gupta, sachin.saxena,
Anoob Joseph, matan, roy.fan.zhang, g.singh, erik.g.carrillo,
jay.jayatheerthan, Pavan Nikhilesh Bhagavatula, harry.van.haaren,
Shijith Thotton
Hi Ray,
> > @@ -127,6 +127,10 @@ Deprecation Notices
> > values to the function ``rte_event_eth_rx_adapter_queue_add`` using
> > the structure ``rte_event_eth_rx_adapter_queue_add``.
> >
> > +* eventdev: The function pointer ``ca_enqueue`` in structure
> ``rte_eventdev``
> > + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
> > + function pointers are adjacent to each other.
> > +
> > * sched: To allow more traffic classes, flexible mapping of pipe queues to
> > traffic classes, and subport level configuration of pipes and queues
> > changes will be made to macros, data structures and API functions
> defined
> >
>
> I admire the disipline - but since you are not actually removing ca_enqueue,
> just moving it in memory when the new ABI is declared in anycase, this is not
> required.
>
Does it mean we can move elements in a structure without giving deprecation notice?
-akhil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure
2021-05-03 11:18 ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-05-04 9:36 ` Kinsella, Ray
2021-05-07 9:17 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Kinsella, Ray @ 2021-05-04 9:36 UTC (permalink / raw)
To: Akhil Goyal, Jerin Jacob Kollanukkaran, thomas, dev, david.marchand
Cc: abhinandan.gujjar, hemant.agrawal, nipun.gupta, sachin.saxena,
Anoob Joseph, matan, roy.fan.zhang, g.singh, erik.g.carrillo,
jay.jayatheerthan, Pavan Nikhilesh Bhagavatula, harry.van.haaren,
Shijith Thotton
On 03/05/2021 12:18, Akhil Goyal wrote:
> Hi Ray,
>>> @@ -127,6 +127,10 @@ Deprecation Notices
>>> values to the function ``rte_event_eth_rx_adapter_queue_add`` using
>>> the structure ``rte_event_eth_rx_adapter_queue_add``.
>>>
>>> +* eventdev: The function pointer ``ca_enqueue`` in structure
>> ``rte_eventdev``
>>> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
>>> + function pointers are adjacent to each other.
>>> +
>>> * sched: To allow more traffic classes, flexible mapping of pipe queues to
>>> traffic classes, and subport level configuration of pipes and queues
>>> changes will be made to macros, data structures and API functions
>> defined
>>>
>>
>> I admire the disipline - but since you are not actually removing ca_enqueue,
>> just moving it in memory when the new ABI is declared in anycase, this is not
>> required.
>>
>
> Does it mean we can move elements in a structure without giving deprecation notice?
>
well if memory serves - you aren't depreciating the field, just moving it, right?
And you are aligning the change with an ABI break in anycase - so I think it is all good.
Ray K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure
2021-05-04 9:36 ` Kinsella, Ray
@ 2021-05-07 9:17 ` Jerin Jacob
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2021-05-07 9:17 UTC (permalink / raw)
To: Kinsella, Ray
Cc: Akhil Goyal, Jerin Jacob Kollanukkaran, thomas, dev,
david.marchand, abhinandan.gujjar, hemant.agrawal, nipun.gupta,
sachin.saxena, Anoob Joseph, matan, roy.fan.zhang, g.singh,
erik.g.carrillo, jay.jayatheerthan, Pavan Nikhilesh Bhagavatula,
harry.van.haaren, Shijith Thotton
On Tue, May 4, 2021 at 3:06 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
>
>
>
> On 03/05/2021 12:18, Akhil Goyal wrote:
> > Hi Ray,
> >>> @@ -127,6 +127,10 @@ Deprecation Notices
> >>> values to the function ``rte_event_eth_rx_adapter_queue_add`` using
> >>> the structure ``rte_event_eth_rx_adapter_queue_add``.
> >>>
> >>> +* eventdev: The function pointer ``ca_enqueue`` in structure
> >> ``rte_eventdev``
> >>> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
> >>> + function pointers are adjacent to each other.
> >>> +
> >>> * sched: To allow more traffic classes, flexible mapping of pipe queues to
> >>> traffic classes, and subport level configuration of pipes and queues
> >>> changes will be made to macros, data structures and API functions
> >> defined
> >>>
> >>
> >> I admire the disipline - but since you are not actually removing ca_enqueue,
> >> just moving it in memory when the new ABI is declared in anycase, this is not
> >> required.
> >>
> >
> > Does it mean we can move elements in a structure without giving deprecation notice?
> >
>
> well if memory serves - you aren't depreciating the field, just moving it, right?
> And you are aligning the change with an ABI break in anycase - so I think it is all good.
OK. Change the status of the patch in patchwork as "Not applicable"
>
> Ray K
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-07 9:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 9:08 [dpdk-dev] [PATCH] doc: announce modification in eventdev structure gakhil
2021-04-18 9:11 ` Jerin Jacob
2021-04-23 10:53 ` Kinsella, Ray
2021-05-03 11:18 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-04 9:36 ` Kinsella, Ray
2021-05-07 9:17 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).