From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6246BA04F6; Wed, 11 Dec 2019 16:48:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9685B2C6A; Wed, 11 Dec 2019 16:48:35 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 504191D9E for ; Wed, 11 Dec 2019 16:48:34 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id r81so19866786ilk.0 for ; Wed, 11 Dec 2019 07:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9XctHQvyXy07QVJBAmdTKT4jWgDkH++7I12pywaNEiw=; b=ZejvyNPEwjqSg/dJJ2TEwnL0SAGvEmAw6k+YScwoKnwtPkAeg1IlAShzhbYiqDzG9g qvIonYrUpCmUYPVOrhCMZj1Y1TlF5kDSyVjH9ZGHBFYbPd2UPf92xXar6yR3u/9r195k /AJW+D7+EX0v6z2W1KGaONQTno0bDFH2dHn3+XV/V4/Xi0zOkpk0v+OFxTC/tVTjLbck T9PSdAaTEVIQBK/j3tz1+kRmtc+7P9Wjj2+t4w3TyTpWmiOgrZq3YdvNO/jW29/h42WJ JYZKm7kk09dD8XgWd4msPik0F1soJKA0GNcGMl3+q4YP8bn8emiG+7N/XZ2VPm3mf4AD U5sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9XctHQvyXy07QVJBAmdTKT4jWgDkH++7I12pywaNEiw=; b=dla95sXJsWnzJK9EwaSJpnIMw/45eljEkb5PKXqImV1b+is98DpGYB3hg72BsMZiyV if4PpvJdnCzXDushmddN3dx4NA832Vp24csh58WcnqpJ4e2DwzAV4v/6ADg6dpgF8nec sgeih7/bIG2IBaemlI1epjZkr73/YFvIabX1A4Cw3WsOM5lxL6vC1JeczirAgBExEp+f 5aLy7MoRVBeJhRSHqDKzGgtv3Rk/yB25z9jrORuRO9wbkG8+BiRSJtzb4we+SJH2KbX/ vc6mUGlrLH4b4YdBwOHgoZRorfORr7ZHnFoU5sQgL562aYoS8ZAQb7qeGUgkNg6x9/iu 0zgA== X-Gm-Message-State: APjAAAWEvhVCZG6QXrFqRSQxCaGywcCDqU4NZj0MMWdcBD/RAxE2NF73 /bvnn0q5Tp/kgR3FJcVTTRnau+NaGE+uq9Lzjqk= X-Google-Smtp-Source: APXvYqzaSNcgsKDW+heuCcYOKCXyArVM8rfgLBy8Gae9LLRVSnhbOLlnR6nB1afLI1qXIF0N1rlbTPHrNx4cyMPngYY= X-Received: by 2002:a92:7793:: with SMTP id s141mr3772797ilc.162.1576079313419; Wed, 11 Dec 2019 07:48:33 -0800 (PST) MIME-Version: 1.0 References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> <1576057875-7677-2-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1576057875-7677-2-git-send-email-xiaojun.liu@silicom.co.il> From: Jerin Jacob Date: Wed, 11 Dec 2019 21:18:17 +0530 Message-ID: To: Xiaojun Liu Cc: "xiao.w.wang@intel.com" , "qi.z.zhang@intel.com" , "ngai-mint.kwan@intel.com" , "jakub.fornal@intel.co" , "jacob.e.keller@intel.com" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 11, 2019 at 3:22 PM Xiaojun Liu wrote: > > To support switch management, add the following files: > Add fm10k/switch/fm10k_debug.h(define log Macros). > Add fm10k/switch/fm10k_regs.h(define all the registers). > Add fm10k/switch/fm10k_switch.h(define switch Macros and APIs). > Add fm10k/switch/fm10k_i2c.h(define I2C interfaces). > Add fm10k/switch/fm10k_i2c.c(support I2C access). > Add fm10k/switch/fm10k_sbus.h(define SBUS interface). > Add fm10k/switch/fm10k_sbus.c(support SBUS access). > and modify fm10k/Makefile(add ENABLE_FM10K_MANAGEMENT support, > add fm10k_i2c.c and fm10k_sbus.c). Integrating NIC with the integrated or onboard switches over i2c or sbus is a common problem. Instead of polluting ethdev driver with i2c and sbus _bus_ code, Why not add new i2c bus and move this code to driver/bus/i2c/xxxx/ > > To avoid configuration for both kernel driver > and userspace SDK outside DPDK, we add switch > management in FM10K DPDK PMD driver. > To enable switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=y in > config/common_linux when building. > > Signed-off-by: Xiaojun Liu