From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41302A00C4; Mon, 11 Jul 2022 16:07:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C5FF41156; Mon, 11 Jul 2022 16:07:44 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id 7E7E440695 for ; Mon, 11 Jul 2022 16:07:43 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id i21so5818596qtw.12 for ; Mon, 11 Jul 2022 07:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=47q6utTxiqQsNWBfLpRAQQfZANKWfQosPY7HQJ5VbOw=; b=ZTBPZ20mWnXKfjYWYW0oHDUO0xJGJS6wVeqy5ur/Gd30HdK7yv6ToZKjKOi/Elp2R0 TvULzrHW5wxzEwlYCIDzS9AFIVQtuPDzN/ZhB8C2Ab2sMZFENYZJFmmcqjgm9QeeDkkg B2dIR9kiTseDZs++rXW3Rb7mXKZYmqk+KwByaDvmgcRnpl2KRrneCL2LwWbsD6sfZh/l 25aEWpFC7cDCm6QXCKcnGfss9TtyJPaHtGOtYLQDEnpwpv7lg4rKvp07RnnL1o/RkEqT F/deSFdoyPA7gN/B1vBbDrEDv95cXfRhiu2PAXUDpS+BeMXnrfEknm2wujd4a27vClvX ZYug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=47q6utTxiqQsNWBfLpRAQQfZANKWfQosPY7HQJ5VbOw=; b=qajQcNd7gKOzyyrtRFSwW52lIV6joHHf29qQmOPOAqcM6BZuq2ID2p10XKl9qZzFlb 58RAs7KvOllTJezbXkbLq5qiVBsHiAvDBFadI/i1YxiRAKLrCr8Ic44qlrKsuI3b0f5h LCI5/qlb+GOeoO8o8AsEzgufA0nioicbFhtqyky3cyE0840hoz7M210Q2LjNeUOxhY/z GQDXEV7HO6GGpJGOx878hufup8wb4C77EmQvJGM29sLTlKk8GjY6Q06hndQlE/uR5uaK DZdiI/sG6Lh0MhNLC3Q78JDkDFKW4SHJPlJMUlRrUVXg8NGdv0F+cx1uUTzfJ2B1zfwu huKA== X-Gm-Message-State: AJIora8EhxC77DPJHCUsxCcTey5T2QMefsmZROFOSDbYcXtWoKcysWSp Sl3+W49nqiH6t3NPS/MhXsUIrxhGVLr4Ncp0FOU= X-Google-Smtp-Source: AGRyM1ueXg5e2cgVSbaIUEAmDQDqcsBKLsi51pCezO/hJVHj15W8IIhO6xVmWwSiBlvLagkkufd91B342ekaK+CQgvk= X-Received: by 2002:ac8:5b06:0:b0:31d:3b22:c8dd with SMTP id m6-20020ac85b06000000b0031d3b22c8ddmr13945247qtw.410.1657548462688; Mon, 11 Jul 2022 07:07:42 -0700 (PDT) MIME-Version: 1.0 References: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D86C5E@smartserver.smartshare.dk> <20211111041540.GA31795@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <28219790.PSkamzV0e4@thomas> <98CBD80474FA8B44BF855DF32C47DC35D86CDC@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86CDC@smartserver.smartshare.dk> From: Jerin Jacob Date: Mon, 11 Jul 2022 19:37:16 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , Tyler Retzlaff , Stephen Hemminger , dpdk-dev , Anatoly Burakov , "Menon, Ranjit" , Ray Kinsella , David Marchand , Dmitry Kozlyuk , "Richardson, Bruce" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 11, 2021 at 6:11 PM Morten Br=C3=B8rup wrote: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Thursday, 11 November 2021 12.55 > > > > 11/11/2021 05:15, Tyler Retzlaff: > > > On Tue, Oct 26, 2021 at 09:45:20AM +0200, Morten Br=C3=B8rup wrote: > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas > > Monjalon > > > > > Sent: Monday, 25 October 2021 21.14 > > > > > > > > > > 15/03/2021 20:34, Tyler Retzlaff: > > > > > > The proposal has resulted from request to review [1] the > > following > > > > > > functions where there appeared to be inconsistency in return > > type > > > > > > or parameter type selections for the following inline > > functions. > > > > > > > > > > > > rte_bsf32() > > > > > > rte_bsf32_safe() > > > > > > rte_bsf64() > > > > > > rte_bsf64_safe() > > > > > > rte_fls_u32() > > > > > > rte_fls_u64() > > > > > > rte_log2_u32() > > > > > > rte_log2_u64() > > > > > > > > > > > > [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html > > > > > > > > > > > > Signed-off-by: Tyler Retzlaff Acked-by: Jerin Jacob > > > > > > --- > > > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > > > +* eal: Fix inline function return and parameter types for > > > > > rte_{bsf,fls} > > > > > > + inline functions to be consistent. > > > > > > + Change ``rte_bsf32_safe`` parameter ``v`` from ``uint64_t`` > > to > > > > > ``uint32_t``. > > > > > > + Change ``rte_bsf64`` return type to ``uint32_t`` instead of > > > > > ``int``. > > > > > > + Change ``rte_fls_u32`` return type to ``uint32_t`` instead > > of > > > > > ``int``. > > > > > > + Change ``rte_fls_u64`` return type to ``uint32_t`` instead > > of > > > > > ``int``. > > > > > > > > > > It seems we completely forgot this. > > > > > How critical is it? > > > > > > > > > > our organization as a matter of internal security policy requires > > these > > > sorts of things to be fixed. while i didn't see any bugs in the dpdk > > > code there is an opportunity for users of these functions to > > > accidentally write code that is prone to integer and buffer overflow > > > class bugs. > > > > > > there is no urgency, but why leave things sloppy? though i do wish > > this > > > had been responded to in a more timely manner 7 months for something > > > that should have almost been rubber stamped. > > > > It's difficult to be on all topics. > > The best way to avoid such miss is to ping when you see no progress. > > > > So what's next? > > They are only inline functions, right? so no ABI breakage. > > Is it going to require any change on application-side? I guess no. > > Is it acceptable in 21.11-rc3? maybe too late? > > Is it acceptable in 22.02? > > If Microsoft (represented by Tyler in this case) considers this a bug, I = would prefer getting it into 21.11 - especially because it is an LTS releas= e. > > -Morten >