From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 021D64550B; Thu, 27 Jun 2024 15:14:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2E7440E09; Thu, 27 Jun 2024 15:14:16 +0200 (CEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id 264C240BA3 for ; Thu, 27 Jun 2024 15:14:15 +0200 (CEST) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4464c3c8f10so249361cf.3 for ; Thu, 27 Jun 2024 06:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719494054; x=1720098854; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b2Faa+QkARijtDMb2sb342i76l8MXa4bJpwN1LbcSsw=; b=LztysAaCNi/oJLsVeUzlzvKtqkNAkI0nZdc+8FzaEx47D+TbkVzznMsMXTAsxXUXsW mDk81CFk9pTaWSoFJo4uu1DUqErrjVbgJL7WZCc0+Kqqa354BHrdmc1a7yjge72Nemj8 eaTTbTZF+ZWa2mU4YAVpSY47L7p1yFApiTGppzN32l7Wp2+cicwqyR89H8bD+EM2/4Pr BFz2XCiM+vrU9+tMatjOqcvr8OQNBGUTrGQmX4WdDzOEI0xLCEkLKMWmNl6J1QGmL1sm Xkl9NLx2mF3PSS+cRLoTx6VVGF0KWOjKBAf/gPRV6BEIsP9gHWgAzlFeSGwUVaTRDPiH bZ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719494054; x=1720098854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b2Faa+QkARijtDMb2sb342i76l8MXa4bJpwN1LbcSsw=; b=JrRqGByUADJK7HiiMX2SBNQwjucX64HNOFgUu3aB/wfKDwkx6e5v4dbp64yGHxt7i4 qPkOWlqlUDcsWVZKd23wzkoTgp+h8ohJCa4hCCZfZemhmr4JaTYls79l/AfzLFTVnmFl auSxydCdAMPVC1hEnGZqbTR7HmeRCdzPgDbqbuQlx/Y75D6tG+CPg29Fjw6XgIlGVhVL H/T4QkyJ6u2dB9rsxfcMUswgMqMbBPT+aSh5jpkZ+e4cCynSUitG1gl31Cs+uJshuLP1 lDJD9J7HyD8+4MYuIZo5N6ZA3ktlYio7BGiKlAkPALDJfP/E+lezbv10FJKpFjfAnMrX bqNQ== X-Gm-Message-State: AOJu0YxNTOrrUdc7tKO0Yy6TVujOh/5TV/HKDh5rdfDyG73pPhq9xXLE zZYoEv8Uo+HkfZtLDOi5jHpfjDUJ/48cwiS9DHAiR2aK6TDD+K4Y6s5Uk4eFriEZPBcdbFRJfBs rErzoM2CFrkqbeUmO5agOwp0KAEs= X-Google-Smtp-Source: AGHT+IFJhgIUhgzuUOIpgCGrDlUgCqO9SkPxn83NeOKL7Hf8TGjHUdx6ijnWosyRQmYwbKpf4yY/YlB0Maee3URyGDY= X-Received: by 2002:a05:622a:18a7:b0:440:d294:3b48 with SMTP id d75a77b69052e-444d3c0c7b0mr150382551cf.47.1719494054118; Thu, 27 Jun 2024 06:14:14 -0700 (PDT) MIME-Version: 1.0 References: <20240621201248.504989-2-abdullah.sevincer@intel.com> <20240621222408.583464-1-abdullah.sevincer@intel.com> <20240621222408.583464-3-abdullah.sevincer@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 27 Jun 2024 18:43:47 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] eventdev: add support for enqueue reorder To: "Sevincer, Abdullah" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "Richardson, Bruce" , "Pathak, Pravin" , "mattias.ronnblom@ericsson.com" , "Aggarwal, Manish" , Pavan Nikhilesh , Shijith Thotton , Hemant Agrawal , Sachin Saxena , "Van Haaren, Harry" , Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 27, 2024 at 12:01=E2=80=AFAM Sevincer, Abdullah wrote: > > Hi Jerin my responses below: > >+# Is this feature or limitation? > This is a new feature to enable enqueuing to PMD in any order when the un= derlined hardware device needs enqueues in a strict dequeue order. > >+# What is the use case for this feature? > This is needed by the applications which processes events in batches base= d on their flow ids. Received burst is sorted based on flow ids. OK. It is not clear from the Doxygen comment, add more details in comment in next version, especially if it is applicable for batch mode. In general, the concept looks good to me. Add new RTE_EVENT_DEV_CAP_* for this feature. Update doc/guides/eventdevs/features/default.ini and your PMD feature list. Adding other eventdev PMD maintainers if there are any comments.