From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44BC6A04DD; Wed, 28 Oct 2020 16:37:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1B46CC40; Wed, 28 Oct 2020 16:37:04 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 569CFCBF0 for ; Wed, 28 Oct 2020 16:37:03 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id b15so5758956iod.13 for ; Wed, 28 Oct 2020 08:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=um6wlX6tShmozuGFLOOYhqJzbhozEgubdA4x3h6YXGs=; b=ZQwRtQftbdr+3kGV/PVvQ8gcJmSOgyda2/ALsaZ30UGUg4O6AhuHO4dqyO8ncPzc0d EZacjvdVi7Is3cI5ZLvE296Srr3kv8G0lvd1QQbWY8WWda2TEp4R4HSZCvijjJHAqA9l MsfpxSDbR575QzmGDznETU1X4+PIvM2FIbUlE0HGxTIUTQPcttVGIJZyjNuOozarZNKB djWu7mFiKvvn/i8WM3C7pvK3syXxhJlxaxkEiDRTD7PMmWNowHsj+VbUuRghwMRSURAM wuE0q2DsI8D13oBdoiJASKWsuQi3crwTRjX2FfmGcBzXOamQMSNmPUI4PELJg47yJKzG MPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=um6wlX6tShmozuGFLOOYhqJzbhozEgubdA4x3h6YXGs=; b=S9cKq4z1/b2I5ELoEi8CQT6A8GAivsufspoO5+hpoZ1iqXeFa8SOjoRZ0qFQJG2iEc yq6UIaETt3ZpapeyZPK1+t1hpIJGvNUnw+8eM57nA9ClVyIVxXSeROiwV9fywJvpmbPG wHI6kLX9OUFzWP/KmqBS5OmrrlAjf8at2cn+mlgx3gJdQ0a0RObroI4uL0YwOOW+Jz9q 0AwYrtXDByS/0gF003f3h9I8cTP9VbDVuoVappAu9EPh5c5rHyScpPij+MZmATr/DCCt +xBvub1lAyo72YMahbVecAUEYTCyml5mD5subEmPFVBqtUv4kASwFCZcR9SyGn4MdGdn nBTQ== X-Gm-Message-State: AOAM5309DeMr9wIcjn3I+X2HDRwdCOFQApW+EVi38ArSKa/c9q6nWZAu qcc9MIes6Sz8ujFrynLuUfre6XxpJmk8iceUnFw= X-Google-Smtp-Source: ABdhPJwAClw2R5snL5uI0LxRRW7mBej2C6dNHK3fwvM/awDD75KO3ubIRaURUdU+LGOUZ1iOxVXxfN8KTl4OCDkjXlw= X-Received: by 2002:a02:c6ba:: with SMTP id o26mr7405983jan.104.1603899421575; Wed, 28 Oct 2020 08:37:01 -0700 (PDT) MIME-Version: 1.0 References: <1603494392-7181-1-git-send-email-liang.j.ma@intel.com> <20201028133507.GC29706@sivswdev09.ir.intel.com> <2373759.1G5EZAqFcn@thomas> <20201028153026.GD29706@sivswdev09.ir.intel.com> In-Reply-To: <20201028153026.GD29706@sivswdev09.ir.intel.com> From: Jerin Jacob Date: Wed, 28 Oct 2020 21:06:45 +0530 Message-ID: To: "Liang, Ma" Cc: "Ananyev, Konstantin" , Thomas Monjalon , dpdk-dev , "Ruifeng Wang (Arm Technology China)" , "Wang, Haiyue" , "Richardson, Bruce" , "Hunt, David" , Neil Horman , "McDaniel, Timothy" , "Eads, Gage" , Marcin Wojtas , Guy Tzalik , Ajit Khaparde , Harman Kalra , John Daley , "Wei Hu (Xavier" , Ziyang Xuan , "matan@nvidia.com" , Yong Wang , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > On 28 Oct 20:44, Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > > wrote: > > > > > > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > > > > > > > Hi Thomas, > > > > > > I think I addressed all of the questions in relation to V9. I don't think I can solve the issue of a generic API on my own. From the > > > > Community Call last week Jerin also said that a generic was investigated but that a single solution wasn't feasible. > > > > > > > > > > I think, From the architecture point of view, the specific > > > > > functionally of UMONITOR may not be abstracted. > > > > > But from the ethdev callback point of view, Can it be abstracted in > > > > > such a way that packet notification available through > > > > > checking interrupt status register or ring descriptor location, etc by > > > > > the driver. Use that callback as a notification mechanism rather > > > > > than defining a memory-based scheme that UMONITOR expects? or similar > > > > > thoughts on abstraction. > > > > > > I think there is probably some sort of misunderstanding. > > > This API is not about providing acync notification when next packet arrives. > > > This is about to putting core to sleep till some event (or timeout) happens. > > > From my perspective the closest analogy: cond_timedwait(). > > > So we need PMD to tell us what will be the address of the condition variable > > > we should sleep on. > > > > > > > I agree with Jerin. > > > > The ethdev API is the blocking problem. > > > > First problem: it is not well explained in doxygen. > > > > Second problem: it is probably not generic enough (if we understand it well) > > > > > > It is an address to sleep(/wakeup) on, plus expected value. > > > Honestly, I can't think-up of anything even more generic then that. > > > If you guys have something particular in mind - please share. > > > > Current PMD callback: > > typedef int (*eth_get_wake_addr_t)(void *rxq, volatile void > > **tail_desc_addr, + uint64_t *expected, uint64_t *mask, uint8_t > > *data_sz); > > > > Can we make it as > > typedef void (*core_sleep_t)(void *rxq) > How about void (*eth_core_sleep_helper_t)(void *rxq, enum scheme, void *paramter) > by this way, PMD can cast the parameter accorind to the scheme. > e.g. if scheme MEM_MONITOR then cast to umwait way. > however, this will introduce another problem. > we need add PMD query callback to figure out if PMD support this scheme. I thought scheme/policy something that "application cares" like below not arch specifics 1) wakeup up on first packet, 2) wake me up on first packet or timeout 100 us etc Yes. We can have query on type of the policies supported. > > > > if we do such abstraction and "move the polling on memory by HW/CPU" > > to the driver using a helper function then > > I can think of abstracting in some way in all PMDs. > > > > Note: core_sleep_t can take some more arguments such as enumerated > > policy if something more needs to be pushed to the driver. > > > > Thoughts? > > > > > > > > > > > > > > > This API is experimental and other vendor support can be added as needed. If there are any other open issue let me know? > > > > > > > > Being experimental is not an excuse to throw something > > > > which is not satisfying. > > > > > > > > > > >