From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7349DA0548; Wed, 3 Nov 2021 16:14:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B15142731; Wed, 3 Nov 2021 16:14:23 +0100 (CET) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 0725A41C26 for ; Wed, 3 Nov 2021 16:14:22 +0100 (CET) Received: by mail-io1-f42.google.com with SMTP id b203so3208235iof.1 for ; Wed, 03 Nov 2021 08:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T9wt+pvboYmxfkpkfMw0vRfBCJCqSjEHqGjv68ggXH4=; b=El5OoBGjtB2c8nmnQG5G0vIylgrwpAAWczDwq8y3dL2adKdXi/8ZebmjXVMnWQa1/R lLduGEel9vEuZxOD5vJjqJpuSJ6YSZcNXBrHa+D0ySuSvLVvT5HXbs/B8g3pAQwGbldm b40cYxtBm8o4oivPStwze82irYqqaJh8Y0/A09Gr0zObK1Y6FpykoiFT5WxC04g0VfRV NaVuwLuSJX3/JLatr6fphz1fVWROo35d32RSrzfLWQ/qedLodoxQreQElEhG2fUV3Qk7 OCvwHxAg148KRA7+syZMcTNjk3ghL8A5Eyc+D8F1yoIfYUArQv2mWaOc6iPc85546Qmj i2ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T9wt+pvboYmxfkpkfMw0vRfBCJCqSjEHqGjv68ggXH4=; b=6ktThPFUOnGkeAHEL8LNr87fmPq029vFmMLGVnfswF4wNA3QLhHMHkKyrbmMOGS75S 7WlzC7YM48ZF3H+MqINh7cUgfbq5vGUsvbaWogifQeu0X8NwUPcUjeTleaGT+OX2j4c7 OIg2aVPs66A0djskIGQleHT0bOAtu1fijsK9ezIJt7jhxjZ2fBeST1l628ApGOjRoLkf O+ATCCB00iGAxoMXZDOKW2NqyTjySaMfHPYcIHyC1W2rHYhEd0m49PNwrAVEWS4L6yTU RpAQf0sXqAjk/DyLfScf9eXIlq7Qn41re4wiA47cN/ehlGempIKtnuHdGB3Jnu4fypUz uUBg== X-Gm-Message-State: AOAM5332xxd4RkYRJpCgMat1JzrczW68fw3SmejBjbV/YZH/TIRXZrg3 HgkYFKXwBlqFXmqfoFqxomJde8RvWmZkPjxZT8I= X-Google-Smtp-Source: ABdhPJybu+qaJkvWnoTk3H0cM9vNuhVuo17LRql7wChJII7KkNJVIgpkbhQky5kXbgiffo9mEU2b3uU4ze5ujWCLqbw= X-Received: by 2002:a05:6602:2b0c:: with SMTP id p12mr22477935iov.199.1635952461367; Wed, 03 Nov 2021 08:14:21 -0700 (PDT) MIME-Version: 1.0 References: <1635751737-29259-1-git-send-email-skoteshwar@marvell.com> In-Reply-To: <1635751737-29259-1-git-send-email-skoteshwar@marvell.com> From: Jerin Jacob Date: Wed, 3 Nov 2021 20:43:55 +0530 Message-ID: To: Satha Koteswara Rao Kottidi , Ferruh Yigit Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] common/cnxk: consider adjust value for tm burst calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 1, 2021 at 12:59 PM wrote: > > From: Satha Rao > > To support lower pps in packet mode we are changing adjust value, > same needs to be consider for burst size calculations. > > When both peak and committed rates requested, then peak rate should > be larger than committed rate. > > Signed-off-by: Satha Rao Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_nix_tm_ops.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c > index eee80d5..b80c77c 100644 > --- a/drivers/common/cnxk/roc_nix_tm_ops.c > +++ b/drivers/common/cnxk/roc_nix_tm_ops.c > @@ -124,6 +124,11 @@ > profile->pkt_mode_adj += adjust; > profile->commit.rate += (adjust * profile->commit.rate); > profile->peak.rate += (adjust * profile->peak.rate); > + /* Number of tokens freed after scheduling was proportional > + * to adjust value > + */ > + profile->commit.size *= adjust; > + profile->peak.size *= adjust; > } > > return 0; > @@ -181,6 +186,10 @@ > return NIX_ERR_TM_INVALID_PEAK_RATE; > } > > + /* If PIR and CIR are requested, PIR should always be larger than CIR */ > + if (peak_rate && commit_rate && (commit_rate > peak_rate)) > + return NIX_ERR_TM_INVALID_PEAK_RATE; > + > if (!skip_ins) > TAILQ_INSERT_TAIL(&nix->shaper_profile_list, profile, shaper); > > -- > 1.8.3.1 >