From: Jerin Jacob <jerinjacobk@gmail.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok
Date: Fri, 22 Oct 2021 05:41:21 +0530 [thread overview]
Message-ID: <CALBAE1PQkmbHvHyWVdv8bPXtZERJ4cP1ORfZaQLSzRVQ2q+JPQ@mail.gmail.com> (raw)
In-Reply-To: <7da17c30-18a2-4da5-60b3-c03d7a73eeb5@oktetlabs.ru>
On Wed, Oct 20, 2021 at 7:58 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 10/20/21 5:26 PM, Bruce Richardson wrote:
> > Since we allow line lengths of up to 100, and the CI checkpatches job
> > only check for that amount, the rest of our tooling and docs should
> > reflect this reality. Therefore we can:
> >
> > * adjust the editorconfig to use that value, to save editors (e.g. vim)
> > from automatically wrapping lines at 80 characters when typing.
> > [Since python checkers all seem to expect 79 character lines max, add
> > for python only a 79-char max line length.]
> >
> > * change the default line length setting in checkpatches script to 100
> > so as it matches CI and pre-merge checks.
> >
> > * update the docs to clarify that while 80 chars is recommended, up to
> > 100 characters is acceptable.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Jerin Jacob <jerinj@marvell.com>
>
next prev parent reply other threads:[~2021-10-22 0:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 13:48 [dpdk-dev] [PATCH] editorconfig: bump line length to 100 Bruce Richardson
2021-10-20 13:57 ` Andrew Rybchenko
2021-10-20 14:11 ` Bruce Richardson
2021-10-20 14:14 ` Bruce Richardson
2021-10-20 14:26 ` [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok Bruce Richardson
2021-10-20 14:28 ` Andrew Rybchenko
2021-10-22 0:11 ` Jerin Jacob [this message]
2021-11-25 10:51 ` Thomas Monjalon
2021-10-22 8:21 ` Xia, Chenbo
2021-10-26 0:30 ` fengchengwen
2021-10-28 13:14 ` Walsh, Conor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PQkmbHvHyWVdv8bPXtZERJ4cP1ORfZaQLSzRVQ2q+JPQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).