From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DD92430DB; Wed, 23 Aug 2023 16:20:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E6DE4161A; Wed, 23 Aug 2023 16:20:57 +0200 (CEST) Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by mails.dpdk.org (Postfix) with ESMTP id A5EB040223 for ; Wed, 23 Aug 2023 16:20:55 +0200 (CEST) Received: by mail-vk1-f169.google.com with SMTP id 71dfb90a1353d-48d14d11756so1252280e0c.2 for ; Wed, 23 Aug 2023 07:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692800455; x=1693405255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xaCMq60KA8RdBSscMIu44c756ZEvcY1j+osuQOWtI3E=; b=lR44R4wESgmBHNwdzZxKG/qtuWqsL0qR3oJup4vgvoP9Uw8pgr+cPzQ6q6rr9VYJcd JKVvTRMzzH9ibjVi5CpDahEJXPMPjPsDM9OJ6cfOFCYdtWCTaAj7cHKv4WHhgeUmP1yT FSmRWJQyaG71TDoV7LV/hNndpA8uTyzq4k7OOviPbmUkDdfQ5REqFtIcBXyg7MlxGz7I 8FtF6wkjghuDTu9bLZOr4ArxFOiYalMNtJEIEx7QYyzSZw++CMJqkJtrWzIQD5E6Xrjp W0YbriuyoXDo+vpnnVZcPPM1XIpyBI8cGHJ9G9w//TBcvwv2MQhJ0ds3cx1pwxCMNKMX SVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692800455; x=1693405255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xaCMq60KA8RdBSscMIu44c756ZEvcY1j+osuQOWtI3E=; b=XYy60oRvVnPuQpkR8JNlbm4eZmjnsh5SbA+Z5MWECrr047jY5oUp/QTLP3v1YC6FSv lwvyTMGSXUjuWBAd/6Ux8qIxAi0HE5IYzvp1AldbIC0VM7W8fSHoE7eW+Bsi1tPxgew9 6rb46Ooej/PEyNVt6KQ+fNZozL+rB8YdLgCrWTwALw3MKBRoe/fdDrTPIni6hDwmJsbm eIfM8rBIQFaPgMbYIUVmYZKiG50NFxXcA6N/gmFTGNtF3Fn7buexMmIDTh6n03dFBP41 PHznGhF+bTNeZUSblBBbZgecLEv5PjAE0JPnv/EmzJJWelLXp0wbqPKVAH32f8SRw18I EzNw== X-Gm-Message-State: AOJu0Ywg7yYVxCO9Q0yyCIkFa13qoBMOJsP+LoZm81W2GgwtNhmfpi5D GhCePS9iTyd7oB9+JLhtiwuiCycpkp2fiIfN/sE= X-Google-Smtp-Source: AGHT+IFxB4R0RPPEgljx2qCtHILQqifIm+kImMr1flAf8JdP9KojDTAMRNOZg7uS+Kji2vdSd4f4Ld4Esp30kxyntRo= X-Received: by 2002:a1f:9c02:0:b0:48d:e53:8431 with SMTP id f2-20020a1f9c02000000b0048d0e538431mr9349311vke.5.1692800454829; Wed, 23 Aug 2023 07:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20230822131649.3509986-1-asasidharan@marvell.com> <20230822131649.3509986-3-asasidharan@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 23 Aug 2023 19:50:28 +0530 Message-ID: Subject: Re: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation To: "Gujjar, Abhinandan S" Cc: Anoob Joseph , Jerin Jacob Kollanukkaran , Shijith Thotton , "dev@dpdk.org" , Aakash Sasidharan , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 23, 2023 at 11:47=E2=80=AFAM Gujjar, Abhinandan S wrote: > > It is not about supporting other PMDs. > This is about keeping the test case simple with minimal conf overhead so = that it is easy for testing and maintaining. > From the code, I see that few PMDs supports NULL too without much changes= to the app. It should be ok. > > > > Also, what we have seen is, if there are other cryptodevs (like cnxk), = that > > would be the first cryptodev. And the test application is only testing = CDEV_ID > > 0. So creating a NULL crypto PMD when other PMDs are available is point= less. > Sounds good. > > Acked-by: Abhinandan Gujjar Series applied to dpdk-next-net-eventdev/for-main. Thanks