From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7E3542C4D; Wed, 7 Jun 2023 15:29:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EF6440ED5; Wed, 7 Jun 2023 15:29:20 +0200 (CEST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id 006BD40698 for ; Wed, 7 Jun 2023 15:29:18 +0200 (CEST) Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-3f866383b25so37255751cf.2 for ; Wed, 07 Jun 2023 06:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686144558; x=1688736558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k49S4BOrVG7KMCve+3mXUxV4XvsoseHppAbTJw8okWc=; b=jtzuD+d/h3JFUsryuHoxAdKuGJsfc1lWB3gle6pWcsElT0J5SxI5VbpN6XQ98vBQMg HT/2dq7xlqAy1CcdwBkBBvG8mpj32sQpKsGRDZIc1taUPzYoVp+z6kjIBIIcEe/hd7el ZVJYOwxdoCiQkR7Is6kMhK3Vvob2Y43WABASNDgH7PYcGwb3p8N9sinQmtRqbg3VxBnP DrwV7R7e3Mx6rfcEE3w1K0b2CoJKslQfYVDYtKwW/QCiLX7+NyexYv56awwKb7RSb/Ho CduY1czAdrBdhcBoUTzGlKrw2gzVSX06PzcEVcUcX8Z0BsmvtJ1DYEuCwJxz0HqT0x8B xyOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686144558; x=1688736558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k49S4BOrVG7KMCve+3mXUxV4XvsoseHppAbTJw8okWc=; b=C8uMi6bzJIsyqSeil1NBTED+5SWhdIuYHNIVKunjN6X0DuWesDs3bZmS9ZIlYRGJ0F ctlo7eYvIoA7cG2V46EUON1EmvilbtI0STFHXBVIgrUFdM8J/LJffmqaHQiChqf2YSSq Ew1GSTtEKD2jibNaMPObQpbdwJ7H/zAR1WajtyaIMe7X/fcUSJofYcWW+D5yL2f18hn0 tCFeHtCLCXzJyCtmkR9ec0N/2Pp7vT5/H3DQA+77gIow2BVjHYnHC857uFGZm989AgCJ S4lOPk9nhlLNkEQ0ryiVHqp1LWZJuVz1vEsfFr9b52L1pvStsOHmtgqi3UxdjVqxhuCe znrQ== X-Gm-Message-State: AC+VfDw5FuKwAvUFrWlsrqTLd9T0MtnVU1Abmh1C17A3bhdY59mg3M8w SqWeHp6Wa6pWGKbIlS9KS/Oe4wfADA7Gb93+MUI= X-Google-Smtp-Source: ACHHUZ7Tg2AIp9/EOwRl5k6PV/XmtnY4+zsYgF9viJD6L+WFCCl4dnHcwchNUeAjwAfg5tQX6CFzXv3q7ptVLBseD8Y= X-Received: by 2002:a05:6214:f2f:b0:62b:4ecb:fa72 with SMTP id iw15-20020a0562140f2f00b0062b4ecbfa72mr4163940qvb.20.1686144558291; Wed, 07 Jun 2023 06:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20230606144746.708388-1-zhirun.yan@intel.com> <20230607035144.1214492-1-zhirun.yan@intel.com> <20230607035144.1214492-5-zhirun.yan@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 7 Jun 2023 18:58:52 +0530 Message-ID: Subject: Re: [PATCH v9 04/17] graph: add get/set graph worker model APIs To: "Yan, Zhirun" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 7, 2023 at 5:55=E2=80=AFPM Yan, Zhirun w= rote: > > > > +__rte_experimental > > > +static inline uint32_t > > > +rte_graph_worker_model_get(struct rte_graph *graph) { > > > + if (!graph_model_is_valid(graph->model)) > > > + return -EINVAL; > > > > Introduce rte_graph_worker_model_no_check_get() to skip this check to u= se > > with fastpath. > > > > rte_graph_worker_model_get can move to .c file. > > Yes. Will move in next version. > Got it. rte_graph_worker_model_no_check_get() will be used in fast path. > Actually, I don=E2=80=99t find the performance impact about static inline= , so should the new May be due to burst size 32 or 256.it will start impacting if burst size is less. > API declared with static inline keywords or put it into .c file also? Keep in line fastpath function in .h as inline.