From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2A42A2EDB for ; Tue, 1 Oct 2019 11:49:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A6AD44C7; Tue, 1 Oct 2019 11:49:55 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 61E073977 for ; Tue, 1 Oct 2019 11:49:54 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id u8so46240317iom.5 for ; Tue, 01 Oct 2019 02:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UrTvTuSRQio03KcCJp/tSIcLJngKIDXghyLIvqSN+iE=; b=UWVikUbG4SUO6mwVhzOF2xUY7x5mb4lK9j6tIbrheQQe2aHN2XHBFG1+SSFWjhjgxe wQUh6HTR4hQlHhFn1t2zG4aJXqKicgUWGsIyNncH8HEV7xw49STtEPqkoRkHVEYjV0D8 gMVVnPn08MRqYCpawXuwVnvc5G7BgknmfRzbF14T0hrPZ6lW6wmH4Bk8Skld5R0d4vne Gj7erZFmj8COzYbrJUXPv+Qsv6OVGLE0OKGp7BU5wW6jG0mvQAAI5VucK6HvSyu4U+wR WGXA4e9mpjxgPXaOSIvrkcx1CsHbYdiKCrZyNQ98jb44xMS+UP7Uh1SGTnqJAGZm3MAP 2YNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UrTvTuSRQio03KcCJp/tSIcLJngKIDXghyLIvqSN+iE=; b=rfYrJ3AzkpVTNHTM2Fcm1CpoM4uxwcd0gsYGcKbtrakWnDFD7WV0dPnMCZ9BmSrw0d QWX3C693jgsHZsLs+a6wtNZzTMjNeetH6Te6pBIKr3WqNEQN4jp90LS/Jx6yLVpq3HBy jR0JYByjcJdKnlvZTew1P5G8VYelDCPF6l7d19rw0lw6zr57qCoiASg178Nx+Qx+8KDy OL5/2KWktw/bwHyq27MC0zmbWQAacLIp6SQhOXnjWIhCW+Dda9L8qaj6zX8hXL7VMx/g d/bNLyiaJDp5ybEOICF5MVZxtPU6tDE5Ax47cBUkl9ghCFsdsKyb/VCo6HoBr/mFHgHZ 4rUQ== X-Gm-Message-State: APjAAAXM6rM/0pF4FiRx4OEmRTkh91L43PreeGT1rBErNjjIKs8b47sC /T1l6f+Oi4UwsPtvHNcDHmH3JcqzDnfw1rxQBz0= X-Google-Smtp-Source: APXvYqwBc7gfs/UxHnaJiHNcqFToq/vymeJEEAxSZ6+FKC3by++RjYziuXrjDzdOdq0uoO6bhGfwJR9G8749PHZeY3I= X-Received: by 2002:a02:7797:: with SMTP id g145mr23458880jac.60.1569923393550; Tue, 01 Oct 2019 02:49:53 -0700 (PDT) MIME-Version: 1.0 References: <30b29c553a1ae4faafbd2018ec3a6701b71d266a.1569846991.git.gaetan.rivet@6wind.com> <20190930115333.5302e457@hermes.lan> <20191001091013.xxtzjblepbleqren@bidouze.vm.6wind.com> In-Reply-To: <20191001091013.xxtzjblepbleqren@bidouze.vm.6wind.com> From: Jerin Jacob Date: Tue, 1 Oct 2019 15:19:42 +0530 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: Stephen Hemminger , dpdk-dev , Slava Ovsiienko , Ferruh Yigit , Anatoly Burakov , Thomas Monjalon , Jerin Jacob Kollanukkaran , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 1, 2019 at 2:40 PM Ga=C3=ABtan Rivet w= rote: > > On Mon, Sep 30, 2019 at 11:53:33AM -0700, Stephen Hemminger wrote: > > On Mon, 30 Sep 2019 14:51:03 +0200 > > Gaetan Rivet wrote: > > > > > Add a new EAL option enabling manual probing in the EAL. > > > This command line option will configure the EAL so that buses > > > will not trigger their probe step on their own. > > > > > > Applications are then expected to hotplug devices as they see fit. > > > > > > Devices declared on the command line by the user (using -w and --vdev= ), > > > will be probed using the hotplug API, in the order they are declared. > > > > > > This has the effect of offering a way for users to control probe orde= r > > > of their devices, for drivers requiring it. > > > > > > Signed-off-by: Gaetan Rivet > > > > I have no problems with the patch, but it would help if there was bette= r > > way to handle device naming policy in DPDK. Applications that depend on > > particular port number are prone to get broken by changes in surroundin= g > > OS or hardware environment. Just like Linux applications that are built > > to depend on "eth0"; which is unfortunately all too common. > > Hello Stephen, > > This patch is a way to avoid having the PCI bus defining the probe order > with the current hardware environment. It seems to be a step in the > right direction for the issue you identify. > > There is a tight coupling between device names and driver matches for > the vdev bus, but that seems difficult to avoid. > > Do you see other EAL APIs fostering an over reliance of downstream > systems on device names? > > I pushed a few months back a way to iterate / match devices by their > properties. If you identify other pain points, this could certainly be > improved as well. And this mode will be kicked in only when "--manual-probe" selected on eal arguments. So it won't change the behavior of the existing applications. > > -- > Ga=C4=97tan Rivet > 6WIND