From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C46D8A2F18 for ; Thu, 3 Oct 2019 12:33:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA6791C027; Thu, 3 Oct 2019 12:33:54 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 531DE1C025 for ; Thu, 3 Oct 2019 12:33:53 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id z19so4378291ior.0 for ; Thu, 03 Oct 2019 03:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HIu4qiSJgJNowQqlBwcCvC/X0smBNd7hbjNn0b2CYmU=; b=f4Gw04pY/g56dck0DRbnSAcHZBBrLAbBj4/1goBmaUWXSSKQD9SqcyDa5FF0rvCFHz h+F6wfSuQHZdTaM4LT69Uq4EI2duIrIxRn2xHziSmUGq+8fxL3gJga2NQQCVwXb1QbBL MkZRXrI+qSzyPWjqCHmO+7rZGUkF5fZWWuCAKwAlQXy5NNeXsdJ4KqiBY8WjIl77ajGm GaWkm/l9vaG24mGkpzPwVmEEe639si51N4jxGj836NLBOIKql4iozA4FFqOA+MPjwawv G1xFgRKgBDyVfE76Z0l16Sw5qBhJ62TfcYn2GDU55IbLcwf/wcMckfDm2ynojC+43UuA xdww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HIu4qiSJgJNowQqlBwcCvC/X0smBNd7hbjNn0b2CYmU=; b=B2JqpW71yp3d50CIuCbs46P+OrZRBS9p2NeFj6crdhXFcDxaXHtPZsO9Uc68slsi58 IP3+2rH6fow13K2MFPvpVL1wZ5SFkHEVr+sp+JYznVJPl4vgZD78e5sdU+HiHwDEJMMQ DNDgFtRCJ+01BD6usUl7xIgIP/HbIv2jt+6JCQvr91/QiT+5LUcgb2rp80G11/L31143 zY3HPWm7Lm/lgH+4T8g0FgfRVIkGzYaQUW8wBKB/zSww2Taqg42vH1mrpT6Ptz1zPQIc S/CxQuH5fa6ROCwn2oC+Ss1Q/Gc7yqL5uVoD/62/0UkVexIGWj7cf4Rmg4sHmQEtWLJ/ t2+g== X-Gm-Message-State: APjAAAW8Ojm2Dmo1q2wkQGi0cIYuG6Dp+LvD7emaIhb5qSdurOA+F7dA +5fuuopn+SfkfQpiM8iQn60Yi48vv/XbtVwj8IY= X-Google-Smtp-Source: APXvYqylBahipNlK0+4cHV6PAHIYixTmKqpc1VWP+qRNdAPJ+1yPDF305bgoo/fv3bJO+2WrN4sXG51fcRnOi8EoOIk= X-Received: by 2002:a92:8702:: with SMTP id m2mr9492000ild.294.1570098832434; Thu, 03 Oct 2019 03:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20190924094209.3827-1-pbhagavatula@marvell.com> <20191002205754.11746-1-pbhagavatula@marvell.com> In-Reply-To: <20191002205754.11746-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Thu, 3 Oct 2019 16:03:41 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , "Richardson, Bruce" , Akhil Goyal , dpdk-dev , "Van Haaren, Harry" , mattias.ronnblom@ericsson.com, liang.j.ma@intel.com, "Gujjar, Abhinandan S" , "Rao, Nikhil" , Hemant Agrawal , erik.g.carrillo@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 2:28 AM wrote: > > From: Pavan Nikhilesh > > This patchset adds a new application to demonstrate the usage of event > mode. The poll mode is also available to help with the transition. > > The following new command line parameters are added: > --mode: Dictates the mode of operation either poll or event. > --eventq_sync: Dictates event synchronization mode either atomic or > ordered. > > Based on event device capability the configuration is done as follows: > - A single event device is enabled. > - The number of event ports is equal to the number of worker > cores enabled in the core mask. Additional event ports might > be configured based on Rx/Tx adapter capability. > - The number of event queues is equal to the number of ethernet > ports. If Tx adapter doesn't have internal port capability then > an additional single link event queue is used to enqueue events > to Tx adapter. > - Each event port is linked to all existing event queues. > - Dedicated Rx/Tx adapters for each Ethernet port. > > v5 Changes: > - Redo poll mode datapath by removing all the static globals. > - Fix event queue configuration when required queues are not available. > - Fix Rx/Tx adapter creation based on portmask. > - Update release notes. > - Unroll macro used to generate event mode functions. Adding all eventdev maintainers. I have some minor comments on Documentation. Other than that, The series looks good to me in general. Anyone else planning to review this code. If yes, We will wait for merging this patch after RC1. If no, then we can merge in RC1 if no objection.