From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2929343180; Mon, 16 Oct 2023 18:01:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE1C840A80; Mon, 16 Oct 2023 18:01:57 +0200 (CEST) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mails.dpdk.org (Postfix) with ESMTP id C921440269 for ; Mon, 16 Oct 2023 18:01:56 +0200 (CEST) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4195fddd6d7so39724361cf.0 for ; Mon, 16 Oct 2023 09:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697472116; x=1698076916; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hBCMdkJUD3PTO5qcxrSsyAKPKQ38X3AEyo1yAHc6b3A=; b=YKDulsswBxMwXsrisfnau0drTrq/QgfJInVOMc1W/pYUSy8/2WJmc7mEC5Vc+VgPLU AFxOiydnuzLxk9CHm6NS1XasfrRR8hr6HAbAN99zBbUbdHrvlzuYH4/a+JB7NjLDUVEo Xk1fCNfcZMpW/ISy6n4jF0ez9LK93ySqw2OvPgNmDg1Dlrrqw52O8HCBem3RmK60WffQ CRhH10EqT0KuI9lvK+kb50A7qDcKLpEBDgsErgJr0RRZiWFZL9WZ2Z5VnDPhoHexK2Bu MkPAQzZdNs8jJcugY6FsZh39QUAH73G6d5vfK8XaWsj27Bo4VImRkun0oYMw7oMO/rHT GPlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697472116; x=1698076916; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hBCMdkJUD3PTO5qcxrSsyAKPKQ38X3AEyo1yAHc6b3A=; b=aPMQ7Aj18itx5+IZze+Gil8Nm1bnpaE0Uq0xUtGqOhaEaqdPI8nfRRFDq0jonUUPh+ +xCc9oHQXzslOlJMYjYt97ArZoUpSI0k8IxbdQJHIdz8QIu5gYAHMwnAvLJhgnVMjqiW tdE6SlaU/dPt+RAYn625mFkqFwbm0bUEoKsTaQXfmnQjrlN+n2gLoJLqJyxiTGvTvBs0 Eaj2nhsNewrv7ygSjXOr1nzvBq9RgULn9iFWQ6qvQU8REDE5Rn9yqInO5sbxuKf+oBDS dUB4YX8HlpFJsJPfRjQYlLnyjLD1AR/McMLYPBX3I8m8MT/bQDdiKbFULYoCuRSy8C3r yA7w== X-Gm-Message-State: AOJu0YyIuCY/xC7cYLDBZY97kdHh+/ojlhFn24e0rnj106pfxvE3EBHZ Erb+lHB326yLlrz/qOjSeUI77F6Gb7+G36ZzUdY= X-Google-Smtp-Source: AGHT+IGwZ/2y8kvBKWKR7xmslalN0aommOhQMreSlgL5/2VKGWWpK+tNYpYu3JRYXCjk7E0qT/Jc/sKcZwxRzr36ikQ= X-Received: by 2002:a05:622a:1052:b0:418:cec:5e64 with SMTP id f18-20020a05622a105200b004180cec5e64mr11843484qte.19.1697472115815; Mon, 16 Oct 2023 09:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20230927115412.55018-13-skori@marvell.com> <20230929095814.692890-1-skori@marvell.com> In-Reply-To: <20230929095814.692890-1-skori@marvell.com> From: Jerin Jacob Date: Mon, 16 Oct 2023 21:31:29 +0530 Message-ID: Subject: Re: [PATCH v8 00/12] add CLI based graph application To: skori@marvell.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 29, 2023 at 5:56=E2=80=AFPM wrote: > > From: Sunil Kumar Kori > > In the continuation of following feedback > https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vatt= unuru@marvell.com/ > this patch series adds dpdk-graph application to exercise various > usecases using graph. > > 1. Each use case is defined in terms of .cli file which will contain > set of commands to configure the system and to create a graph for > that use case. > > 2. Each module like ethdev, mempool, route etc exposes its set of command= s > to do global and node specific configuration. > > 3. Command parsing is backed by command line library. 1) Please update the release notes for this new app. 2) Fix following issues ### [PATCH] app/graph: add telnet connectivity framework WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #205: FILE: app/graph/conn.c:162: + strncpy(conn->welcome, p->welcome, CONN_WELCOME_LEN_MAX); WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #206: FILE: app/graph/conn.c:163: + strncpy(conn->prompt, p->prompt, CONN_PROMPT_LEN_MAX); total: 0 errors, 2 warnings, 554 lines checked ### [PATCH] app/graph: add mempool command line interfaces WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #68: FILE: app/graph/mempool.c:32: + strcpy(mpconfig.config[nb_pools].name, config->name); WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #110: FILE: app/graph/mempool.c:74: + strcpy(config.name, res->name); ### [PATCH] app/graph: add graph command line interfaces WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #166: FILE: app/graph/graph.c:113: + strncpy(graph_config.usecases[j].name, token, 31); WARNING:TYPO_SPELLING: 'Errot' may be misspelled - perhaps 'Error'? #269: FILE: app/graph/graph.c:216: + rte_exit(EXIT_FAILURE, "Errot in opening stats file\n"); ^^^^^