Re: [dpdk-dev] [PATCH v4 14/14] eventdev: mark trace variables as internal

[Jerin Jacob <jerinjacobk@gmail.com>]

On Sat, Oct 16, 2021 at 12:34 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mark rte_trace global variables as internal i.e. remove them
> from experimental section of version map.
> Some of them are used in inline APIs, mark those as global.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> ---
>  doc/guides/rel_notes/release_21_11.rst | 12 +++++
>  lib/eventdev/version.map               | 71 ++++++++++++--------------
>  2 files changed, 44 insertions(+), 39 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
> index 38e601c236..5b4a05c3ae 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -226,6 +226,9 @@ API Changes
>    the crypto/security operation. This field will be used to communicate
>    events such as soft expiry with IPsec in lookaside mode.
>
> +* eventdev: Event vector configuration APIs have been made stable.
> +  Move memory used by timer adapters to hugepage. This will prevent TLB misses
> +  if any and aligns to memory structure of other subsystems.
>
>  ABI Changes
>  -----------
> @@ -277,6 +280,15 @@ ABI Changes
>    were added in structure ``rte_event_eth_rx_adapter_stats`` to get additional
>    status.
>
> +* eventdev: A new structure ``rte_event_fp_ops`` has been added which is now used
> +  by the fastpath inline functions. The structures ``rte_eventdev``,
> +  ``rte_eventdev_data`` have been made internal. ``rte_eventdevs[]`` can't be
> +  accessed directly by user any more. This change is transparent to both
> +  applications and PMDs.
> +
> +* eventdev: Re-arrange fields in ``rte_event_timer`` to remove holes.
> +  ``rte_event_timer_adapter_pmd.h`` has been made internal.

Looks good. Please fix the following, If there are no objections, I
will merge the next version.

1) Please move the doc update to respective patches
2) Following checkpath issue
[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 14

### eventdev: move inline APIs into separate structure

INFO: symbol event_dev_fp_ops_reset has been added to the INTERNAL
section of the version map
INFO: symbol event_dev_fp_ops_set has been added to the INTERNAL
section of the version map
INFO: symbol event_dev_probing_finish has been added to the INTERNAL
section of the version map
ERROR: symbol rte_event_fp_ops is added in the DPDK_22 section, but is
expected to be added in the EXPERIMENTAL section of the version map