From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0944142B37; Thu, 18 May 2023 08:32:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91BDE42B71; Thu, 18 May 2023 08:32:04 +0200 (CEST) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id 3CEFC40E25 for ; Thu, 18 May 2023 08:32:03 +0200 (CEST) Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-43483fd0393so493533137.2 for ; Wed, 17 May 2023 23:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684391522; x=1686983522; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cjz08RB4ZWekOvCnF7uvtFP0P0hK02RfV/flcXIfmbY=; b=mj1zmqJj0goDavoV1nfkPP3PYAzgajO7+dO7+IIdmStXtq4rsq+rVGCrs/ms1Eb2H9 flFfzFdiRpTIc9yLKwiM/RhBfEwKob/jcQ62yH81tgaskS7kI3K9UiranbjAJuK+v1rG TKhzO7k23zEYBfD9Rd2uskR+Tyrrbn4TuopgqnpE/oQq84fLU1qST6mioqJpCxJE1ibw Dpb5zBkqIMGbIpmhQ/Mfx3B/juMYQYhxyWsCE48NKTGY++q5B2pWjiLICJtWgyAxt8od p5oRBbpLAWGspYN+1ez+tzYMmvGbKB5SQivM++A+04TpLLn02sckLpHmLzsKgGqhmAwb O2RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684391522; x=1686983522; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cjz08RB4ZWekOvCnF7uvtFP0P0hK02RfV/flcXIfmbY=; b=VR0ohReuZPBfxltwOobw8uhgk7sl+xGrY1HfUuvYos4E5vJVnrLEEh6HLMHw3zNQBX ZkTt8WOEysJFUdEtvO4Yx4rYyWHEVEluIQauwDzn0RxdQcLZXbnGPmWQyAcf2MR7sKEH M4VbmhmLNZ02LC8zLdoQtI8cIPzdE56xTm4mIf3hBtPPeIjEPsH8RZJk82YGjQo2Crk7 icq82F+vU9r1K92eK0RfEBjShpf/KNGLm81j+I9El1vyIGN7yJVbAI41pewNtT88TH4z 50/hW2zfxSrfOAozvyO0Q77ijeWoK9PttjBQK3kvfIfdUDSTpuKCH/kV6UQ0SyfjVEsL m4lg== X-Gm-Message-State: AC+VfDybGh3/VJmXcexnJ8Tei+YbrKjJiwb53mEZKIOLXWW+r0wu3ASu yTQ9b2xwCyValXWQAjkxiZsFj7TKvfqaGKXq8Zs= X-Google-Smtp-Source: ACHHUZ5r7dgab9JC4345CHW0FKiXKz0htHp7Q9e36IEWYPVZ3L0pNGvu2ieJCkhm04jh54d5fC1rVTKbpOCpUqMBp3g= X-Received: by 2002:a67:fb4c:0:b0:436:2479:9f54 with SMTP id e12-20020a67fb4c000000b0043624799f54mr218037vsr.4.1684391522418; Wed, 17 May 2023 23:32:02 -0700 (PDT) MIME-Version: 1.0 References: <20230425104010.339177-1-rbhansali@marvell.com> In-Reply-To: <20230425104010.339177-1-rbhansali@marvell.com> From: Jerin Jacob Date: Thu, 18 May 2023 12:01:36 +0530 Message-ID: Subject: Re: [PATCH 1/5] common/cnxk: fix IPsec IPv6 tunnel address byte swap To: Rahul Bhansali Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 25, 2023 at 4:11=E2=80=AFPM Rahul Bhansali wrote: > > Fix the IPsec IPv6 tunnel address bytes swap during SA > configurations in session create/update. > > Fixes: 78d03027f2c ("common/cnxk: add IPsec common code") Fix the following in the series Is it candidate for Cc: stable@dpdk.org backport? common/cnxk: fix IPsec IPv6 tunnel address byte swap event/cnxk: fix Tx adapter data pointer event/cnxk: fix mempool cookies check Invalid patch(es) found - checked 5 patches check-git-log failed ### [PATCH] common/cnxk: fix IPsec IPv6 tunnel address byte swap WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code")' #9: Fixes: 78d03027f2c ("common/cnxk: add IPsec common code") total: 0 errors, 1 warnings, 34 lines checked ### [PATCH] event/cnxk: fix Tx adapter data pointer WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 6a24c7c4bcd1 ("event/cnxk: add Tx adapter freeing")' #12: Fixes: 6a24c7c4bcd ("event/cnxk: add Tx adapter freeing") total: 0 errors, 1 warnings, 7 lines checked ### [PATCH] event/cnxk: fix mempool cookies check WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 7a709964d9bb ("net/cnxk: use NPA batch burst free for meta buffers")' #9: Fixes: 7a709964d9b ("net/cnxk: use NPA batch burst free for meta buffers") total: 0 errors, 1 warnings, 19 lines checked 2/5 valid patches checkpatch failed > > Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> > --- > drivers/common/cnxk/cnxk_security.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common/cnxk/cn= xk_security.c > index 79427d48fe..13ca2c7791 100644 > --- a/drivers/common/cnxk/cnxk_security.c > +++ b/drivers/common/cnxk/cnxk_security.c > @@ -274,6 +274,14 @@ ot_ipsec_inb_ctx_size(struct roc_ot_ipsec_inb_sa *sa= ) > return size; > } > > +static void > +ot_ipsec_update_ipv6_addr_endianness(uint64_t *addr) > +{ > + *addr =3D rte_be_to_cpu_64(*addr); > + addr++; > + *addr =3D rte_be_to_cpu_64(*addr); > +} > + > static int > ot_ipsec_inb_tunnel_hdr_fill(struct roc_ot_ipsec_inb_sa *sa, > struct rte_security_ipsec_xform *ipsec_xfrm) > @@ -310,6 +318,10 @@ ot_ipsec_inb_tunnel_hdr_fill(struct roc_ot_ipsec_inb= _sa *sa, > memcpy(&sa->outer_hdr.ipv6.dst_addr, &tunnel->ipv6.dst_ad= dr, > sizeof(struct in6_addr)); > > + /* IP Source and Dest are in LE/CPU endian */ > + ot_ipsec_update_ipv6_addr_endianness((uint64_t *)&sa->out= er_hdr.ipv6.src_addr); > + ot_ipsec_update_ipv6_addr_endianness((uint64_t *)&sa->out= er_hdr.ipv6.dst_addr); > + > break; > default: > return -EINVAL; > @@ -499,6 +511,10 @@ cnxk_ot_ipsec_outb_sa_fill(struct roc_ot_ipsec_outb_= sa *sa, > memcpy(&sa->outer_hdr.ipv6.dst_addr, &tunnel->ipv6.dst_ad= dr, > sizeof(struct in6_addr)); > > + /* IP Source and Dest are in LE/CPU endian */ > + ot_ipsec_update_ipv6_addr_endianness((uint64_t *)&sa->out= er_hdr.ipv6.src_addr); > + ot_ipsec_update_ipv6_addr_endianness((uint64_t *)&sa->out= er_hdr.ipv6.dst_addr); > + > /* Outer header flow label source */ > if (!ipsec_xfrm->options.copy_flabel) { > sa->w2.s.ipv4_df_src_or_ipv6_flw_lbl_src =3D > -- > 2.25.1 >