From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41A6243BCD; Fri, 1 Mar 2024 10:31:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B4824025C; Fri, 1 Mar 2024 10:31:53 +0100 (CET) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id A45F8400D5 for ; Fri, 1 Mar 2024 10:31:51 +0100 (CET) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-42e8758fd52so13630221cf.1 for ; Fri, 01 Mar 2024 01:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709285511; x=1709890311; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y0Tk8NPPPsvt3EO8xCGY3UXH5Cm/p7+9F13ot4E4Igg=; b=XPs2vUMI0mP+gxKsg5j5XqNTYlv9onDkAtd8/1S0XvMwDmHRy4Vn2bWw4P6kIs47tw hDDE26FX9hZQJFMNDVv6EsCff8i6V+VJT/FGJlpOjCkui3AaSRNtQmStudWkA5h4O4sF /Vi5ws5iI+PNANMwbAnwuP1Esn2WmY93MCcSeOinKdg4VjGAe0o/DwE0kTNsQSfpq9In 5yF5/0zFetdMoFARgfljXpDPdteSokEoGiLL9cAHZCWxgYKKCVCE3qJKPMYJnWWG7N/w QtDICStdodm9M5CraAohl8Nl781KWmQxRd9GJdM0jxkR36i5E4aGy7psD4tgEjHwKp62 dKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709285511; x=1709890311; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y0Tk8NPPPsvt3EO8xCGY3UXH5Cm/p7+9F13ot4E4Igg=; b=FHtVneOq1dbJYjWo5MSRpEI3OK77B0bDAM5LdiAYipVGK6BTnRSpJNlyNdWxhP2r2W 66Urc8qoAhZfVqIwTSo4qKpH1Fq3BSHjTON7N/fExyr0pCehR8srRrWL2EVSx1daiQ3W vlzF0sViO8zV+v8HIus62vVvqhBUlKeg31/DmiFhOS92mNz97L/ZRJ6UcHKeMRE9Jo7Z yioks9ssowjwkMfMZ/aP9eFJcTmeXCeDKruFgfsfy20x8Uj48qbsfPU6eDO5zD+henhC 61e9/UjLwp2WD6M7E8/0rmoaZR9XL7FXtcAF4End5vxr39YfO6RQnlEpRguIjDYqen1v yzfg== X-Forwarded-Encrypted: i=1; AJvYcCVjQT+1a2YuBDG0JvxGGx4srSkSbEMIxRnijOl3QgfoGxfLFSSx2W8V9LDza/Q0zizsi2azqrane9nULEE= X-Gm-Message-State: AOJu0YxpKTRuTdvv6IqoZP1crhayi8MMz6hkAq8eWp1yCRi6EIGfJr8g 6w7mi01ZuJbb4ACv8e3OFsidis96ziG/LFr6XMruzNm1l8p2uJOVFNIBXrO5EeN6JXq7cRSSrxb wj1Pq1NOAL0LVdRccdgCChMwZhM0+eGqAdxA= X-Google-Smtp-Source: AGHT+IFqeeZyAgYVZPcbZ+t2GdKNoT6MkFbHRvHmB3FSe6uBY3gW1nV369laXwRR6JjMTz9y4BGXVd0CTMu+ymeND+Y= X-Received: by 2002:ac8:57cd:0:b0:42e:c35a:122f with SMTP id w13-20020ac857cd000000b0042ec35a122fmr1013055qta.60.1709285510914; Fri, 01 Mar 2024 01:31:50 -0800 (PST) MIME-Version: 1.0 References: <20230811163419.165790-1-hkalra@marvell.com> <20240227191550.137687-1-hkalra@marvell.com> <20240227191550.137687-3-hkalra@marvell.com> In-Reply-To: <20240227191550.137687-3-hkalra@marvell.com> From: Jerin Jacob Date: Fri, 1 Mar 2024 15:01:24 +0530 Message-ID: Subject: Re: [PATCH v4 02/23] net/cnxk: implementing eswitch device To: Harman Kalra Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Anatoly Burakov , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 12:46=E2=80=AFAM Harman Kalra = wrote: > > Eswitch device is a parent or base device behind all the representors, > acting as transport layer between representors and representees > > Signed-off-by: Harman Kalra > --- > drivers/net/cnxk/cnxk_eswitch.c | 378 ++++++++++++++++++++++++++++++++ > drivers/net/cnxk/cnxk_eswitch.h | 103 +++++++++ > drivers/net/cnxk/meson.build | 1 + > 3 files changed, 482 insertions(+) > create mode 100644 drivers/net/cnxk/cnxk_eswitch.c > create mode 100644 drivers/net/cnxk/cnxk_eswitch.h > > diff --git a/drivers/net/cnxk/cnxk_eswitch.c b/drivers/net/cnxk/cnxk_eswi= tch.c > new file mode 100644 > index 0000000000..c4ea3063ae > --- /dev/null > +++ b/drivers/net/cnxk/cnxk_eswitch.c > @@ -0,0 +1,378 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2024 Marvell. > + */ > + > +#include > + > +#define CNXK_NIX_DEF_SQ_COUNT 512 > + > +static int > +cnxk_eswitch_dev_remove(struct rte_pci_device *pci_dev) FAILED: drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_eswitch.c.o ccache gcc -Idrivers/libtmp_rte_net_cnxk.a.p -Idrivers -I../drivers -Idrivers/net/cnxk -I../drivers/net/cnxk -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../l ib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/t elemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idriver s/bus/vdev -I../drivers/bus/vdev -Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu -Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/timer -I../lib/timer -Ilib/dmadev -I../lib/dmadev -Ilib/security -I../lib/security -Idrivers/common/cnxk -I../drivers/common/cnxk -Idrivers/mempool/cnxk -I../drivers/mempool/cnxk -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O2 -g -include rte_config.h -Wcast-qual -Wde precated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed -member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -flax-vector-conversions -Wno-strict-ali asing -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.cnxk -MD -MQ drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_eswitch.c.o -MF drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_eswitch.c.o.d -o drivers/libtmp_rte_net_cnxk.a.p/net_cnxk_cnxk_eswitch.c.o - c ../drivers/net/cnxk/cnxk_eswitch.c ../drivers/net/cnxk/cnxk_eswitch.c: In function =E2=80=98cnxk_eswitch_dev_r= emove=E2=80=99: ../drivers/net/cnxk/cnxk_eswitch.c:10:48: error: unused parameter =E2=80=98pci_dev=E2=80=99 [-Werror=3Dunused-parameter] 10 | cnxk_eswitch_dev_remove(struct rte_pci_device *pci_dev) | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ cc1: all warnings being treated as errors