From: Jerin Jacob <jerinjacobk@gmail.com>
To: agupta3@marvell.com
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection
Date: Mon, 4 May 2020 13:29:51 +0530 [thread overview]
Message-ID: <CALBAE1PWvX+XTB9KN6wkV48pVs-c0S0ons_HaNhOyFVCo_Vw=g@mail.gmail.com> (raw)
In-Reply-To: <1588326809-17372-1-git-send-email-agupta3@marvell.com>
On Fri, May 1, 2020 at 3:23 PM <agupta3@marvell.com> wrote:
>
> From: Amit Gupta <agupta3@marvell.com>
>
> On detecting outer L4 checksum as bad, both outer and
> inner checksums are marked as bad. No need to explicitly
> check inner L4 checksum in this case.
>
> Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
> and PKT_RX_L4_CKSUM_BAD
>
> Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD
>
> Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection")
>
> Signed-off-by: Amit Gupta <agupta3@marvell.com>
Changed the subject to: net/octeontx2: fix offload bad L4 checksum detection
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/octeontx2/otx2_lookup.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
> index 9dcfc75..10944bc 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -301,6 +301,7 @@
> errcode == NIX_RX_PERRCODE_OL4_LEN ||
> errcode == NIX_RX_PERRCODE_OL4_PORT) {
> val |= PKT_RX_IP_CKSUM_GOOD;
> + val |= PKT_RX_L4_CKSUM_BAD;
> val |= PKT_RX_OUTER_L4_CKSUM_BAD;
> } else if (errcode == NIX_RX_PERRCODE_IL4_CHK ||
> errcode == NIX_RX_PERRCODE_IL4_LEN ||
> --
> 1.8.3.1
>
prev parent reply other threads:[~2020-05-04 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 9:53 agupta3
2020-05-04 7:59 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PWvX+XTB9KN6wkV48pVs-c0S0ons_HaNhOyFVCo_Vw=g@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=agupta3@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).