From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A77E4A04AF; Mon, 4 May 2020 10:00:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57FAE1D381; Mon, 4 May 2020 10:00:09 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 47EA41D37F for ; Mon, 4 May 2020 10:00:08 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id j8so7076348iog.13 for ; Mon, 04 May 2020 01:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z5hFpk9my37dDEx0gA2Yf9NWWGQzq9h6o+6/KPyuWh4=; b=tctghtLMee9Jo58eo39UMSLCvx4qz6TYE8clbXFY7nCXP0W+ZfD17gLEE29Np9Wvom u2MQIaccnYhrfMGRxnXr+H9ioZv87TVRQhpvFSolI088luG57x36gHYtGHCFYciCjtMN In95CHIUC3pBc97yuf7KOFZUI+/Y4VbMNG7w5DfO/FAVHHtFTrrADBXYp4znclP4flMu OrQlruhDNeul6ca42MBpGnRHj7SFS0ISuBccVbdAhr/nRZgL8yaGQvUmD3qttq34b0D2 y0ULDCEhCMFmQTzwl3zlhgc/B77v8b27dowSp61ler94i9Q3fbkEKibynJ0M59BSpKCP /bbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z5hFpk9my37dDEx0gA2Yf9NWWGQzq9h6o+6/KPyuWh4=; b=o7e/ITPhMfIRfdLB+g7ZeuaoHSmAtGpfJlcMUDp+5j3rZJtBtoYsOVGwG0krluaL3W qRu9/a9RoWlcHLvHaXo/R2yY681I7y1N2i1zE/5FGCTYie5DppTlZXp45ZrzOiVa+aWh 5j2am1NNwAh5qR7lZRfxh5CIwkl6azFiofe6hc8d7ieSRvaZcqXhoEeTzw/7NV+CxNZc 4oO0bl7IjNK/Xxxy0srCUm4JoBxyAPWOfXUrvAXuqaforBVOP0q0CI5dudr864Wj9Xn+ faaBBHAIW0ugArppT7EvrJg0XQMiCQLdsNiYZu4i9XWKwANu+8aqSycz/nbARZivEAZp LehQ== X-Gm-Message-State: AGi0Puaz4OYJ/IY7Yywc4TWpStspLGT5EEGiYNAB2Sxr4tjXAoDD0Nri 2B5pG6w7evo+qhHaO0NeFxYF+eyvOE5JtV+EHZw= X-Google-Smtp-Source: APiQypKNdnlKdCo6Fa++0IHhfV21SDfq4ZdnrK8v2qCHe/qKRIiRLdFkqEOojqTsx2i+/U20rmWNsK0y/bAxbxvU/YU= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr13739430jal.60.1588579207564; Mon, 04 May 2020 01:00:07 -0700 (PDT) MIME-Version: 1.0 References: <1588326809-17372-1-git-send-email-agupta3@marvell.com> In-Reply-To: <1588326809-17372-1-git-send-email-agupta3@marvell.com> From: Jerin Jacob Date: Mon, 4 May 2020 13:29:51 +0530 Message-ID: To: agupta3@marvell.com Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 1, 2020 at 3:23 PM wrote: > > From: Amit Gupta > > On detecting outer L4 checksum as bad, both outer and > inner checksums are marked as bad. No need to explicitly > check inner L4 checksum in this case. > > Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD > and PKT_RX_L4_CKSUM_BAD > > Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD > > Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection") > > Signed-off-by: Amit Gupta Changed the subject to: net/octeontx2: fix offload bad L4 checksum detection Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeontx2/otx2_lookup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c > index 9dcfc75..10944bc 100644 > --- a/drivers/net/octeontx2/otx2_lookup.c > +++ b/drivers/net/octeontx2/otx2_lookup.c > @@ -301,6 +301,7 @@ > errcode == NIX_RX_PERRCODE_OL4_LEN || > errcode == NIX_RX_PERRCODE_OL4_PORT) { > val |= PKT_RX_IP_CKSUM_GOOD; > + val |= PKT_RX_L4_CKSUM_BAD; > val |= PKT_RX_OUTER_L4_CKSUM_BAD; > } else if (errcode == NIX_RX_PERRCODE_IL4_CHK || > errcode == NIX_RX_PERRCODE_IL4_LEN || > -- > 1.8.3.1 >