From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 611EBA0546;
	Tue,  6 Apr 2021 15:32:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D96E1140F84;
	Tue,  6 Apr 2021 15:32:55 +0200 (CEST)
Received: from mail-il1-f177.google.com (mail-il1-f177.google.com
 [209.85.166.177])
 by mails.dpdk.org (Postfix) with ESMTP id D882F140F74
 for <dev@dpdk.org>; Tue,  6 Apr 2021 15:32:54 +0200 (CEST)
Received: by mail-il1-f177.google.com with SMTP id c18so6472528iln.7
 for <dev@dpdk.org>; Tue, 06 Apr 2021 06:32:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=AmXbFHBk+zSUqFWVOHuIHs3nCAB2pZfRHxZAuC9WIgI=;
 b=PTLMM8CDqDZCmgItCEk2jVPtmpL6udkxxXBSBMQNm+M3QCwuyt8m31+GNc93+gi9UO
 x8bjOFS7+0hM+EpojhJBROL5D6bTJCB8wHQtcmsSUnrVWNUh8Uhyz5R0KIN8ssDHJpWU
 /eM8ghR7d3NFqP5wncMrBHm4AuF7hMlNOMnWh7vdEFMWmF+ejXROcA7r082aH6LIWbIB
 Y4f/UJwvtXwIIPuDows3D3/FblYs7KMjIXo6CGOpiIndngxJ5jnR7JHfJKtdG9g7s77I
 xp+cbDjb8DrNFYKXTEDExDYALGr+mHAbeqL5fT9/Affi4lhbPZVbmxTGOkQoVtBobmk7
 We1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=AmXbFHBk+zSUqFWVOHuIHs3nCAB2pZfRHxZAuC9WIgI=;
 b=XXPWmRLZLRMshqscutYamjOoU+238Er1Ek6VMTSQbLNWvSH8fvzW3RxoqWjpzzJ2KV
 7ITf3KKb0/lLDLmFTH1vuxn7rOoltAhdHTGhC3bqQ7jgBIyS12rS+XWfGgLxgpkq9Pa2
 qhVK6Pe1Lw0AxyOa+qsj/pfZOVkvnrP8KtRh22h1XSksXnJYtdPAy+6IYdhwqVVsLcOv
 zvuWMuHCzsxpDR9zQcTDxXmKDIHTWJ6Q5q14LYS1nYpcLbaNb0CRH4jBE4E1RP6NdMu2
 37JueDAuR0eCpI+0J6xdxhi30ou7Jmsibxx6nK6iOYEHlioGFdCbbI5eUrJFIW24iDSI
 M6Ow==
X-Gm-Message-State: AOAM533eHW+2oUZ+hoysgeRiOLrWLZSEbXa2Yd57INrm2zzm/m/22b98
 xbGs2jJbcOqiyn+BpBe2lojkd/GLFReNhLlBumY=
X-Google-Smtp-Source: ABdhPJz7sk5ka/ON1YzCm2mlzrvZb7rqIsORXjzCKpc+oP9Dh6MMiIV+TQ+X+y2j593q0iWkncw1GKg9oqLcJGFG8iQ=
X-Received: by 2002:a05:6e02:1087:: with SMTP id
 r7mr23495634ilj.162.1617715974287; 
 Tue, 06 Apr 2021 06:32:54 -0700 (PDT)
MIME-Version: 1.0
References: <20210309233116.1934666-1-thomas@monjalon.net>
 <20210405193954.1115838-1-thomas@monjalon.net>
 <20210405193954.1115838-5-thomas@monjalon.net>
In-Reply-To: <20210405193954.1115838-5-thomas@monjalon.net>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Tue, 6 Apr 2021 19:02:38 +0530
Message-ID: <CALBAE1PX-vqbwybEYQ9d2a8xFfBePYWoAA++x3nu_TC0x+Ay+Q@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, 
 Wisam Jaddo <wisamm@nvidia.com>, Bruce Richardson <bruce.richardson@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Reshma Pattan <reshma.pattan@intel.com>, 
 Maryam Tahhan <maryam.tahhan@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>, 
 Nicolas Chautru <nicolas.chautru@intel.com>,
 Declan Doherty <declan.doherty@intel.com>, 
 Ciara Power <ciara.power@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>, 
 Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>, 
 Bernard Iremonger <bernard.iremonger@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 6, 2021 at 1:10 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Use rte_set_application_usage_hook() in the test applications,
> so the full help including EAL options can be printed in one go
> with the EAL option -h or --help.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Wisam Jaddo <wisamm@nvidia.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
>  app/pdump/main.c                                 | 2 ++
>  app/proc-info/main.c                             | 2 ++
>  app/test-acl/main.c                              | 2 ++
>  app/test-bbdev/main.c                            | 3 ++-
>  app/test-compress-perf/comp_perf_options.h       | 2 ++
>  app/test-compress-perf/comp_perf_options_parse.c | 8 ++++----
>  app/test-compress-perf/main.c                    | 3 ++-
>  app/test-crypto-perf/cperf_options.h             | 2 ++
>  app/test-crypto-perf/cperf_options_parsing.c     | 8 ++++----
>  app/test-crypto-perf/main.c                      | 3 ++-
>  app/test-fib/main.c                              | 8 ++++++++
>  app/test-flow-perf/main.c                        | 4 +++-
>  app/test-pmd/parameters.c                        | 4 ++--
>  app/test-pmd/testpmd.c                           | 2 ++
>  app/test-pmd/testpmd.h                           | 1 +
>  app/test-regex/main.c                            | 3 ++-
>  app/test-sad/main.c                              | 7 +++++++

>
> +       rte_set_application_usage_hook(print_usage);

All DPDK APIs, We are having rte_<subsystem><...><verb> kind of API
name convention.
I think, it is better to change to rte_application_usage_hook_set() to
express the hierarchy.