From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10F6F430BE; Mon, 21 Aug 2023 11:53:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0B8142B8B; Mon, 21 Aug 2023 11:53:15 +0200 (CEST) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mails.dpdk.org (Postfix) with ESMTP id 8233E41149 for ; Mon, 21 Aug 2023 11:53:15 +0200 (CEST) Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-799761430c2so899532241.2 for ; Mon, 21 Aug 2023 02:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692611595; x=1693216395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DK7YUJwxxMrt2e6iEtirOfpLM3W95urvSenJDhYM7Sg=; b=aGZ+v23wGO7MWkK4njsYHQQ9+GHLuyZk/i4v90iZwClP1Wgy/d6SWssEHL9hfIWpO2 4eIxkjADjDWq6/Y19e3+vbs1uGQ7Lue3Bi7qzDe7zRhykW0Ho7wa3h8ZHirEM+xEg3+k +JYVOYFYpRUgXiBDRiPpkDcj7bjtctgR4wQuFPkbGTE65pCKoxOwGcUg2jsW2UUbc6O+ 4JWDlai6qNZVC+BY40E+OvDDl98U0Sgt6SIrNJVP8mp6/mQOY7ORXlYpUWLVP+Wjp7Hd 3TfxA8fk8EUUm5aZIgn+5SQNsF4MF8jEdUrCa7NCMVnQaiVxZxpeq8harCo98fjB+C8e Fkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692611595; x=1693216395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DK7YUJwxxMrt2e6iEtirOfpLM3W95urvSenJDhYM7Sg=; b=PDVWorjiLfosd86/cQKkhoGKORyrTf9II5DIAN7xnHJUVnDX4dVM4l/Rnz12epzdPr Wg0YTWjwBdQwJA3ZgRoeC+b0t6J/JU6r2HvHMdrS1p/jXtozgRqOC5M+3BiYDpWrEpI8 6w81c14KW4erG/uTyQGNVX9aEzCZYVYWeFkpm0bg1Y5h5FOM4bgbmjsy3I/S4Y0jnEeV 9EQHoZzDUPs8biPQJLGb1vjdrvEN4B1xjw4W/K9CezJzxrAezlt1k3hp9AdZQAb1uFtk zrYnUh4QCRUb1FDd4OBiAeM5jHh+07185g8naFWmn/jlFpcF3YrvNbOez6/89f4Oawmw kPag== X-Gm-Message-State: AOJu0Yy9qkhZ7/RxdsM/gvqnRNYSTASNRIuyQv/8DYtuvcsnd5QdFpE0 USWTRQKjcD4p5v1vJUYq6y6vTEG7NVYiZAzBdE4= X-Google-Smtp-Source: AGHT+IGefXrikK0f2fUNxKxlqFnnkJCEXL7FiJnjoKsUWcrNkSwMDixyuidWvT9TH/61oYbZOuXy69ShR37JIq9qh1Q= X-Received: by 2002:a67:b346:0:b0:444:c236:547 with SMTP id b6-20020a67b346000000b00444c2360547mr4571473vsm.12.1692611594805; Mon, 21 Aug 2023 02:53:14 -0700 (PDT) MIME-Version: 1.0 References: <20230817145041.239291-1-s.v.naga.harish.k@intel.com> <20230818093736.454349-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20230818093736.454349-1-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Mon, 21 Aug 2023 15:22:48 +0530 Message-ID: Subject: Re: [PATCH v5] eventdev/eth_rx: add new adapter create API To: Naga Harish K S V Cc: dev@dpdk.org, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, timothy.mcdaniel@intel.com, pbhagavatula@marvell.com, sthotton@marvell.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, harry.van.haaren@intel.com, mattias.ronnblom@ericsson.com, liangma@liangbit.com, peter.mccarthy@intel.com, jay.jayatheerthan@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 18, 2023 at 3:07=E2=80=AFPM Naga Harish K S V wrote: > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > creating Rx adapter instance. This API is similar to > rte_event_eth_rx_adapter_create_ext() with an additional input > argument for adapter configuration parameters of type > "struct rte_event_eth_rx_adapter_params". > > Signed-off-by: Naga Harish K S V > --- > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/gu= ides/prog_guide/event_ethernet_rx_adapter.rst > index 7c5e73b9fd..2e68cca798 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -71,6 +71,9 @@ set to true. The function is passed the event device to= be associated with > the adapter and port configuration for the adapter to setup an event por= t > if the adapter needs to use a service function. > > +If the application desires to control both the event port allocation and= event > +buffer size, ``rte_event_eth_rx_adapter_create_ext_with_params()`` can b= e used. > + > Event device configuration for service based adapter > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_note= s/release_23_11.rst > index 4411bb32c1..0f4e677ee9 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -72,6 +72,10 @@ New Features > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > +* **Added new Ethernet Rx Adapter create API.** > + > + * Added new API ``rte_event_eth_rx_adapter_create_ext_with_params()`` > + for creating Rx adapter instance Please add for application desires to control both the event port allocation and event buffer size, > > Removed Items > ------------- > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index f7f93ccdfd..1574c89678 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2485,6 +2485,39 @@ rxa_create(uint8_t id, uint8_t dev_id, > return 0; > } > > +static int __rte_cold Another instance of __rte_cold which is not removed. Please pay some attention when sending the new patch versions. > +rxa_config_params_validate(struct rte_event_eth_rx_adapter_params *rxa_p= arams, > + struct rte_event_eth_rx_adapter_params *temp_p= arams)