From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B846A0C41; Wed, 17 Nov 2021 12:24:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66ACE407FF; Wed, 17 Nov 2021 12:24:27 +0100 (CET) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id 5C1C340040 for ; Wed, 17 Nov 2021 12:24:26 +0100 (CET) Received: by mail-io1-f41.google.com with SMTP id c3so2617768iob.6 for ; Wed, 17 Nov 2021 03:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Kw+WDxkZEDagg7BCmQIuXXRGSmgPNSH7OTRiOK+STs=; b=ofPeu2UCCzSfPky96d0mDayvWmxSKU8eFfq3ogQ9/NQ+ZisIGyCBIiYYCwu09qwVq5 7RuTC5QH2iV1Be0ANMD/vxTcomnijSqfihB7Jhit++kmcnmkxf+EvZtcb4Joif4wTmgA Z/ZWj3mYUUoSbt0omwv5j2aCReu3rW+CX876K9mbopcu/1i1KuWsVR6nDlNZwCu8AgeB qwQRwPL4lT8462Z0oqs8VH8WERlFJcXX2MdNAO/CTdQE/7j0g8O/mGoo55BbDFPBHcK0 or+wCrZLh58BLRJfZ7cbxR/qhM1hVxoKs8Vbf090jWJ3V80+UQ4vhgcllZKLqAatxayR G7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Kw+WDxkZEDagg7BCmQIuXXRGSmgPNSH7OTRiOK+STs=; b=qm9p+Zdrg9t7gSFxPhORoHK3y+VfhGeRAO98FhN52HX+MJ2dqSEaKX3TWiCoOcZZkG 0Lb0xIP7wn6zQEymwp9ratueaC4kK0HmxpvlNMlaAhiYm3F7VdB+LoWKmA4tyJ4kAn5W W5FV7Q7oy0Gz+VPgdCtHgVHGxvM9Mfvwzxw1vZohlaTYlFOtj1zwhpPeTzHyevm2Bexl 91SaCQqZeONn2K2GsN4muAGWcU2NiqJSwsQ3c5Qmrf06ysjU3r9MbNKUtSisWhMEaSu2 SRbfjWPbHb6iRdTPoT27CPMm6Yru/BCwb3Sujf807I+X4/CJSODiL46ljx4adgB9bDe6 xQbQ== X-Gm-Message-State: AOAM533wXnmsGUi/hFuHnqRn2EpMPrmZ5YVKFFk8qCeD1eSLcUuklbDi 5ICt6WJ6bhlY7I1DQ7WuNAGRAYD3yrbjqUly3i0= X-Google-Smtp-Source: ABdhPJyaFRoEh+p0Y9WSHxKd94zn7zwS2tzqL6yUIW3fhFC+U6UfO180/ATBqv8gkoEeSvJ7VbEe4DiFZUrDKOLWSX8= X-Received: by 2002:a05:6638:2395:: with SMTP id q21mr11926081jat.48.1637148265776; Wed, 17 Nov 2021 03:24:25 -0800 (PST) MIME-Version: 1.0 References: <20211029204909.21318-1-eagostini@nvidia.com> <20211117030459.8274-1-eagostini@nvidia.com> <20211117030459.8274-2-eagostini@nvidia.com> <20211116133449.7b7d21d1@hermes.local> In-Reply-To: From: Jerin Jacob Date: Wed, 17 Nov 2021 16:53:59 +0530 Message-ID: Subject: Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools To: Elena Agostini , Ferruh Yigit , "Richardson, Bruce" Cc: Stephen Hemminger , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 +0000 > > > wrote: > > > > > > > From: Elena Agostini > > > > > > > > This patch introduces GPU memory in testpmd through the gpudev library. > > > > Testpmd can be used for network benchmarks when using GPU memory > > > > instead of regular CPU memory to send and receive packets. > > > > This option is currently limited to iofwd engine to ensure > > > > no workload is applied on packets not accessible from the CPU. > > > > > > > > The options chose is --mbuf-size so buffer split feature across > > > > different mempools can be enabled. > > > > > > > > Signed-off-by: Elena Agostini > > > > > > Won't this create a hard dependency of test-pmd on gpudev? > > > I thought gpudev was supposed to be optional > > > > Sure, let me submit another patch to make it optional Why to add yet another compile time macro everywhere in testpmd and make hard to maintain? Adding iofwd kind of code is very simple to add test/test-gpudev and all GPU specific options can be added in test-gpudev. It also helps to review the patches as test cases focus on each device class.