From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEEA5A0350; Sun, 10 May 2020 09:04:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66F1F1D534; Sun, 10 May 2020 09:04:43 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 4752E1D166 for ; Sun, 10 May 2020 09:04:42 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id k18so6198370ion.0 for ; Sun, 10 May 2020 00:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cY0gRGiOTQq46FiHMioQrOcsvAaJxCdQ3jGJ3xH6uOQ=; b=DjAZrt5aBbYClDp3zX+aFE5gyPxMkx0pAxh/qFgrqoDg0po4T0K/ZgsfNDRTI4ODya ANJiQhWZdj0KL2HOdCqwoIFiCeNhCxJ85EVAy1cTs9t0f5RCzM3N1jnXwrJY3BTi3oUA 0OO3NFMFf3nmnEhRag8FFpi9e6IXlZOZ+lhPySHAt0kUfT9CIr+qs20ziBK6Ga2zMkyS /Oiy/rQFwHR5xYvSsTFktJUslplAUww6XaIdKZ+HCxr/S+w+inBSPXkZhUFWR0dHUvXA 655P72yOEmcHq7kWqbjPp+DtV6pNUh3Be3sD72x6okAi0zfeuvtrtnVHLAlvFHORvDK7 oNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cY0gRGiOTQq46FiHMioQrOcsvAaJxCdQ3jGJ3xH6uOQ=; b=oJpW8DjmHIP+yQjP+mFDPzjKEIdxjGllj+zCSFk3zA1QCJo40W+sEnChfQ5x9vwMur Icfc+QwTtF3Ws9z8DiGUYqUHMuNMyjvwDfQyYpiBdqifjd/S5cXMZxJzpoHETxZxqssZ wQO9eJHMZ2/+6E1nUgYHmaKNnYa9SKsGhmwzcn/zxTHDOLeBdkuEWn5JkJ1bZaslTv9b 5xtOKjmJFivatrngETyqAGooaZw0WLBU4JGo1cN+YSN1od0ozPjpqacg0XCBB8ssZA6j SV/uEpAYrnRpqgmIUshljgoiMsuIN48/MGoSO3F6d5QbBKKTF3XrB/OsCztrZKEm+CLG f+Qw== X-Gm-Message-State: AGi0PubpWq1AI4+qcD7e5Eol43ywHRAGt/v/xZij/y0KwAaynWk1X1fe TgcPIH4C4CMkyY6Wlx5cMJqLPbtlaWbpWcAyHN4= X-Google-Smtp-Source: APiQypKvTwB8spMPyA68K0ltSiL8/Do0Q5PlMw2DJdmXRfUKZDG8Su82asZ+hinPtCnxyFKWcaEqoqrAhI6Hrg8IuDE= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr9734800jal.60.1589094281409; Sun, 10 May 2020 00:04:41 -0700 (PDT) MIME-Version: 1.0 References: <20200505030943.1091-1-rmody@marvell.com> <4248918.cEBGB3zze1@thomas> In-Reply-To: From: Jerin Jacob Date: Sun, 10 May 2020 12:34:25 +0530 Message-ID: To: Rasesh Mody Cc: Thomas Monjalon , Ferruh Yigit , dpdk-dev , Jerin Jacob Kollanukkaran , GR-Everest-DPDK-Dev , Igor Russkikh , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 8:13 AM Rasesh Mody wrote: > > Hi, > > >From: Thomas Monjalon > >Sent: Tuesday, May 05, 2020 2:15 AM > > > >05/05/2020 10:59, Ferruh Yigit: > >> On 5/5/2020 7:44 AM, Jerin Jacob wrote: > >> > On Tue, May 5, 2020 at 8:39 AM Rasesh Mody > >wrote: > >> >> > >> >> Some applications do not explicitly restore Tx queues setup during > >> >> port re-configuration. This patch adds changes to check for > >> >> released Tx queues and restore the setup if application doesn't > >> >> explicitly does that. > >> > > >> > +ethdev maintainers. > >> > > >> > I think, Ideally, the fix should be in common code if we need to > >> > support such applications. > >> > >> Is this a case application re-configures to increase the number of > >> queues but doesn't setup new queues? > >> If so this looks like application error and application should be > >> fixed instead of recover this in the ethdev. > > > >+1 > > > > This is a case of KNI application performing device re-configuration to c= hange MTU. The application explicitly calls Rx queue setup, however doesn't= call Tx queue setup. When MTU for KNI interface is changed it runs into a = segfault when trying to start Tx queues. Can we fix the KNI application then? > Some other applications make use of rte_eth_dev_set_mtu() ethdev op, whic= h looks to be cleaner approach. > > Thanks! > -Rasesh >