Re: [dpdk-dev] [PATCH v2 3/3] event/octeontx2: add crypto adapter datapath

[Jerin Jacob <jerinjacobk@gmail.com>]

On Thu, Sep 17, 2020 at 10:47 AM Ankur Dwivedi <adwivedi@marvell.com> wrote:
>
> In the op new mode of crypto adapter, the completed crypto operation
> is submitted to the event device by the OCTEON TX2 crypto PMD.
> During event device dequeue the result of crypto operation is checked.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>

> @@ -66,8 +67,10 @@ otx2_ssogws_get_work(struct otx2_ssogws *ws, struct rte_event *ev,
>         ws->cur_tt = event.sched_type;
>         ws->cur_grp = event.queue_id;
>
> -       if (event.sched_type != SSO_TT_EMPTY &&
> -           event.event_type == RTE_EVENT_TYPE_ETHDEV) {
> +       if (event.sched_type == SSO_TT_EMPTY)
> +               goto setev_and_return;

Please move the security updation under the security flag template to
avoid performance impact
on nonsecurity case.

> +
> +       if (event.event_type == RTE_EVENT_TYPE_ETHDEV) {
>                 otx2_wqe_to_mbuf(get_work1, mbuf, event.sub_event_type,
>                                  (uint32_t) event.get_work0, flags, lookup_mem);
>                 /* Extracting tstamp, if PTP enabled*/
> @@ -76,8 +79,11 @@ otx2_ssogws_get_work(struct otx2_ssogws *ws, struct rte_event *ev,
>                 otx2_nix_mbuf_to_tstamp((struct rte_mbuf *)mbuf, ws->tstamp,
>                                         flags, (uint64_t *)tstamp_ptr);
>                 get_work1 = mbuf;
> +       } else if (event.event_type == RTE_EVENT_TYPE_CRYPTODEV) {
> +               get_work1 = otx2_handle_crypto_event(get_work1);
>         }
>