From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EEDA5A0588;
	Wed,  1 Apr 2020 18:58:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3EE381BFD9;
	Wed,  1 Apr 2020 18:58:32 +0200 (CEST)
Received: from mail-io1-f66.google.com (mail-io1-f66.google.com
 [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 5584F1BFC3
 for <dev@dpdk.org>; Wed,  1 Apr 2020 18:58:31 +0200 (CEST)
Received: by mail-io1-f66.google.com with SMTP id q9so441986iod.4
 for <dev@dpdk.org>; Wed, 01 Apr 2020 09:58:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=x8jGzOvwKw2KcGjAYWS9sJ8gr2+HDg81Dc8k7hskh4w=;
 b=ro/bERDBkw2KQBDmx1WiF9qmEaKf19etQOZQX5cb4MV8e8BiMK2bAsq+hfWWbj7vwV
 Fv33vbOnmBde1P4Mq/1PreSTVpp3XlZEUwpbWGSQ7SkO9OJLG2Wb4lgyaOuHEDKt8vhV
 9a1BUlsOtvujT+UBslAZ9VFBIO056qlbK++CeHo766O2+fc/Sk0qh5FBKLm+z6NYv7yv
 iWzVE1ZarqTq1dZFHRl/eV+laXXP9T0j6lfEqF9uTVlo6mIUw/5ggVWz3d6ZBVUc39ab
 /e0R7ar0rQ3tZDGyOOAZABvuNPlNfGEwjMXJW8LC2xj2iQ6G1+ldf95Oo6ytT6yKway4
 N1bw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=x8jGzOvwKw2KcGjAYWS9sJ8gr2+HDg81Dc8k7hskh4w=;
 b=UkFEic05lDGgNHrCtOcjmDb24R4uOG9dz4bFIYUnyjO1X5p2kIgP2m4o7izer7oC1s
 wK4SjwTUZxMAwBl2qte2dHKdq5ALUFqxgk8Yrim9e+HL0C+t6bbtLn4o21P8bpqdapE0
 kJzs0lgORQXS0Y0xk5SlSB9CxWsDcJ5kMXoPeCWx10YKXPb20TMo46iaVNo+tlx9pbSY
 EzHNcibY/03J31T67yrx+Tl/Fpo1xLOv6gpfnOkqE33RNBbFTlfeqm0Rj50ShFgyzl1E
 SvJYu9yCL51QqgPFzDDuYCOTa64Pf7RO4MBQsndCSU3lBqcaq6W2b49NtqZtKF1FlSVI
 zYuQ==
X-Gm-Message-State: ANhLgQ3ogysq2EPrjz6qPJEA+O/apS8zgrK67osvOzgRmAJ+V/JszaAn
 m3c93PZYfI07pl0hmP0kmqiNVlvWctYyXj7tPVs=
X-Google-Smtp-Source: ADFU+vud1J3wdbBS8e6GXWiyEuAtNApP73lQilDWovsVFgNfHD+H9msB72XADPpHG4a0NldBp8ttYbTlEabHqfj7g9k=
X-Received: by 2002:a6b:dd14:: with SMTP id f20mr21964696ioc.123.1585760310567; 
 Wed, 01 Apr 2020 09:58:30 -0700 (PDT)
MIME-Version: 1.0
References: <20200325211603.240288-1-jerinj@marvell.com>
 <20200329144342.1543749-1-jerinj@marvell.com>
 <CAJFAV8zJrXvrR0epT-rbHRT0Cd319fLQcxT9AmEiUKGm4tX0Pw@mail.gmail.com>
 <CALBAE1PiDhXeQE0xbwm_fkZp-t1n=G8T5ZkRXu9hF8qoS5N-oA@mail.gmail.com>
 <CAJFAV8woQYDOUJ7XPb+Px-17d+gjJrYSeiHMhYn4qoum7y5KJA@mail.gmail.com>
 <CALBAE1Ocbmx8k4XCCTy8pQf0wVkOD1QhGY=W=xVrybUt3w8ASA@mail.gmail.com>
 <20200401164604.GB152@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20200401164604.GB152@bricha3-MOBL.ger.corp.intel.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Wed, 1 Apr 2020 22:28:14 +0530
Message-ID: <CALBAE1PbqpMwxwFcDU7pw6OhBcywugj7kxhFUUU3Ug4ihyg0tg@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, 
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, 
 =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, 
 Sunil Kumar Kori <skori@marvell.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Declan Doherty <declan.doherty@intel.com>, 
 Olivier Matz <olivier.matz@6wind.com>, Neil Horman <nhorman@tuxdriver.com>, 
 Ray Kinsella <mdr@ashroe.eu>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Apr 1, 2020 at 10:16 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:

> > > >
> > > > Since the trace changes in the "inline" functions of the specific
> > > > library already
> > > > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and
> > > > it is using RTE_TRACE_POINT_DP() to define the trace unlike slow path
> > > > trace like RTE_TRACE_POINT().
> > >
> > > Ah indeed.
> > > Note: RTE_ENABLE_TRACE_DP is not plugged with meson.
> >
> > If you see the " eal: define the public API for trace support" patch,
> > I have updated rte_config.h for meson likewise for other configuration
> > such log for DP.
> > Would you like to have a meson option? and update in meson_options.txt.
> >
> > I don't have a strong opinion on either way? Bruce ,any thoughts?
> >
> Since it's likely that developers will be wanting to switch this option on
> and off, I think an explicit option rather than hard-coded constant should
> be the way to go.

OK. I will add an explicit option in the next version.

>
> However, an alternative might be to add in the DP tracing for debug builds
> but not for others. This would save a build option, but may be more
> restrictive, since debug builds can also be optimized ones.

I think it will be restrictive.


>
> /Bruce