From: Jerin Jacob <jerinjacobk@gmail.com>
To: pbhagavatula@marvell.com
Cc: jerinj@marvell.com, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
dev@dpdk.org
Subject: Re: [PATCH v2] event/cnxk: fix incorrect mbuf offset calculation
Date: Mon, 7 Nov 2022 17:30:18 +0530 [thread overview]
Message-ID: <CALBAE1Pc7rCR-OYB3j0CBEyiFsTGk4zzdA42Oe2LEAHN8E1aPQ@mail.gmail.com> (raw)
In-Reply-To: <20221025161129.15933-1-pbhagavatula@marvell.com>
On Tue, Oct 25, 2022 at 9:41 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix incorrect mbuf offset calculation when HEADROOM exceeds 128B
> while processing event vectors.
>
> Fixes: 7fbbc981d54f("event/cnxk: support vectorized Rx event fast path")
Cc: stable@dpdk.org
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> v2 Changes:
> - Remove internal Change-Id.
>
> drivers/net/cnxk/cn10k_rx.h | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h
> index 46488d442e..f562a75245 100644
> --- a/drivers/net/cnxk/cn10k_rx.h
> +++ b/drivers/net/cnxk/cn10k_rx.h
> @@ -1201,9 +1201,11 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
> mbuf23 = vqsubq_u64(mbuf23, data_off);
> } else {
> mbuf01 =
> - vsubq_u64(vld1q_u64((uint64_t *)cq0), data_off);
> - mbuf23 = vsubq_u64(vld1q_u64((uint64_t *)(cq0 + 16)),
> - data_off);
> + vsubq_u64(vld1q_u64((uint64_t *)cq0),
> + vdupq_n_u64(sizeof(struct rte_mbuf)));
> + mbuf23 =
> + vsubq_u64(vld1q_u64((uint64_t *)(cq0 + 16)),
> + vdupq_n_u64(sizeof(struct rte_mbuf)));
> }
>
> /* Move mbufs to scalar registers for future use */
> --
> 2.25.1
>
prev parent reply other threads:[~2022-11-07 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 15:46 [PATCH] " pbhagavatula
2022-10-25 16:11 ` [PATCH v2] " pbhagavatula
2022-11-07 12:00 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1Pc7rCR-OYB3j0CBEyiFsTGk4zzdA42Oe2LEAHN8E1aPQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).