From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73D52A04B6; Sun, 11 Oct 2020 12:33:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2B031D559; Sun, 11 Oct 2020 12:33:36 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 2880A1D53A for ; Sun, 11 Oct 2020 12:33:35 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id y20so10588892iod.5 for ; Sun, 11 Oct 2020 03:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=582Pk+LS4b1A4HsuHgdEhrMLXs2qZTfNTLWm8SLhcdU=; b=ZCc8ITbxTG98rZQ7M5u0G4yXXy3BGbxFQ9QTauxfYJOGdPD5LlGXX5w7TbJJ8bjem8 qLbzWrIAvsO/ir4l9kmBFIGkmAcI1zWtHzbzA4nRSYivgWeKq/nKgJX/UsCcq6CnJYwF flvtkuYsfS+LShfh9zVfyfoP2FkKX6bR0LqR5I8eCpq/MH8pfm3GbWZ38xD6QpWk6V1o ueV6dDcty1G4nxw0NVYMAd88mMfk5csopz2FDxJgJIzTexUGt/DVMZnPwv0LX7OJDX2N eYCwdJ+IeidT0mmKde8Lj52w5DG075c2/57h/LvDD8JCGieWhRcuxN+rvUcKOta67Ej8 ZvZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=582Pk+LS4b1A4HsuHgdEhrMLXs2qZTfNTLWm8SLhcdU=; b=gIjqlYg/VgFM9Mmz767A8xdt2Ynd2pkXEyemGCA51KMAcwVgvFCggKL9v5JMqZeLsD 4mZorhcbm7/xNPLeiARvlJmk/v0FGqb9eMnmGR4RAwkmEbMwsE6J8iPfOppXgCXgqHdY GJXERDm4awKz6ozS20ncgc7wG7bMU6JkkdL2BR1C0SkR84Iszy6zbjajXnasT56ESbZ4 +fwuqCC5k6fVTRg5B+VijM2iVjayzARUP7AmNKezXiTGcuoG582qDe13g7a9+6VMxb5y q3AVbz/FwMt072xn2yxdLhNDVedEhHglCK1aXCggouuUBPCP5X5xFkVUUuo3tINPgkTr eZVA== X-Gm-Message-State: AOAM531m/kkM5Tys6etH4AodgjGV9NVDI+mN9pIJr4zyIo6rkwdslAvH APlJohyqVQtuzeUL/EqrLfVv0xKCfADJGTyfntE= X-Google-Smtp-Source: ABdhPJyqpHEW94E+d26I39gskblLaYjHoCJKATYK+TA4w9fGJmA1ZxQ8Ag3ORqbcjuDX7294yFMzyxhWZQf7p4voI90= X-Received: by 2002:a05:6638:446:: with SMTP id r6mr11264560jap.60.1602412413408; Sun, 11 Oct 2020 03:33:33 -0700 (PDT) MIME-Version: 1.0 References: <1602182927-18254-1-git-send-email-hkalra@marvell.com> <1602182927-18254-4-git-send-email-hkalra@marvell.com> In-Reply-To: <1602182927-18254-4-git-send-email-hkalra@marvell.com> From: Jerin Jacob Date: Sun, 11 Oct 2020 16:03:17 +0530 Message-ID: To: Harman Kalra , "Van Haaren, Harry" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Nipun Gupta , Pavan Nikhilesh , Erik Gabriel Carrillo , "Rao, Nikhil" , Hemant Agrawal , "Gujjar, Abhinandan S" Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra wrote: > > Since we are not holding the mbufs or creating any references > in the app, hence mbuf fast free offload can be enabled. > > Signed-off-by: Harman Kalra > --- > app/test-eventdev/test_pipeline_common.c | 5 +++++ ++ eventdev maintainers Since testeventdev is not creating more than one pool and not using any mbuf reference feature. This change looks to me. Let me know if you have any different opinion if nay. Acked-by: Jerin Jacob > 1 file changed, 5 insertions(+) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 17088b1b4..f0c0ffea7 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > return ret; > } > > + /* Enable mbuf fast free if PMD has the capability. */ > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > + local_port_conf.txmode.offloads |= > + DEV_TX_OFFLOAD_MBUF_FAST_FREE; > + > rx_conf = dev_info.default_rxconf; > rx_conf.offloads = port_conf.rxmode.offloads; > > -- > 2.18.0 >