From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E955A04E7; Mon, 2 Nov 2020 15:04:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89BAFC8D2; Mon, 2 Nov 2020 15:04:35 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 9332DC8CC for ; Mon, 2 Nov 2020 15:04:33 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id n12so3363370ioc.2 for ; Mon, 02 Nov 2020 06:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ffDpC3c5DZQZiMBsaYZzssLsrPTIvrGaQ/vzho8JFaw=; b=ZGV3RaMU0G0OD3P50S0CZXT60wO8ST6driTeZzNeeydcMlSdIzFjUFqLrZgLIe0D71 BQK+3NOZU61m+e8g25i8RRrb15z6xcuOo1R6+pmapY8P9c/eaQ96M6GokJYKYfjX6f/P eyvaWgRydyZBVly7F6gCywTNTewWEDDlPS+xve0LtHY2oEVyIB2S0xNHEIIygFwRelAJ 1RBXACFr9avn9KYsrU6IKqGnU2VZ8Mkz2Rrn0h7VS/++T9TF9MuRxmPKWDAoMs+b989s oQf3bSdpVc59zwKueYKWKr2k9sSyhRM4Si5o8Pmg7WBFknxrMp72idkBF8ZyVbmvJ4Ht 0x4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ffDpC3c5DZQZiMBsaYZzssLsrPTIvrGaQ/vzho8JFaw=; b=AkXJLhHHL1JI/jNZ93RqkHZmpLS639lm6TI0T7gb0lglUgCQRymyhS4npsZ35uGfLh eB/RqZJfRrhag7DJqehlsTe3hMD41oKLEDaAlPoBWVDv912QdCEwLI4A8A04fIOY11bl B9/BIY828TOH3EKZ/SOocjykhihWdF6tdA1t9rTKMHkBSZdpu4r2R6YEnE1FRhuyOBXc Y6MnIfxLPKdlA18g2CG2h2qNN1US1JK5eolcX942YZF9iZ0Zg98WS3aCJf6S3V2cGgdO eHG8rxlpBzi/g4m4kqGTttNnOpBuu5LD2q/AFFG0Or6kx7hVZ1To2jLC2jdQy0OUrsdo teXA== X-Gm-Message-State: AOAM530to/MFu25Ql8tQP0JS1NBTNu78oGJWe9C00AnjTtVTRVdYJiHo HoBQIveQItM3OmYfyqtFh/Bg81/22Hh6kmhMC0E= X-Google-Smtp-Source: ABdhPJxq6deeahVK3PLZR2/hHkIWIf+JPDqLDoO7pu1XstoK/y2vik6VLsCEj5vJzvOn/EvQHCiblHJFl5hIxFUlHG0= X-Received: by 2002:a05:6602:235b:: with SMTP id r27mr10935417iot.123.1604325871796; Mon, 02 Nov 2020 06:04:31 -0800 (PST) MIME-Version: 1.0 References: <20201101203644.1697-1-david.marchand@redhat.com> In-Reply-To: From: Jerin Jacob Date: Mon, 2 Nov 2020 19:34:15 +0530 Message-ID: To: "McDaniel, Timothy" Cc: David Marchand , "dev@dpdk.org" , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: check input parameter for dump op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 2, 2020 at 2:22 AM McDaniel, Timothy wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Sunday, November 1, 2020 2:37 PM > > To: dev@dpdk.org > > Cc: McDaniel, Timothy ; Jerin Jacob > > > > Subject: [PATCH] eventdev: check input parameter for dump op > > > > Rather than have drivers check for this, let's ensure the passed FILE * > > is not NULL. > > > > Signed-off-by: David Marchand Applied to dpdk-next-eventdev/for-main. Thanks. > > --- > > lib/librte_eventdev/rte_eventdev.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.c > > b/lib/librte_eventdev/rte_eventdev.c > > index 994bd1eaa9..afbadc535b 100644 > > --- a/lib/librte_eventdev/rte_eventdev.c > > +++ b/lib/librte_eventdev/rte_eventdev.c > > @@ -1153,6 +1153,8 @@ rte_event_dev_dump(uint8_t dev_id, FILE *f) > > RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > > dev = &rte_eventdevs[dev_id]; > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dump, -ENOTSUP); > > + if (f == NULL) > > + return -EINVAL; > > > > (*dev->dev_ops->dump)(dev, f); > > return 0; > > -- > > 2.23.0 > > Looks good to me. > > Reviewed-by: Timothy McDaniel