DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH 1/2] app/eventdev: use mempool cache for vector pool
Date: Fri, 10 Jun 2022 19:14:48 +0530	[thread overview]
Message-ID: <CALBAE1PcuhNYcGrfH36648zrM49LwZcSG61MK=w3Fc7_oziJSQ@mail.gmail.com> (raw)
In-Reply-To: <20220523095954.3181-1-pbhagavatula@marvell.com>

On Mon, May 23, 2022 at 3:30 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Use mempool cache for vector mempool as vectors are freed by the Tx
> routine, also increase the minimum pool size to 512 to avoid resource
> contention on Rx.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  app/test-eventdev/test_pipeline_common.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index c66656cd39..856a2f1a52 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -338,9 +338,10 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, uint8_t stride,
>         if (opt->ena_vector) {
>                 unsigned int nb_elem = (opt->pool_sz / opt->vector_size) << 1;
>
> -               nb_elem = nb_elem ? nb_elem : 1;
> +               nb_elem = RTE_MAX(512U, nb_elem);
> +               nb_elem += evt_nr_active_lcores(opt->wlcores) * 32;
>                 vector_pool = rte_event_vector_pool_create(
> -                       "vector_pool", nb_elem, 0, opt->vector_size,
> +                       "vector_pool", nb_elem, 32, opt->vector_size,
>                         opt->socket_id);
>                 if (vector_pool == NULL) {
>                         evt_err("failed to create event vector pool");
> --
> 2.25.1
>

  parent reply	other threads:[~2022-06-10 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23  9:59 pbhagavatula
2022-05-23  9:59 ` [PATCH 2/2] examples: " pbhagavatula
2022-06-10 13:46   ` Jerin Jacob
2022-06-10 13:44 ` Jerin Jacob [this message]
2022-06-13  5:56   ` [PATCH 1/2] app/eventdev: " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1PcuhNYcGrfH36648zrM49LwZcSG61MK=w3Fc7_oziJSQ@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).