From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F991A0566; Mon, 8 Mar 2021 19:14:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4B6E22A46F; Mon, 8 Mar 2021 19:14:15 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id AAC9322A461 for ; Mon, 8 Mar 2021 19:14:14 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id f20so10931428ioo.10 for ; Mon, 08 Mar 2021 10:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v/7Jsl0z0m2yu6Ure5PTfOThevSTLHJlsWhiCH358GY=; b=WQwokqag5uUYovVUnktzd9ujzVOJeiLm8bIiUVDc3p/4D6+/osI1ZxZxL3+T4nrcqf GSry7TY3gdmzqFbz3uwTchRoEZ8mudiSm7GH2jnFsg/v5PbQg/ICgG9jcQH2qCHPZr2m r9IUd6Ia+GUDWytiN80gOWKD7BWeOasojFjcmTdNW3MCpMrWQWAW9GjPpayvqqTNbC9i d1dluN6cereV82dj8KEGskzVHYZ9VpPXi4nCd6Pqf0ikNXq/U/rAtltXt/b4dydcUr10 LCX3ih1yOI64zwQXwGRVW95qEBYRxan7iERIRVEdWQB5OD330TFasLxlrc9aKewmpsnM kTGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/7Jsl0z0m2yu6Ure5PTfOThevSTLHJlsWhiCH358GY=; b=plRLpQiVWFmd1f5VnHx2IjxD2c1cXKPNJObQn6V44QJUjXIb6Jmbl5zlMKeS0CqDjJ /rvWtL93oYnkbGWCGTFZADYoqKUoa70OQUSyZb8NWAGD66OM0jtfDpOj2zW4ZX1ljPzI PsDGnIfbGdykKGc4m7MP/BccKefYUcxwxKUL9GawQj324mEozOzRoTSBmgsYTUZ9JQlz 9f58VL75qkOnTNet4M4getUb+5He/KINcqUcV4xt0weHIC7BtVyi0ial3zPs5Vfjp0TE UagfeDZNY8/M8y0BuAjkmbwEW5lGu7CQpx1fDNVk8MAbYrX5Fppom0tXc+5lIb36418T uDsw== X-Gm-Message-State: AOAM531ospV6ZIqu844o/yv/BUbhs2av+Lwo9GV7jyNtOQQfzvfI5LBc /gN2z7jTrFlv2tvFrkREiUyCOojUzjujNBRoGtM= X-Google-Smtp-Source: ABdhPJzHTF1ewLwmFBkQdWhm3N2chVXrN+XtlWzr0JmjfdjnVO4Fe53Uj3AACuWnWnuoeMmwACGI0bPR1ZugjTGtAdM= X-Received: by 2002:a05:6638:1653:: with SMTP id a19mr24526653jat.113.1615227254031; Mon, 08 Mar 2021 10:14:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Mon, 8 Mar 2021 23:43:58 +0530 Message-ID: To: Balazs Nemeth , Rasesh Mody , Shahed Shaikh Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/8] Optimize qede use of rx/tx_entries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 5, 2021 at 6:44 PM Balazs Nemeth wrote: > > This patch set optimizes qede_{rx,tx}_entry and introduces > rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance > improvement depends on the use-case; in a physical-virtual-physical test > on a ThunderX2 99xx system with two SMT threads used in ovs, > and two cores used in a vm, an improvement of around 2.55% is observed > due to this patch set. Cc: rmody@marvell.com Cc: shshaikh@marvell.com Hi Rasesh, Shahed Could you review this series from Balazs? > > Balazs Nemeth (8): > net/qede: remove flags from qede_tx_entry and simplify to rte_mbuf > net/qede: avoid repeatedly calling ecore_chain_get_cons_idx > net/qede: assume txq->sw_tx_ring[idx] is never null in > qede_free_tx_pkt > net/qede: inline qede_free_tx_pkt to prepare for rte_pktmbuf_free_bulk > net/qede: use rte_pktmbuf_free_bulk instead of rte_pktmbuf_free > net/qede: prefetch txq->hw_cons_ptr > net/qede: prefetch next packet to free > net/qede: remove page_offset from struct qede_rx_entry and simplify > > drivers/net/qede/qede_rxtx.c | 148 +++++++++++++++++++---------------- > drivers/net/qede/qede_rxtx.h | 21 +---- > 2 files changed, 81 insertions(+), 88 deletions(-) > > -- > 2.29.2 >