From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DFD9A0548; Thu, 11 Nov 2021 16:18:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66CC040E28; Thu, 11 Nov 2021 16:18:28 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 07EBF40E03 for ; Thu, 11 Nov 2021 16:18:27 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id w22so7357255ioa.1 for ; Thu, 11 Nov 2021 07:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EJ8m8KMMw0pAgJHZmpa0fBY0COt7c2EkD3ztmvgDa74=; b=XMeI5Tp71J+EuVj+7n8k/OjSj2pQjzYDzTlTCOCheXTVyNKn3V9nxGhoOaQW5PBskD /89l0iCi0UcpK+47chOxI/KarvxVO5JnJXo+0cD/a+qxPwNr7Lw89aFWyDeqPdfv7uCY zzFA9vZytxa8Qp1BLrLh+YIOv69nqkEzOI+VAPhJZ1gw26m09XwZHGUKpGn62ETFOqgC t1qDR3c5bLF4VFzcBrasS6kZxme5D1Bn0YLu071hWb/esEIOz8/ZwE8PzT6AAHQWh8+i 4gUCVZgESBeB9HJMmOsfdH7Gg+ZchHlWT1YembqskF1IwgqgHYpiDiZjP2zOivGa3FX5 adhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EJ8m8KMMw0pAgJHZmpa0fBY0COt7c2EkD3ztmvgDa74=; b=yS8ezsLQfyQ2qW1B/LxHWjnRLZRj6qMbabgnGY9t4U50bXQ8mpRPgTddp84X77moze l85K3+90aPOTlJNmVdy/WUm148C9Ka7/iHq56poYhgpNBYM/nyGx5XAUrQudlifJyORx si4dSeFAO+ZYkGbdY9L+FLaG3Cy0hndFnIGt4CR/HT+n/TKOVL5SFRIEdX5/FZ/WDu2C ZEWmf/xgO0k6uT+78v+XHf0kxlp6r9AL+p9HURJ5qvRrUUeIx+uzhDUosnwveaopf3Ua owgO5IeDcjwW284DN9+Wb42KEcH0I84+sjzMum21e2X0BwxKNqrX8OVF36niEgOtoEmD tnfA== X-Gm-Message-State: AOAM5336qvkbsTr62lLvdYabKiIbLzie9EzHvwUTDynW/suG2sWdU+lr AJLFmnJN7Ur7BpmCKgM49FDoc4Wo2pDU/ZSX2pI= X-Google-Smtp-Source: ABdhPJx8V2ikEPMmKc9dHEkb8lzLtfU0aE4N8nvLepwMZS1d0OaEYSCNHSD94/eNoy0aY3GuUTJXnVcJZIPto4DWVbM= X-Received: by 2002:a05:6638:2395:: with SMTP id q21mr5852964jat.48.1636643906476; Thu, 11 Nov 2021 07:18:26 -0800 (PST) MIME-Version: 1.0 References: <1636517315-414-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1636517315-414-1-git-send-email-anoobj@marvell.com> From: Jerin Jacob Date: Thu, 11 Nov 2021 20:48:00 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix memory leak To: Anoob Joseph , Ferruh Yigit Cc: Jerin Jacob , dpdk-dev , Srujana Challa Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 10, 2021 at 9:39 AM Anoob Joseph wrote: > > The memory allocated for temporarily keeping DPTR need to be freed after > operation. > > Also, dptr need to be aligned to 8B. > > Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through microcode op") > Cc: schalla@marvell.com > > Signed-off-by: Anoob Joseph > Reviewed-by: Nithin Kumar Dabilpuram > Reviewed-by: Tejasree Kondoj Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_cpt.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c > index 5c8c328..51cd612 100644 > --- a/drivers/common/cnxk/roc_cpt.c > +++ b/drivers/common/cnxk/roc_cpt.c > @@ -930,12 +930,14 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr, > plt_err("Couldn't allocate memory for result address"); > return -ENOMEM; > } > - dptr = plt_zmalloc(sa_len, 0); > - if (!dptr) { > + > + dptr = plt_zmalloc(sa_len, 8); > + if (dptr == NULL) { > plt_err("Couldn't allocate memory for SA dptr"); > plt_free(res); > return -ENOMEM; > } > + > for (i = 0; i < (sa_len / 8); i++) > dptr[i] = plt_cpu_to_be_64(((uint64_t *)sa_dptr)[i]); > > @@ -962,6 +964,7 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr, > plt_delay_ms(1); > > plt_free(res); > + plt_free(dptr); > > return 0; > } > -- > 2.7.4 >