* [dpdk-dev] [PATCH] common/cnxk: fix memory leak
@ 2021-11-10 4:08 Anoob Joseph
2021-11-10 4:32 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2021-11-11 15:18 ` [dpdk-dev] [PATCH] " Jerin Jacob
0 siblings, 2 replies; 3+ messages in thread
From: Anoob Joseph @ 2021-11-10 4:08 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Anoob Joseph, dev, schalla
The memory allocated for temporarily keeping DPTR need to be freed after
operation.
Also, dptr need to be aligned to 8B.
Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through microcode op")
Cc: schalla@marvell.com
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Reviewed-by: Tejasree Kondoj <ktejasree@marvell.com>
---
drivers/common/cnxk/roc_cpt.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c
index 5c8c328..51cd612 100644
--- a/drivers/common/cnxk/roc_cpt.c
+++ b/drivers/common/cnxk/roc_cpt.c
@@ -930,12 +930,14 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
plt_err("Couldn't allocate memory for result address");
return -ENOMEM;
}
- dptr = plt_zmalloc(sa_len, 0);
- if (!dptr) {
+
+ dptr = plt_zmalloc(sa_len, 8);
+ if (dptr == NULL) {
plt_err("Couldn't allocate memory for SA dptr");
plt_free(res);
return -ENOMEM;
}
+
for (i = 0; i < (sa_len / 8); i++)
dptr[i] = plt_cpu_to_be_64(((uint64_t *)sa_dptr)[i]);
@@ -962,6 +964,7 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
plt_delay_ms(1);
plt_free(res);
+ plt_free(dptr);
return 0;
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v2] common/cnxk: fix memory leak
2021-11-10 4:08 [dpdk-dev] [PATCH] common/cnxk: fix memory leak Anoob Joseph
@ 2021-11-10 4:32 ` Anoob Joseph
2021-11-11 15:18 ` [dpdk-dev] [PATCH] " Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: Anoob Joseph @ 2021-11-10 4:32 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Anoob Joseph, dev, schalla
The memory allocated for temporarily keeping DPTR need to be freed after
operation.
Also, dptr need to be aligned to 8B.
Fixes: 71213a8b773c ("common/cnxk: support CPT CTX write through microcode op")
Cc: schalla@marvell.com
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Reviewed-by: Tejasree Kondoj <ktejasree@marvell.com>
---
v2:
- Fixed commit hash in "Fixes" line
drivers/common/cnxk/roc_cpt.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c
index 5c8c328..51cd612 100644
--- a/drivers/common/cnxk/roc_cpt.c
+++ b/drivers/common/cnxk/roc_cpt.c
@@ -930,12 +930,14 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
plt_err("Couldn't allocate memory for result address");
return -ENOMEM;
}
- dptr = plt_zmalloc(sa_len, 0);
- if (!dptr) {
+
+ dptr = plt_zmalloc(sa_len, 8);
+ if (dptr == NULL) {
plt_err("Couldn't allocate memory for SA dptr");
plt_free(res);
return -ENOMEM;
}
+
for (i = 0; i < (sa_len / 8); i++)
dptr[i] = plt_cpu_to_be_64(((uint64_t *)sa_dptr)[i]);
@@ -962,6 +964,7 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
plt_delay_ms(1);
plt_free(res);
+ plt_free(dptr);
return 0;
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] common/cnxk: fix memory leak
2021-11-10 4:08 [dpdk-dev] [PATCH] common/cnxk: fix memory leak Anoob Joseph
2021-11-10 4:32 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
@ 2021-11-11 15:18 ` Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2021-11-11 15:18 UTC (permalink / raw)
To: Anoob Joseph, Ferruh Yigit; +Cc: Jerin Jacob, dpdk-dev, Srujana Challa
On Wed, Nov 10, 2021 at 9:39 AM Anoob Joseph <anoobj@marvell.com> wrote:
>
> The memory allocated for temporarily keeping DPTR need to be freed after
> operation.
>
> Also, dptr need to be aligned to 8B.
>
> Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through microcode op")
> Cc: schalla@marvell.com
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Reviewed-by: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
> Reviewed-by: Tejasree Kondoj <ktejasree@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/roc_cpt.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c
> index 5c8c328..51cd612 100644
> --- a/drivers/common/cnxk/roc_cpt.c
> +++ b/drivers/common/cnxk/roc_cpt.c
> @@ -930,12 +930,14 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
> plt_err("Couldn't allocate memory for result address");
> return -ENOMEM;
> }
> - dptr = plt_zmalloc(sa_len, 0);
> - if (!dptr) {
> +
> + dptr = plt_zmalloc(sa_len, 8);
> + if (dptr == NULL) {
> plt_err("Couldn't allocate memory for SA dptr");
> plt_free(res);
> return -ENOMEM;
> }
> +
> for (i = 0; i < (sa_len / 8); i++)
> dptr[i] = plt_cpu_to_be_64(((uint64_t *)sa_dptr)[i]);
>
> @@ -962,6 +964,7 @@ roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
> plt_delay_ms(1);
>
> plt_free(res);
> + plt_free(dptr);
>
> return 0;
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-11 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 4:08 [dpdk-dev] [PATCH] common/cnxk: fix memory leak Anoob Joseph
2021-11-10 4:32 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2021-11-11 15:18 ` [dpdk-dev] [PATCH] " Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).