From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54F9B433A2; Thu, 23 Nov 2023 05:08:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0069F402BD; Thu, 23 Nov 2023 05:08:26 +0100 (CET) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mails.dpdk.org (Postfix) with ESMTP id 6717D40041 for ; Thu, 23 Nov 2023 05:08:25 +0100 (CET) Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4237346c6efso2466921cf.0 for ; Wed, 22 Nov 2023 20:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700712505; x=1701317305; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fUTrVLYOCTVpvE5v2k9zuQyZgE7wFNqnomYzUaXz24Q=; b=YkLvgXaKle73VO1bpMm++eFotKOiU9zsEmepqg/aC7lipmtjbQC/Wg5vrPWPjJ2h7a 10S1UfSYWBnjH4NJcIC9rH/NC1+Pn68cGB8XKM+TaTalcDzhqy/DyicFHuj/6ttAlx/f h6KFtRS6TyoGgefIeOQKFsxrIkUzt+oWAwd3QgygWr211UZt4SZufxtc3D6Bo1cKZC6M A5OTzpb1uU6p+8Z2UMH5cyncTT34RCnvo853Sw1lyt0UqFHhS//iR2JZBpKc10pyO3kn VsPi+Y6yMFb+e291A7NutuuPTqCJ3KYc8riYN5p60l//JPHImznIUirsih6712G/xZG1 Pzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700712505; x=1701317305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUTrVLYOCTVpvE5v2k9zuQyZgE7wFNqnomYzUaXz24Q=; b=Epr+0GaUYQLkksyPAnZHu18ngJM2H24nNgBmtIvotMdt27ggHpFz1SCkzQRDrUTL2f hzaWgYLo/AQN4fG+GCiykUc1zH2GbKQR09CewNiTERa7Ec5YMeb57wvcTPKhz4rrdhQM 1tKw906RPwfaog17oTwFr/X2SSfHvUjHiEgMPeQdsbzxGqlLqW1iw1mhozfO0+eA+JrT X1Ef2mSUtaCsMoasWQJcbE9a+q4EfnD5BAHHxfw9GF0lKem3EvgzkUMKQ7+euX7EhD0h fsNUs56pbrVRLQEU98BoLznoYsj5jCsJKaFd+Kh9c01n3weHUCwXKsgi1wmnUJ56q3mu b4ww== X-Gm-Message-State: AOJu0Ywn2x/J7gLpO1QxRmYWCbdcdo7ASomze4y30oiSpN4TNI47kQrl Ry1gxNJ089DUjJXH4UzpU+p0Zzu/PmeCLLTP6gA= X-Google-Smtp-Source: AGHT+IHfB2VIQn96zVf+IxCd7fobw15002KC7UyZGhUI0Lpy95HoJDJloQmG/54+vRSGhJlbGtGI+omYbKnPvi7Ni1k= X-Received: by 2002:ac8:4458:0:b0:423:8cb4:70c with SMTP id m24-20020ac84458000000b004238cb4070cmr304105qtn.25.1700712504716; Wed, 22 Nov 2023 20:08:24 -0800 (PST) MIME-Version: 1.0 References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231121115437.96500-1-bruce.richardson@intel.com> <20231121115437.96500-3-bruce.richardson@intel.com> In-Reply-To: <20231121115437.96500-3-bruce.richardson@intel.com> From: Jerin Jacob Date: Thu, 23 Nov 2023 09:37:58 +0530 Message-ID: Subject: Re: [PATCH 24.03 v2 2/9] eventdev: increase flexibility of all-types flag To: Bruce Richardson Cc: dev@dpdk.org, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 5:25=E2=80=AFPM Bruce Richardson wrote: > > Rather than requiring that any device advertising the > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered > and parallel scheduling, we can redefine the field so that it basically > means that you don't need to specify the queue scheduling type at config > time. Instead all types of supported events can be sent to all queues. > > Suggested-by: Mattias R=C3=B6nnblom > Signed-off-by: Bruce Richardson > --- > lib/eventdev/rte_eventdev.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index d48957362c..1c5043de26 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -250,11 +250,20 @@ struct rte_event; > * @see rte_event_dequeue_burst() > */ > #define RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES (1ULL << 3) > -/**< Event device is capable of enqueuing events of any type to any queu= e. > +/**< Event device is capable of accepting enqueued events, of any type > + * advertised as supported by the device, to all destination queues. > + * > + * When this capability is set, the "schedule_type" field of the > + * rte_event_queue_conf structure is ignored when a queue is being confi= gured. can we also add something like below or so to above line rte_event_queue_conf structure is ignored when a queue is being configured instead rte_event::sched_type shall be used. Also, git commit subject "eventdev: increase flexibility of all-types flag", This patch is just documentation clarification. Right? It was like this from day 1. I would suggest the subject as "eventdev: clarify all-types flag documentation" or so. With above changes, Acked-by: Jerin Jacob