From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69880A0C41; Mon, 2 Aug 2021 15:05:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31F4941147; Mon, 2 Aug 2021 15:05:38 +0200 (CEST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id 1152440140 for ; Mon, 2 Aug 2021 15:05:36 +0200 (CEST) Received: by mail-io1-f53.google.com with SMTP id r18so20208093iot.4 for ; Mon, 02 Aug 2021 06:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P3Tky9J+jhYRi6FVC2O02g8iifaq1DKIf67oMbmlSIU=; b=Z/Ju9Jj6csiUCqw73U1WsK2ZloE6QG54RH3QGfIanJA6D4z1CFPpZVG15FuP7+fS/T Hs5ha/rJEcDAqyePuYRZGE49qRQL2RHJpFI45zNVdqkdmC6RwLPROHuCshT9ezsHVAn3 BHvd1MTaNfQNLf/Siau4p4JG2vF1bfGXz+F2pD1fRKIMfO/Zl70uypgfjefLaW53g9jk flX05BjeQNyTgItGm0Vy8V3z99079jcj3OYP2KI5rp1acymLFlinHO6JKMYHfWxJCB7R YSiCrp20n9xb2sFnpDWmrphHmr0EZLZ+Ys7RTtwxM7G0j0Gg1HHzQg4sYpEHU1+6lmKu 1mZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P3Tky9J+jhYRi6FVC2O02g8iifaq1DKIf67oMbmlSIU=; b=odcVB440X1s3Kb3rQXtxtXu/ohRbu0Sek9+xEXl+EN1vgPjV+okyePuscFUXVoA8OO cgVJzA8c4cWJWCUmGYvAkzhJYilrv4hyExVNKejdZg4S+3ecGCqmy+d8UnIZpJMtWsMT vCvOw9MoFEg0plufN6BdMsr/oh3oB/TW3toS/yHTbw1XvNhNjJTYQkzD1OfDXncWvRLy U41nxdrzwaMNtA7p+BzOnpqeXUyHDOaLJtz+WspP5RRhfjydZBhuQTLgXkCe1XTrOkoI JSiuE6oBuSomXsg+Idol8srHCdS2Qs/LiSed57Me7WTPnYQGJsdysnYFRZmD2kpAA5QU bcpQ== X-Gm-Message-State: AOAM53202eZspJqlXivAZzXdFtoVtGmzznMRfacOnhMjwIKK6sRFbVpz x6ynsV1i6nYsuPqfIu2Tm45T3K7aIIomxPK60IwUYWdu1Ig= X-Google-Smtp-Source: ABdhPJwa4hUG/vCAx+G1Uztpw9choThOXWZm9i2ZvoNXx7UPZpHMLKIyz/cf2ntJlv4HzMZ+8GjfoR20f0fsm23neVY= X-Received: by 2002:a05:6638:1915:: with SMTP id p21mr14845238jal.104.1627909535142; Mon, 02 Aug 2021 06:05:35 -0700 (PDT) MIME-Version: 1.0 References: <20210730155700.32574-1-olivier.matz@6wind.com> In-Reply-To: From: Jerin Jacob Date: Mon, 2 Aug 2021 18:35:09 +0530 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , dpdk-dev , Ray Kinsella Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Jul 31, 2021 at 5:45 PM Andrew Rybchenko wrote: > > On 7/30/21 6:57 PM, Olivier Matz wrote: > > The mbuf offload flags do not match the DPDK namespace (they are > > not prefixed by RTE_). Announce their rename in 21.11, and the > > removal of the old names in 22.11. > > > > A draft coccinelle script is provided to anticipate what the > > renaming will be. > > > > Signed-off-by: Olivier Matz > > Acked-by: Andrew Rybchenko Acked-by: Jerin Jacob > > [snip] > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 9584d6bfd7..04cb141de7 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -147,3 +147,8 @@ Deprecation Notices > > * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific > > content. On Linux and FreeBSD, supported prior to DPDK 20.11, > > original structure will be kept until DPDK 21.11. > > + > > +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``. > > + A compatibility layer will be kept until DPDK 22.11, except for the flags > > + that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will > > + be removed. > > > > I think it is better to be explicit with defines to be removed: > PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT, > PKT_RX_EIP_CKSUM_BAD.