From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3782842499; Fri, 27 Jan 2023 07:40:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E056D40150; Fri, 27 Jan 2023 07:40:52 +0100 (CET) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mails.dpdk.org (Postfix) with ESMTP id 6716B40146 for ; Fri, 27 Jan 2023 07:40:51 +0100 (CET) Received: by mail-vs1-f46.google.com with SMTP id i185so4346179vsc.6 for ; Thu, 26 Jan 2023 22:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aqGxIy02M+HdrGO/x6rdDzr15Lag5YRsQ+i1CSFDMVI=; b=J82srdBrFmP2FlrqXbJ3LSQBWJDwIYfiKJkTwiAteWYaqEOElHcqctqVH2PXzphU3s HMCX5BF+DlVdeaHvXQ6Y3MoVRaaLZbWI2H4YiFiU/Mz+zuRnCdY5fJ/5LioLAsQ2O94V RI/EBpAAWeORFfrruwfrv6csyOsHGR0vduj9Yd3tmqCLTwVK04rsNJObrAyns4TP0ec6 clmfPgmTUtV/ho+sxUAc6naNFT4tLsctNx8J6KGUHb9vGJ4LGjhGwpdSqmJNoWBSIKzN HHNv9sRA/RZO/6gepORAS9RYf+RMAH/ivGTZ0Qq8b2YR0cuXNahtA6XBBjZx81+94iE9 GIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aqGxIy02M+HdrGO/x6rdDzr15Lag5YRsQ+i1CSFDMVI=; b=m+8wEpwfWU1L+QtZ47fnmtCsYmMhPkDkITz+y7TmWzYRXUxw4f8i/NA0JDRkbhUp0e wEqex14ToRE6AyKL46unuigGYmCfjSXtAV1BXFowrfMvoDtitwnwxAsLnueBPdU/HbgU c+LV8/gV59PHLbACbU8V2COS4TJ91ZgOZ1ClE/Vjo2StpWKYZ7Ac6QAOSlKFhGstQTgx G0zpi3s1DALDCOhK7ZtaSSntsBxJ9jAF/4giopFCNaT+e5KJooX0+rR0Kr+G1FP8YKlG 8y7PhHFNZS2102MXYWoTvLOkeN24h+oHcCE3nE1ZJh4ajr6LqaYWwoLImm1cbQ//DRHw i6JA== X-Gm-Message-State: AFqh2krHYc1yAMMooNFQ5V6OgSf6YJhq0d5F2QBDKzZttqfiwh/OszK4 EuLe9psB1CTcvZv7jEEcipznW5yyoqF/lI5kAgA= X-Google-Smtp-Source: AMrXdXswvYu0ScfQleIf8BaWZdQwM+kA1z6a7ij3yz41ilEVL3BM/HQf7jVvmdrYVDbsuDNYMzezplvXyhpcjrCX9rU= X-Received: by 2002:a05:6102:1173:b0:3d0:bfd2:3a12 with SMTP id k19-20020a056102117300b003d0bfd23a12mr5294589vsg.52.1674801650667; Thu, 26 Jan 2023 22:40:50 -0800 (PST) MIME-Version: 1.0 References: <20221212172108.17993-1-syalavarthi@marvell.com> <4307135.zXnORWrf4K@thomas> <2095842.dTVjPilprF@thomas> In-Reply-To: <2095842.dTVjPilprF@thomas> From: Jerin Jacob Date: Fri, 27 Jan 2023 12:10:24 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code To: Thomas Monjalon Cc: Shivah Shankar Shankar Narayan Rao , Srikanth Yalavarthi , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Anup Prabhu , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > 25/01/2023 15:59, Srikanth Yalavarthi: > > From: Thomas Monjalon > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > From: Thomas Monjalon > > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > > > > This patch series implements the common ML code that can be used > > > > > > by ML drivers. Common code include functions to convert ML IO type > > > > > > to string, IO format type to string, function get size of ML IO > > > > > > type, and functions for converting data types from higher > > > > > > precision to lower precision and vice-versa. > > > > > > > > > > I'm not sure about the path of this code. > > > > > In general we implement drivers helper in the same directory as the > > > > > driver and mark it as internal. > > > > > Would it work here? > > > > > > > > We are planning to implement two different ML drivers, ml/cnxk driver > > > (submitted for review) and a software only driver (part of ML roadmap and > > > currently WIP). Both the drivers would be using these common functions for > > > quantization and dequantization. Hence, placed the files in common/ml > > > directory. > > > > > > > > Moreover, these functions are used to convert data from higher to lower > > > precision or vice-versa and can also be used by future ML drivers for other > > > platforms. > > > > > > I understand, and what you say does not contradict with having this code in > > > lib/mldev/. > > > So would you agree to move? > > > > These common functions do not have an rte_ml_dev_ prefix. > > As it is exported, it should have rte_ prefix. The exposed functions are similar to lib/ethdev/sff_* where multiple driver can "use" it but not by application directly. If so, What is the recommendation a) Keeping driver/common/ml without rte_prefix b) Keeping in lib/mldev/ with rte_mldev_pmd_ prefix? I prefer (a) as it will not pollute lib/mldev. No strong opinion, either. Let me know your view or any other suggestion? > > > Is it ok to have non-RTE code in lib/mldev. If yes, we can move to lib/mldev. > > Look at lib/ethdev/ethdev_driver.h, it should be similar. Here scope is different. See above. > >