From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B934AA0C40; Fri, 30 Jul 2021 13:00:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A50BB40042; Fri, 30 Jul 2021 13:00:00 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 26D184003F for ; Fri, 30 Jul 2021 12:59:59 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id f6so5097016ioc.6 for ; Fri, 30 Jul 2021 03:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9u6Z3zJ2APbGzXcmHZ0njygw5uDo3MJMU0UGBdAyEeA=; b=laS/pXWgeZWbZo70Mo3uJSVmS/ly1GM7HKjl4DsfaxIM9cTKd8YUWjHy0T6iyrKG+k oByHjDZuVXX+K6bIgLZnXKKSI6fKwdbVlC5YKBRwBn9aa6Y3ZNv1lt01n/rNbRYn7gVF gWe2U0/QVdvW+Z/UbdcgMyAYmQv/FTJFUUX1pqOyYJyKqC2Nt5nCHoHWTpITnrBufxmE 2mA+39GgxLGqzxiYcBmWz88LEmWAENMusKFKUs+CYpYhWMJGurIjln7Vb1sToAvmtpao Pk7FNlGjSu03QoO42Xc2hdY7TzuyePLcVrBOHGKiMYD5BaY0O4P1OdwVmVqUOauDZQ8Y 8h9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9u6Z3zJ2APbGzXcmHZ0njygw5uDo3MJMU0UGBdAyEeA=; b=C/siVBFrHcTwdGKDCV2lvyBkWrwiXn8OcCJ648LG0uSdyeFw4rS/yZJF/WpCxy/BoX 4rQggM8jioMafJ0/Spb7gQA8sjWlwl/B4Nc3s9TVAINmWhdWiV6v6iUVdQz66iYl5P98 u/rlwLjxl/iLLe1/j2jiBzVfe2KvgbeEIA0BNmdaluu1fEycFixyTpIz/Rwa2LtFMvpr aeSod8/tZcCAo1koBYjOOE9JcVlSIhDe1XR2syM8ITYdGheu+oc5lNjhH0A1t/POdsxU yRSp3lEdGuJX9jz0AIgkCO41DHvDy1fLORoe2K/USLRJ0wNvDfZhmlecbBgksrv5GCXP mR9g== X-Gm-Message-State: AOAM533cQezjWGnnGaeiMNWBXc6FHqYcjnDXwz2JqiSI6cHgze83JUsl UQiRSt4nSqgL+N3q/4eBiafpzsNeM2TcULRbvvY= X-Google-Smtp-Source: ABdhPJz2xg0VmS1yo6A6n9s6uRhSGNqZAs1GYsCZsAs9rpcSQdrqLBjVqG2Qb1E56BPzKq8yuPzX/KVWZWoTRr9HqUA= X-Received: by 2002:a6b:b5ce:: with SMTP id e197mr1976000iof.123.1627642798492; Fri, 30 Jul 2021 03:59:58 -0700 (PDT) MIME-Version: 1.0 References: <20210723081222.4176279-1-s.v.naga.harish.k@intel.com> <20210724141036.915356-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 30 Jul 2021 16:29:32 +0530 Message-ID: To: "Jayatheerthan, Jay" Cc: "Naga Harish K, S V" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay wrote: > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, July 28, 2021 3:01 PM > > To: Jayatheerthan, Jay > > Cc: Naga Harish K, S V ; dev@dpdk.org > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter > > > > On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay > > wrote: > > > > > > > -----Original Message----- > > > > From: Naga Harish K, S V > > > > Sent: Saturday, July 24, 2021 7:41 PM > > > > To: Jayatheerthan, Jay ; jerinjacobk@gmail.com > > > > Cc: dev@dpdk.org > > > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter > > > > > > > > The event port config set by application in > > > > rte_event_eth_tx_adapter_create API is modified in > > > > default configuration callback function. This patch removes > > > > this hardcode to use application provided event port > > > > config value. > > > > > > > > Fixes: ("eventdev: fix event port config override in tx adapter") > > > > > > @Jerin, does this look good to you ? > > > > Yes. I will merge this. See below. Applied to dpdk-next-net-eventdev/for-main. Thanks > > Thanks! > > > > > > > > > > > > > > Signed-off-by: Naga Harish K, S V > > > > > > @Naga Harish K, S V Can we remove "," from the Signoff name. > > > > Some suggestions for consideration in preferred order. Let me know > > your preferred Signoff name, I will change it accordingly. > > > > Naga Harish > > > > or > > > > Naga Harish K > > > > or > > > > Naga Harish K S V > > This option is good. (Harish is out and hence I am responding) > > > > > > > --- > > > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > index db260bfb68..18c0359db7 100644 > > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, > > > > return ret; > > > > } > > > > > > > > - pc->event_port_cfg = 0; > > > > ret = rte_event_port_setup(dev_id, port_id, pc); > > > > if (ret) { > > > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > > > > -- > > > > 2.25.1