From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3038AA00BE; Mon, 27 Apr 2020 20:02:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 782451D44A; Mon, 27 Apr 2020 20:02:56 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 712641D424 for ; Mon, 27 Apr 2020 20:02:55 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id c18so2335970ile.5 for ; Mon, 27 Apr 2020 11:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rrTPowr6mKuCYJSNua1YY44QxCXRo7K0madT/Sb4SKk=; b=nOc7uojapWZw3xdCASzlxYajx9rhd9EaJSyYz2XmDR4NXByDgQEKBA5BVvqHdXzAV6 nLPjUn8N6f75lV8+OZ2f7M07P48TKqh33Sqabztnt7+d7aV5aAkFd4VH46drSumM3Wfe RkPkS9f/WToJRdV9OnYElf26Lvpq1F+34OmiGgl+aeC5ucf9iHGaprWpYS+Qhw13DcbD 2z8GVSEHffFDt3sh3LIcMwPH+PnYqT0Wy7pXVuIANdFaqweXZK5jE5NUZmpmDoFWk/7i bqgUkO78oA1f6MN7RfrYZylBh2ziWc9FxsSww3Z1oo5JFlwL4bmQIwA2nTf4Rji9TN25 KoHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rrTPowr6mKuCYJSNua1YY44QxCXRo7K0madT/Sb4SKk=; b=WYQvS/6D+7v5Rfol5sjjeUTnzmz8MUpGMCgCWaYxuz1zRDDU1tnnKBLGQGq5/KupJ6 k1cC9fUoPDPHfTKJhtYugwdySo16tHTYMutthvOOnnQKudrMj7s/g2K9rvtPTuWuRcfz kWRj9WUXzSYb6ISS1cNRm1tjVZ+tYWYFnMbPiPdzHK1hKvfsXYNmV3iHeINBp5MS6Hj/ r6XEW/g31Vs2fT9bM7ygIiT5lISAfjhbPD86yL70jx0ZI7DtMQGQ9eSZmZO4bpW0wSRb mmJZUALQnzRfZwk7qO9TvsMbD2D5V+XKW/klSwLm5DAZcr1bEMhwqdcyKDuMJ+6PmSKj T7BQ== X-Gm-Message-State: AGi0PuaD5QNSHGzcHs43uX51rmVw9JxhQ6UJMANyrvj++W7WDUyBy04d Goa0WvMGcrVCtJ5jTjsvrQoQOAlATHrxlPK5gd0= X-Google-Smtp-Source: APiQypJ/tbg+4fTtjH4qvmvik/iRI0MEGlLlBbQAtfhIGhQf4vus4C2tMzya8EpWI2Fq7vKQfNkMJf4b8tvK9yUW0Qs= X-Received: by 2002:a92:8b45:: with SMTP id i66mr9793216ild.162.1588010574623; Mon, 27 Apr 2020 11:02:54 -0700 (PDT) MIME-Version: 1.0 References: <20200121080021.2835490-1-jerinj@marvell.com> <4168892.bm5RmrZB5H@thomas> <2638871.7x91mkYCy2@thomas> In-Reply-To: <2638871.7x91mkYCy2@thomas> From: Jerin Jacob Date: Mon, 27 Apr 2020 23:32:38 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , dpdk-dev , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 1:26 AM Thomas Monjalon wrote: > > 26/04/2020 20:48, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon wrote: > > > 26/04/2020 19:42, Jerin Jacob: > > > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon wrote: > > > > > 06/02/2020 15:36, Jerin Jacob: > > > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon wrote: > > > > > > > 21/01/2020 09:00, jerinj@marvell.com: > > > > > > > > From: Jerin Jacob > > > > > > > > > > > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe > > > > > > > > creates a lot of clutter on boot-up, typically one needs > > > > > > > > to scroll the screen to find other issues in boot-up. > > > > > > > > > > > > > > > > This patch changes the loglevel of PCI probes to `debug` > > > > > > > > to reduce the clutter on default boot-up logs > > > > > > > > > > > > > > I think the PCI probe informations are... informational. > > > > > > > Maybe you are just not interested in info logs. > > > > > > > If this is the case, I suggest to change the log level at runtime. > > > > > > > > > > > > I am wondering, what would be the right balance, Following is DPDK > > > > > > startup output from octeontx2[1] > > > > > > It creates a lot of clutter in the "default" boot up. Why not enable > > > > > > below prints using log level at runtime? > > > > > > I believe it comes as a debug category, i.e information required to > > > > > > debug if something is not working, > > > > > > dpdk bind script already lists what is bound to DPDK. > > > > > > > > > > > > Suggestion to remove clutter? > > > > > > > > > > I suggest using dynamic log level in the PCI driver. > > > > > Unfortunately a lot of old DPDK code is still using the old log macros. > > > > > Some cleanup work is needed here. > > > > > > > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE. > > > > > > No, a PCI PMD can work without a known kernel driver. > > > This is the case of mlx4/mlx5. > > > > Yes. it can work with UNKNOWN, But It not with NONE. > > > > > > I think that is the source of the problem. > > > > http://patches.dpdk.org/patch/69351/ > > > > > > The source of the problem is just changing log levels dynamically > > > is not possible currently with PCI driver logs. > > > > Assuming if we add, dynamic stuff what would the default log level for > > RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n", > > > > If it is INFO, Still the problem persist in the default bootup. Right? > > Yes > > We need to know in INFO level which devices are successfully probed. > You want to decrease to DEBUG the level of logs announcing a probe. > I think it would be OK if adding an INFO log after probe success. OK. I will send the v2 by changing the existing one as DEBUG and a successful probe as INFO. > > >