From: Jerin Jacob <jerinjacobk@gmail.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
dpdk-dev <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"techboard@dpdk.org" <techboard@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
Date: Fri, 17 Jan 2020 09:37:43 +0530 [thread overview]
Message-ID: <CALBAE1PhD95evCN_AYBoMi=YfiKx+t2Fk+6b51ciUgH1Bc5sCw@mail.gmail.com> (raw)
In-Reply-To: <VE1PR08MB5149D215BD19BB11A36810A298360@VE1PR08MB5149.eurprd08.prod.outlook.com>
On Fri, Jan 17, 2020 at 4:08 AM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> <snip>
>
> > >
> > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > Ping.
> > > >
> > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > >>
> > > >> From: Jerin Jacob <jerinj@marvell.com>
> > > >>
> > > >> Based on the techboard meeting held on 2019-11-06, It's been
> > > >> decided to disable all kmods by default from v20.02.
> > > >>
> > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > > >>
> > > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > >> ---
> > > >> config/common_linux | 2 --
> > > >> 1 file changed, 2 deletions(-)
> > > >>
> > > >> diff --git a/config/common_linux b/config/common_linux index
> > > >> c5cf3d662..583efadc7 100644
> > > >> --- a/config/common_linux
> > > >> +++ b/config/common_linux
> > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > >>
> > > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > >> CONFIG_RTE_EAL_VFIO=y
> > > >> -CONFIG_RTE_KNI_KMOD=y
> Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
In config/common_base it is set as =n. it can be enabled there just
like other config.
I just did this way to have symmetry with other configs.
Thoughts?
> Does this require update to release notes?
I will send the next version with updating the release notes if there
is no objection.
>
> > > >> CONFIG_RTE_LIBRTE_KNI=y
> > > >> CONFIG_RTE_LIBRTE_PMD_KNI=y
> > > >> CONFIG_RTE_LIBRTE_VHOST=y
> > > >> --
> > > >> 2.24.0
> > > >>
> > > >
> > >
> > > Looks good for make build system, but what about Meson?
> > > as per meson_options.txt, isn't it enabled by default?
> > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > > type: 'boolean', value: true,
> >
> > + Bruce,
> >
> > Since meson autodetect the presence of Linux kernel dependency for the kmod
> > build, I thought of keeping as it is as there is no harm. I am fine with either way,
> > let me the know the feedback, I will send the v2 based on the comment.
> >
> >
> >
> > >
> > > Thanks,
> > > Maxime
> > >
next prev parent reply other threads:[~2020-01-17 4:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 13:13 [dpdk-dev] " jerinj
2020-01-16 13:11 ` Jerin Jacob
2020-01-16 18:33 ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-01-16 18:43 ` Jerin Jacob
2020-01-16 22:38 ` Honnappa Nagarahalli
2020-01-17 4:07 ` Jerin Jacob [this message]
2020-01-17 15:48 ` Honnappa Nagarahalli
2020-01-18 0:06 ` Thomas Monjalon
2020-01-17 8:29 ` Maxime Coquelin
2020-01-17 9:19 ` Kevin Traynor
2020-01-17 9:55 ` Jerin Jacob
2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-20 17:42 ` Thomas Monjalon
2020-02-12 17:18 ` Lipiec, Herakliusz
2020-02-12 17:39 ` Thomas Monjalon
2020-01-22 6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2020-01-22 9:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PhD95evCN_AYBoMi=YfiKx+t2Fk+6b51ciUgH1Bc5sCw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=nd@arm.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).