From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68034A051A; Fri, 17 Jan 2020 05:08:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF3071D548; Fri, 17 Jan 2020 05:08:00 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 185AC1D51D; Fri, 17 Jan 2020 05:08:00 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id z193so24521189iof.1; Thu, 16 Jan 2020 20:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZUuJhm0Hm+Pyiz1eIm/slln72KfVPtAYhx0XnibB27M=; b=UPEkMCzbTv7yXu9ifD641yqKcyPzRM20hrKeKAegS64fuTIKVM3QgRKY1j31zGJ0CA FkvtQHrm4DRoLyo87SEJIRr1Q7Yxyk4su9Tt2SDaGrLHnpDoThJUBKCTgfayww2pUzbG KqzXR9l2/fbZmLL8LkBg9ykh9LXtvYYXt8bXgPWFoWtbmRhpm4ik64jYpNPyjF9bv56V NskLo7KuvzF5Mtg1nmZXLWi5ibkkLzO7QnXiNHEr1E3Dgzc3WscoFSuD/2ox7W9dHpjf ElOOovEAuCRiGkQE3DzSbDMnK/2wLznF+xlfCavEMDabJGJwEMdIezVCPI3aNk8Yfi1t 1taQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZUuJhm0Hm+Pyiz1eIm/slln72KfVPtAYhx0XnibB27M=; b=hpNl1CTMDZo4W8cGoJTvGSVr02N8zTS/eUS9xLQluA6oWNsLduX6gZsiDzY2b0Ypqx HlhufIlFUTVRw39hOg4gGFGQbxzp09YzOShicmdavlElO8esL+TveINb/71tXMeTt0Ea HqMjLT2LkLt5HA8qiHGl/UUzIYcjfzLjqG/dHXgdPZGGDoMtsEhb25vubszd1MzQ1h7V JUV2YUM7fP0Gt7FzyXc2eQ+x894seeYkmqA8hNuZkypEJnsUyH8MXTYvCcIOx6qW6mE2 LlSsuAujGvUyU6GxizBkDClSNjgKFlS34FrdfyMplrljKG7qbnX9SGy246lESYvglvD/ WRbw== X-Gm-Message-State: APjAAAU9FYyq2oYs776sPTdZ0Ptf3O4EQ3Tjxxpl8+0Qaw3IGqlmHGbU C9NVaG9vzPlMMbOOyEu981s7Egpl4mZpgIy/IKU= X-Google-Smtp-Source: APXvYqyEOnfnIS7HPbafCLFXoFRO2iublzk/Mm+Hj6OXQlaDFV/gTCkNu1+I0xGuUdu9eiG2aRwPT/e2ZpGnvAVtYrs= X-Received: by 2002:a5e:8e4d:: with SMTP id r13mr27498075ioo.60.1579234079264; Thu, 16 Jan 2020 20:07:59 -0800 (PST) MIME-Version: 1.0 References: <20191212131302.1626130-1-jerinj@marvell.com> <898e1731-4921-721b-0e42-ada50ab2bf94@redhat.com> In-Reply-To: From: Jerin Jacob Date: Fri, 17 Jan 2020 09:37:43 +0530 Message-ID: To: Honnappa Nagarahalli Cc: Maxime Coquelin , "jerinj@marvell.com" , dpdk-dev , "thomas@monjalon.net" , "techboard@dpdk.org" , "Richardson, Bruce" , nd Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 17, 2020 at 4:08 AM Honnappa Nagarahalli wrote: > > > > > > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > > > Ping. > > > > > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > > > >> > > > >> From: Jerin Jacob > > > >> > > > >> Based on the techboard meeting held on 2019-11-06, It's been > > > >> decided to disable all kmods by default from v20.02. > > > >> > > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html > > > >> > > > >> Signed-off-by: Jerin Jacob > > > >> --- > > > >> config/common_linux | 2 -- > > > >> 1 file changed, 2 deletions(-) > > > >> > > > >> diff --git a/config/common_linux b/config/common_linux index > > > >> c5cf3d662..583efadc7 100644 > > > >> --- a/config/common_linux > > > >> +++ b/config/common_linux > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > > > >> > > > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > > > >> -CONFIG_RTE_EAL_IGB_UIO=y > > > >> CONFIG_RTE_EAL_VFIO=y > > > >> -CONFIG_RTE_KNI_KMOD=y > Suggest to keep the lines, but set them to 'n'. It will be easier to enable. In config/common_base it is set as =n. it can be enabled there just like other config. I just did this way to have symmetry with other configs. Thoughts? > Does this require update to release notes? I will send the next version with updating the release notes if there is no objection. > > > > >> CONFIG_RTE_LIBRTE_KNI=y > > > >> CONFIG_RTE_LIBRTE_PMD_KNI=y > > > >> CONFIG_RTE_LIBRTE_VHOST=y > > > >> -- > > > >> 2.24.0 > > > >> > > > > > > > > > > Looks good for make build system, but what about Meson? > > > as per meson_options.txt, isn't it enabled by default? > > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods', > > > type: 'boolean', value: true, > > > > + Bruce, > > > > Since meson autodetect the presence of Linux kernel dependency for the kmod > > build, I thought of keeping as it is as there is no harm. I am fine with either way, > > let me the know the feedback, I will send the v2 based on the comment. > > > > > > > > > > > > Thanks, > > > Maxime > > >