From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: Venky Venkatesh <vvenkatesh@paloaltonetworks.com>,
Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events
Date: Tue, 14 Apr 2020 19:02:59 +0530 [thread overview]
Message-ID: <CALBAE1PhV6Nf8BD5WKhwYhFaj-BkZ8C43HQVZekgsjruT0yOig@mail.gmail.com> (raw)
In-Reply-To: <a348e15b-6061-26c1-660a-9bdd9e8110e8@ericsson.com>
On Tue, Apr 14, 2020 at 6:41 PM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> On 2020-04-14 14:45, Jerin Jacob wrote:
> > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh
> >> <vvenkatesh@paloaltonetworks.com> wrote:
> >>> Hi Mattias,
> >>> Have a question on this fix. I understand you wanting a certain number of
> >>> events before making a decision to migrate (in the above fix).
> >>> However, suppose there are fewer events over a few flows (even if not many)
> >>> and yet your core is heavily loaded -- indicating may be they are one or
> >>> more very CPU intensive flows. Often in DPI situations depending on the
> >>> complexity of the policy you can get delayed longer. It might still be
> >>> worthwhile to migrate if the other cores are really lightly loaded. I think
> >>> that case will be missed out in this approach.
> >>>
> >>> Fundamentally, the number of packets being a proxy-metric for the load of
> >>> that flow on the cpu is simplistic at times. Very CPU intensive
> >>> medium/lower bandwidth flows can be picked up in this heuristic. If there
> >>> is a way that at the time of DSW init we can have a way of tuning it
> >>> depending on the application scenario it might be more flexible.
> >> Hi Venky and Mattias,
> >>
> >> Is this patch to good to merge?
> > Please mark the patch as "Not applicable" if the patch is not required.
> >
>
> This patch should be merged. Thanks.
Sure. I will wait for couple of days on any comments on this patch. If
none, I will merge this.
>
>
> >>> Thanks
> >>> -Venky
> >>>
> >>>
> >>> On Thu, Mar 5, 2020 at 2:47 AM Mattias Rönnblom <
> >>> mattias.ronnblom@ericsson.com> wrote:
> >>>
> >>>> Avoid reusing recorded events when performing a migration, since this
> >>>> may make the migration selection logic pick an already-moved flow.
> >>>>
> >>>> Fixes: f6257b22e767 ("event/dsw: add load balancing")
> >>>> Cc: stable@dpdk.org
> >>>>
> >>>> Reported-by: Venky Venkatesh <vvenkatesh@paloaltonetworks.com>
> >>>> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >>>> ---
> >>>> drivers/event/dsw/dsw_event.c | 3 +++
> >>>> 1 file changed, 3 insertions(+)
> >>>>
> >>>> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> >>>> index d68b71b98..296adea18 100644
> >>>> --- a/drivers/event/dsw/dsw_event.c
> >>>> +++ b/drivers/event/dsw/dsw_event.c
> >>>> @@ -646,6 +646,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw,
> >>>> if (dsw->num_ports == 1)
> >>>> return;
> >>>>
> >>>> + if (seen_events_len < DSW_MAX_EVENTS_RECORDED)
> >>>> + return;
> >>>> +
> >>>> DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering
> >>>> migration.\n");
> >>>>
> >>>> /* Randomize interval to avoid having all threads considering
> >>>> --
> >>>> 2.17.1
> >>>>
> >>>>
>
next prev parent reply other threads:[~2020-04-14 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 10:46 Mattias Rönnblom
2020-03-06 6:05 ` Venky Venkatesh
2020-03-06 7:48 ` Mattias Rönnblom
2020-04-04 12:35 ` Jerin Jacob
2020-04-14 12:45 ` Jerin Jacob
2020-04-14 13:11 ` Mattias Rönnblom
2020-04-14 13:32 ` Jerin Jacob [this message]
2020-05-01 8:01 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PhV6Nf8BD5WKhwYhFaj-BkZ8C43HQVZekgsjruT0yOig@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
--cc=vvenkatesh@paloaltonetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).