From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 358DA42333; Mon, 9 Oct 2023 07:05:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B673E402AC; Mon, 9 Oct 2023 07:05:41 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 7DE4B402A3 for ; Mon, 9 Oct 2023 07:05:40 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4180b417309so24044791cf.0 for ; Sun, 08 Oct 2023 22:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696827940; x=1697432740; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rl77lLv03RG+chlNng4B1I7miHrmQo/at2IxYyfgFEI=; b=lUdKxwtf+DqbpJcpH61zMmpGFRqXu6nlpmlyQ7ElT569r2uw2dyruTMeu3+wxiBDOX 5G8yFqJDdacjYDCgm8tntPrzkFZmB23AgIo6ZrM6gFMguuNxMd0zSVMeVV0njJh0vMpr gAoN/H3FQZxonOqaTidStiXTjovyYFpjGU1k+uHIg18kGBE70Vxby54qIG99HF7720Rw 2yexLGMv1S1uCgOsJKeL12EMbAIzrxEamGl8K0u/kWhvFvQMGDcwWVNUJDcX2AkMePmR 2Ms6alMELWEZUrdaL4Tl6jotOC5ffg/LLQrdzxEF8BeAumWCWuKN+Xzd3J8eSOK452UK knkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696827940; x=1697432740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rl77lLv03RG+chlNng4B1I7miHrmQo/at2IxYyfgFEI=; b=U8iOBH++U/HM1eLmGXWAIPu0mfT8ksjX0pDkx4O8JPh29I2Yf6HNahGqWbhQRiy5Pe gJg3s69I4UFOc3s4vYJ/yJ4JXSXaTNmkYG1AdZFVxuWmO7n5YK4M5TpFKVZKlfcsx53k 82vL14IsPQQC2whwhksG63JQNmWhzRsWyIR33mc0NWoabQWO6StrX4qcJ3cCfPUGQrlO 9FcwcddjK7Z1umPXfdNITnkxrgycVofniGilK4sktjAo1ltAJaVQtJkGkYSj3lEHBAxu awezcJzJkqqtYCxJgB+8+jc88c5TretPXmPWf9M5Ver/RVSopv97VzQKVIHzPDc/WwZF EORg== X-Gm-Message-State: AOJu0Yxzcgu1lU8XKP+PZu9BIS1Km25eiOdkbkmgEi/wdFDpoVkx9at/ cBMtMswz8eQkbjgdwIJiJbFtSkhuGPLkvtA+B14= X-Google-Smtp-Source: AGHT+IE7iJUTkmPokrmkZb2AZN9ligpyH8kgy6Hvu1yWy+MtN+DUh2yF8doSa2Evm9pJ6wd+vCx0HQp26f29FXHY308= X-Received: by 2002:ac8:7d0d:0:b0:419:658e:ab1e with SMTP id g13-20020ac87d0d000000b00419658eab1emr15413385qtb.60.1696827939640; Sun, 08 Oct 2023 22:05:39 -0700 (PDT) MIME-Version: 1.0 References: <8866a5c7ea36e476b2a92e3e4cea6c2c127ab82f.1691768110.git.anatoly.burakov@intel.com> <8ce1cf14-17e4-4092-1102-305f8fe25a36@huawei.com> In-Reply-To: <8ce1cf14-17e4-4092-1102-305f8fe25a36@huawei.com> From: Jerin Jacob Date: Mon, 9 Oct 2023 10:35:13 +0530 Message-ID: Subject: Re: [PATCH v1 1/3] dmadev: add inter-domain operations To: fengchengwen Cc: Anatoly Burakov , dev@dpdk.org, Kevin Laatz , Bruce Richardson , Vladimir Medvedkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Oct 8, 2023 at 8:03=E2=80=AFAM fengchengwen wrote: > > Hi Anatoly, > > On 2023/8/12 0:14, Anatoly Burakov wrote: > > Add a flag to indicate that a specific device supports inter-domain > > operations, and add an API for inter-domain copy and fill. > > > > Inter-domain operation is an operation that is very similar to regular > > DMA operation, except either source or destination addresses can be in = a > > different process's address space, indicated by source and destination > > handle values. These values are currently meant to be provided by > > private drivers' API's. > > > > This commit also adds a controller ID field into the DMA device API. > > This is an arbitrary value that may not be implemented by hardware, but > > it is meant to represent some kind of device hierarchy. > > > > Signed-off-by: Vladimir Medvedkin > > Signed-off-by: Anatoly Burakov > > --- > > ... > > > +__rte_experimental > > +static inline int > > +rte_dma_copy_inter_dom(int16_t dev_id, uint16_t vchan, rte_iova_t src, > > + rte_iova_t dst, uint32_t length, uint16_t src_handle, > > + uint16_t dst_handle, uint64_t flags) > > I would suggest add more general extension: > rte_dma_copy*(int16_t dev_id, uint16_t vchan, rte_iova_t src, rte_iova_t = dst, > uint32_t length, uint64_t flags, void *param) > The param only valid under some flags bits. > As for this inter-domain extension: we could define inter-domain param st= ruct. > > > Whether add in current rte_dma_copy() API or add one new API, I think it = mainly > depend on performance impact of parameter transfer. Suggest more discuss = for > differnt platform and call specification. Or move src_handle/dst_hanel to vchan config to enable better performance. Application create N number of vchan based on the requirements. > > > And last, Could you introduce the application scenarios of this feature? Looks like VM to VM or container to container copy. > > > Thanks. >