From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 626D3A0583; Fri, 20 Mar 2020 13:03:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F12DC2BBE; Fri, 20 Mar 2020 13:03:56 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 552182BBD for ; Fri, 20 Mar 2020 13:03:55 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id n21so5618115ioo.10 for ; Fri, 20 Mar 2020 05:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EUw8VR/XCr/yoe2x1nD2RdSCTjLQ4dAMTYdzbPRmyac=; b=KG7aO/mW3Rkh8jgpGydblyai+mNZiOwS++4b60Gmn/+ItGvoqEPASmjkfe2qsEXLR4 xXXxKxZDDQVaUqne4XPFGO2ZsKQ1Yy1YUVHyTmJjP3Ke5Sqr6ogh7mNjuXN9uDer3w3x WFKsIbS6BX9YCdVnlc3uJnQ9b31Gr8tIRh21Uzo4sHfa+IZ0dxYQIfvwHEukMAC3QQnk rYKEVTbuJM4T7qyiEdMZ1hOsqTKT8emgrQMlJbIqeFMKdf8i11uMYXCcdxbPr8KctaGY +XNizJqXxIUVAMkBW2+c+R6VH5D5oLITz+Bs0DG4AGnQ45FRLBa4hsZB7sDBIu8FuPQc mYtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EUw8VR/XCr/yoe2x1nD2RdSCTjLQ4dAMTYdzbPRmyac=; b=f2cwtyzav1RcFM3gocL7f/OHgIBtykXvjSTp3m1/xDprf93AjOzlP9ErMNx1Tovj81 c/2vd6Oyay7vNkBr2QMoGL4c1YMQsTsuP9aOZbQ4ioOb0FhrgRt99mIUNzvL573UtvcS xHdnXZzo8INlrR/tD+jg9fr9/eooxmbMy3wta29UEs5Hfp8yFjvTX0F+mfkrwbO8XMa5 djlpmE4dXHTsV5k5VzyHgrw8fF2nzoHlM1Qikzb9nxR1LwNcUzaAvGqMskO17iUrCshM 9ATTYtqf4mxtc0wrvv6qlP4X5H3nNowmyIDNe5NOKfjzVm45qz8MaRzuT6+OI+y6LtKv PD8w== X-Gm-Message-State: ANhLgQ3Vg/GaqNU46oeY3QVR+RsKkxO9WLUlcjG66B1g6loHGmWaVZzn NKcbruqn9P6/P345CAq4J88Ick0LKC0bSdk996A= X-Google-Smtp-Source: ADFU+vvzFe9no6JM/downvtbXR3AReIO1PXPMLoDzb73RjXqyWfCZJCQMLFIIDm/VyMLrtBKZ5m1XXtc+azxhrJsupM= X-Received: by 2002:a5d:8796:: with SMTP id f22mr6974521ion.163.1584705834567; Fri, 20 Mar 2020 05:03:54 -0700 (PDT) MIME-Version: 1.0 References: <20200319171907.60891-1-ciara.power@intel.com> <20200319171907.60891-12-ciara.power@intel.com> In-Reply-To: <20200319171907.60891-12-ciara.power@intel.com> From: Jerin Jacob Date: Fri, 20 Mar 2020 17:33:38 +0530 Message-ID: To: Ciara Power Cc: "Laatz, Kevin" , dpdk-dev , Reshma Pattan , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 19, 2020 at 11:07 PM Ciara Power wrote: > > This patch moves telemetry further down the build, and adds it as a > dependency for EAL. Telemetry is now configured to build by default, and > has EAL flags, shown below: > "--telemetry" = Enables telemetry (this is default if no flags given) > "--no-telemetry" = Disables telemetry > > When telemetry is enabled, it will attempt to open the new socket > version, and also the legacy support socket (this will depend on Jansson > external dependency, as before). > > Signed-off-by: Ciara Power > Signed-off-by: Bruce Richardson > --- > config/common_base | 2 +- I think, update to doc/guides/linux_gsg/eal_args.include.rst file is missing. > lib/Makefile | 5 ++--- > lib/librte_eal/common/eal_common_options.c | 9 ++++++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 4 ++++ > lib/librte_eal/freebsd/eal/Makefile | 1 + > lib/librte_eal/freebsd/eal/eal.c | 9 ++++++++ > lib/librte_eal/freebsd/eal/meson.build | 2 +- > lib/librte_eal/linux/eal/Makefile | 1 + > lib/librte_eal/linux/eal/eal.c | 9 ++++++++ > lib/librte_eal/linux/eal/meson.build | 2 +- > lib/librte_eal/meson.build | 2 +- > lib/librte_telemetry/Makefile | 1 - > lib/librte_telemetry/meson.build | 1 - > lib/librte_telemetry/rte_telemetry.h | 2 +- > lib/librte_telemetry/telemetry.c | 24 +++++----------------- > lib/meson.build | 2 +- > mk/rte.app.mk | 3 ++-