From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95E6EA0C41; Wed, 17 Nov 2021 10:49:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79D9341147; Wed, 17 Nov 2021 10:49:16 +0100 (CET) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id EA46840040 for ; Wed, 17 Nov 2021 10:49:15 +0100 (CET) Received: by mail-io1-f53.google.com with SMTP id m9so2358129iop.0 for ; Wed, 17 Nov 2021 01:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DZvlB7X1K5ytr/bpMK3Bn7Gjfn9nK+5xj8AoQIBHxpc=; b=fh+uHciQvtnjRiOWOp4+baXzQW/s0P8XdZnl3WgIbJjAbgiA53GzwVudj8+68SPsoc SKM5PdueaXH57fLj6eVzo7BFoS71/CCwf+wTmmZexyJQoIsHJUPX2OqvcsyueMzOoxoO uNShmwTEFPoIMbVezIB7vLavWw+rYIGdPyXViQqta8jWYfbY1VOm7Z80QrPZJvHkfei9 FNumbKlPNN19o/ro+rsGvhnOcNLN8Wxo6uhz0qjarZMiOUr97UynxbyQWE/QuRlD8b7h wfdvXPQ09Jejgucc4apmjv9gdDlQ2fvJI2KI4FCBYuL0NPvLEKr6GU0eFRbvuuA4s0Id JAgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DZvlB7X1K5ytr/bpMK3Bn7Gjfn9nK+5xj8AoQIBHxpc=; b=EDxjQQJjc7eUjNG8PzpU0HT3N8n1MlsE4U7nYL4fB80sTuafg79Msyz0o6VdA1cw3R kewV3Ii6AJB6TfndruQvKRHzK8p4B1HZ58ftPTiKKOn99LSqjj/uw3B07YydlFmkTl63 rYz+z9zeBmju6OzE5L5PdiJVvnv6zRgZYLTOly76TAXAHNXhRIw4X89NHEEv9lr3u0h6 zkFW4bra/42OhO4UP7hEZcbf6ViM2uivcr10THx7HLHVseIEh5kf9b/WDbPyYswqDqAo dzwLc1X48smljp/odAtPUuy9afztTGR7OYsLthQ0apEFdhxNpf1k8xaJzsvAD+vBXWTs pVhg== X-Gm-Message-State: AOAM532e3eqz5L3i3NMuqL56jtBPpoVHSh0tZ9pZ4L07jD66K2hCWGU8 0MNHGWazRfYTTarovIhxTIOw+1m+RPzIc1QzoDk= X-Google-Smtp-Source: ABdhPJzMV4NZvtajGgWC5fbAZKwG+Zawh3MSdW75wSOcL0as5E4HVrS9wV9JFLNjMjenGF05ewdd3WnHThOAyh0LYis= X-Received: by 2002:a6b:b886:: with SMTP id i128mr10436606iof.151.1637142555184; Wed, 17 Nov 2021 01:49:15 -0800 (PST) MIME-Version: 1.0 References: <20211005125923.2651449-1-jerinj@marvell.com> In-Reply-To: <20211005125923.2651449-1-jerinj@marvell.com> From: Jerin Jacob Date: Wed, 17 Nov 2021 15:18:49 +0530 Message-ID: Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control To: Jerin Jacob Cc: dpdk-dev , Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , Andrew Boyer , Beilei Xing , "Richardson, Bruce" , Chas Williams , "Xia, Chenbo" , Ciara Loftus , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Gaetan Rivet , Gagandeep Singh , Guoyang Zhou , Haiyue Wang , Harman Kalra , heinrich.kuhn@corigine.com, Hemant Agrawal , Hyong Youb Kim , Igor Chauskin , Igor Russkikh , Jakub Grajciar , Jasvinder Singh , Jian Wang , Jiawen Wu , Jingjing Wu , John Daley , John Miller , "John W. Linville" , "Wiles, Keith" , Kiran Kumar K , Lijun Ou , Liron Himi , Long Li , Marcin Wojtas , Martin Spinler , Matan Azrad , Matt Peters , Maxime Coquelin , Michal Krawczyk , "Min Hu (Connor" , Pradeep Kumar Nalla , Nithin Dabilpuram , Qiming Yang , Qi Zhang , Radha Mohan Chintakuntla , Rahul Lakkireddy , Rasesh Mody , Rosen Xu , Sachin Saxena , Satha Koteswara Rao Kottidi , Shahed Shaikh , Shai Brandes , Shepard Siegel , Somalapuram Amaranath , Somnath Kotur , Stephen Hemminger , Steven Webster , Sunil Kumar Kori , Tetsuya Mukawa , Veerasenareddy Burru , Viacheslav Ovsiienko , Xiao Wang , Xiaoyun Wang , Yisen Zhuang , Yong Wang , Ziyang Xuan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 5, 2021 at 6:32 PM wrote: > > From: Jerin Jacob > > rte_eth_dev_priority_flow_ctrl_set() based API is not generic as it > can not support other than VLAN priority mapping to PFC traffic class. > > Introducing RTE_FLOW_ACTION_TYPE_PFC_SET_TC rte_flow action to > set the traffic class as per 802.1Qbb specification. This will enable, > Traffic class(8bit) to be selected based on any packet field like DSCP. > > Also, making it as rte_flow action will enable fine control on > traffic class selection to a specific queue or VF etc. > > Signed-off-by: Jerin Jacob Ping. If there are no comments on RFC, Planning to send v1 for 22.02. > --- > > Planning to submit the testpmd and cnxk ethdev driver changes after receiving > the feedback on this. > > > doc/guides/prog_guide/rte_flow.rst | 24 ++++++++++++++++++++++++ > lib/ethdev/rte_flow.c | 1 + > lib/ethdev/rte_flow.h | 27 +++++++++++++++++++++++++++ > 3 files changed, 52 insertions(+) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 2b42d5ec8c..e59f8a2902 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2999,6 +2999,30 @@ which is set in the packet meta-data (i.e. struct ``rte_mbuf::sched::color``) > | ``meter_color`` | Packet color | > +-----------------+--------------+ > > +Action: ``PFC_SET_TC`` > +^^^^^^^^^^^^^^^^^^^^^^ > + > +Set traffic class as per PFC (802.1Qbb) specification. > + > +This action must be used with any of the following action. > + > +- ``RTE_FLOW_ACTION_TYPE_QUEUE`` > +- ``RTE_FLOW_ACTION_TYPE_RSS`` > +- ``RTE_FLOW_ACTION_TYPE_PF`` > +- ``RTE_FLOW_ACTION_TYPE_VF`` > +- ``RTE_FLOW_ACTION_TYPE_PHY_PORT`` > +- ``RTE_FLOW_ACTION_TYPE_PORT_ID`` > + > +.. _table_rte_flow_action_pfc_set_tc: > + > +.. table:: PFC_SET_PRIORITY > + > + +-----------------+-------------------------------------+ > + | Field | Value | > + +=================+=====================================+ > + | ``tc`` | Traffic class as per PFC (802.1Qbb) | > + +-----------------+-------------------------------------+ > + > Negative types > ~~~~~~~~~~~~~~ > > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c > index 8cb7a069c8..75c661159e 100644 > --- a/lib/ethdev/rte_flow.c > +++ b/lib/ethdev/rte_flow.c > @@ -189,6 +189,7 @@ static const struct rte_flow_desc_data rte_flow_desc_action[] = { > */ > MK_FLOW_ACTION(INDIRECT, 0), > MK_FLOW_ACTION(CONNTRACK, sizeof(struct rte_flow_action_conntrack)), > + MK_FLOW_ACTION(PFC_SET_TC, sizeof(struct rte_flow_action_pfc_set_tc)), > }; > > int > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 7b1ed7f110..5298418e9e 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2409,6 +2409,13 @@ enum rte_flow_action_type { > * See struct rte_flow_action_meter_color. > */ > RTE_FLOW_ACTION_TYPE_METER_COLOR, > + > + /** > + * Set traffic class as per PFC (802.1Qbb) specification. > + * > + * See struct rte_flow_action_pfc_set_tc. > + */ > + RTE_FLOW_ACTION_TYPE_PFC_SET_TC, > }; > > /** > @@ -3168,6 +3175,26 @@ struct rte_flow_action_meter_color { > enum rte_color color; /**< Packet color. */ > }; > > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_PFC_SET_TC > + * > + * Set traffic class as per PFC (802.1Qbb) specification. > + * > + * This action must be used any of the following action. > + * - RTE_FLOW_ACTION_TYPE_QUEUE, > + * - RTE_FLOW_ACTION_TYPE_RSS, > + * - RTE_FLOW_ACTION_TYPE_PF, > + * - RTE_FLOW_ACTION_TYPE_VF, > + * - RTE_FLOW_ACTION_TYPE_PHY_PORT, > + * - RTE_FLOW_ACTION_TYPE_PORT_ID > + */ > +struct rte_flow_action_pfc_set_tc { > + uint8_t tc; /**< Traffic class as per PFC (802.1Qbb) specification */ > +}; > + > /** > * Field IDs for MODIFY_FIELD action. > */ > -- > 2.33.0 >