From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEB80A0C4B; Tue, 9 Nov 2021 11:11:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2FE141100; Tue, 9 Nov 2021 11:11:49 +0100 (CET) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id A7A514068B for ; Tue, 9 Nov 2021 11:11:48 +0100 (CET) Received: by mail-il1-f181.google.com with SMTP id l19so20172170ilk.0 for ; Tue, 09 Nov 2021 02:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXjAUfSm3jFL0jPb5NgAaI17jBVLZOW0WmnjK2vMjQk=; b=iMfcoVGjSzu+HO2TwWZzeyXvWCPptk2fd7HvlB4pJDYY2bHo963oB4fbmQnO1bjsk9 GszJItrlKXTNBI/31Y7cMKExlDHw1JReaa8D98AkyXwku4YdPsuYMtHu+WWV3NRWMyfv SCNnxS7pkDxuI06M0iXXaeSSDHlP6KJcPJLTBs//BKpy5PFQ3T1DCEMnFJGn24fM+y8M q2SteGthueNXMk62QSVGPSDdFJ7UAzwa/HIKh8ilJx5yfWLH9GKdTkCDsvK/UTgzgSFT h3qVmqJy/rI1/O32cPkoRRfER7tpg48WCLpvHZETFfhj7UwYUcfRLPZ/BmrF1kyXuJDo 61Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXjAUfSm3jFL0jPb5NgAaI17jBVLZOW0WmnjK2vMjQk=; b=5AMrHJ3ziONHDzvNHLvaqiIfpxSEv0RBoaL+V/2saXNwPrjETPApmKcrp3WItNCphU X60AQVExk5mYegQfW2/2MdZFzVeLvDen1pZ8X9hxwMVMhbsRPHl5ROqGnClReF72/rbw XHq5mhGLiToWPy1+BDvXMp3Bgulea1QxWtp9RX9CmHbcgSTOtTIITbQ5xh2NZ1u8jAMM flu768ohIqqH6PkMHs+6psxNQlSNlKy3vp7td+jBZqs5yt8T5BAYrAft0Ox9KSchbFDX fFsCRkAmC0PIhceqaHQWd7P5Roc5jKR5nxL/RJGuXOLfKxhTaVIa8/L7NeM53XkpMcff 6ieg== X-Gm-Message-State: AOAM531RZXTHzKH6/BwWsP2AlSCeRSupnCrgoX9TIJtTac4ug+DsnEfs ZAVENr5iflsY2O9X6I8IGWScjJ27ilWd1TwJ31A= X-Google-Smtp-Source: ABdhPJzND2hVTwWjS4jW4+9WfHdl1Y+KqNfjlOAiLba3NkFDgcVXZ8IJ5AFZV17LxJpCIf7b2JnmfrBhlSW0cRv3RZs= X-Received: by 2002:a05:6e02:170a:: with SMTP id u10mr4282801ill.251.1636452708034; Tue, 09 Nov 2021 02:11:48 -0800 (PST) MIME-Version: 1.0 References: <20200227070301.11520-1-skori@marvell.com> <20211022074843.907766-1-skori@marvell.com> In-Reply-To: <20211022074843.907766-1-skori@marvell.com> From: Jerin Jacob Date: Tue, 9 Nov 2021 15:41:21 +0530 Message-ID: To: Sunil Kumar Kori Cc: Jerin Jacob , Nikhil Rao , Pavan Nikhilesh , Hemant Agrawal , Nipun Gupta , "Van Haaren, Harry" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Liang Ma , dpdk-dev , Thomas Monjalon , David Marchand , "Gujjar, Abhinandan S" , Erik Gabriel Carrillo , "Jayatheerthan, Jay" , Ferruh Yigit , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 22, 2021 at 1:18 PM wrote: > > From: Sunil Kumar Kori > > Patch adds skeleton for feature matrices for event dev > and Rx/Tx adapters. > > Along with, .ini files are added for all supported PMDs. > > Signed-off-by: Sunil Kumar Kori + Tree maintainers and eventdev adapter maintainers 1) Please rebase to dpdk-next-eventdev 2) Please update devtools/check-doc-vs-code.sh You can use search _CAP_ and != CAP_REQUIRES_ to detect the capability change or so. 3) Update the .ini for all the eventdev drivers, not just Marvell ones. > > # Maximum feature description string length > -feature_str_len = 30 > +feature_str_len = 45 I hope this OK. I understand that without this it gives errors and feature-length is not enough > diff --git a/doc/guides/eventdevs/features/default.ini b/doc/guides/eventdevs/features/default.ini > new file mode 100644 > index 0000000000..d007d7a69e > --- /dev/null > +++ b/doc/guides/eventdevs/features/default.ini > @@ -0,0 +1,30 @@ > +; > +; Features of a default eventdev driver. > +; > +; This file defines the features that are valid for inclusion in > +; the other driver files and also the order that they appear in > +; the features table in the documentation. > +; > +[Features] > +Event queue priority based scheduling = > +Event priority based scheduling = > +Event device distributed scheduling = > +Event device non sequential mode = > +Event queue all types = > +Burst mode enqueue/dequeue = > +Event port implicit release disable = > +Runtime event queue/port linking = > +Multi queue linking per port = 1) Please sync the doc order with flag definition order in header file[1] 2) You can remove RTE_EVENT_DEV_CAP_REQUIRES_MAINT from the list(*CAP_REQUIRES*) as this is limitation. [1] RTE_EVENT_DEV_CAP_QUEUE_QOS RTE_EVENT_DEV_CAP_EVENT_QOS RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES RTE_EVENT_DEV_CAP_BURST_MODE RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE RTE_EVENT_DEV_CAP_NONSEQ_MODE RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT RTE_EVENT_DEV_CAP_CARRY_FLOW_ID > + > +; > +; Features of a default adapter. > +; > +[Adapter Features] Please make this as [Eth Rx adapter Features] > +Eth Rx/Tx adapter on internal port = You can remove Eth Rx/Tx adapter as new subject has [Eth Rx adapter] > +Multiple event queues per ethdev = > +Override flow ID = Missing RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR Add new section for Tx adapter and add RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT RTE_EVENT_ETH_TX_ADAPTER_CAP_EVENT_VECTOR Add new section for Crypto adapter > +Crypto adapter new event enqueue = > +Crypto adapter forwarded event enqueue = > +Crypto queue pair mapping to event queue = > +Crypto adapter session data store/retrieve = Add new section for timer adapter > +Timer adapter support in H/W = Missing RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC