From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 773534319B; Wed, 18 Oct 2023 16:20:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BE324027C; Wed, 18 Oct 2023 16:20:38 +0200 (CEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id 0E3C940261 for ; Wed, 18 Oct 2023 16:20:35 +0200 (CEST) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-41819a68143so47320851cf.3 for ; Wed, 18 Oct 2023 07:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697638834; x=1698243634; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=33xuSaJy14TEUdFiR3FSdf/XEtSrZIjFHgzocUeZ+o4=; b=LKlFKgJAE0LTGBkjf6zNlN8g0ddaSrBQoeLXKif7id9ulwmb1mPFTUqXhMqiy6QBF+ nQO7L4L1Cso5IvVe8y01xVTzQrK5/Xrr0/Sa7kVamKKwQxuYrnjZwx8jkf464VyoTGlN TkJRFu9zsxaCT804st0lVT3u3C8lIMnRUnmiyScUJnqIi+kISUyOewwAmU54WyLTV+qm aEhyglQRJWswhLtVebt5ew1eTBlub76Q0I4q5I8W71ZOZa1Qt8nOpcrbFOCBWOxhQTts vXDSIY/Hf+xeGE2RwzznNUEGEZOpaqz7e9I9PoCWR1zEwxr3iTfI2JRVx81mCPgYB1H5 uwjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697638834; x=1698243634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=33xuSaJy14TEUdFiR3FSdf/XEtSrZIjFHgzocUeZ+o4=; b=ZZtlcDzuQ9nfm2ao9fyCfKoWKGunkS9CCdVac2V5MdVn8S3kqehp2patdSQgk7TMmd rFWm7JCmIuTdPgCVdsvdNV2EcbmFEJuSPwqQglCzFhSVxZ2WwOBPbwMf+WS4b7FSc1ct kCIrmw2/R5kOLAghZN77s6IRxnglj0J/M/Oj2VmhC2AHAj8qpksY95Z9C8ZFdG3jtoQX gzKLIjxvUU/9a2UoXwP1tfSz1AGLBT9LJ8NGRmVXu/3RrIhA9dUTWHS+f1pZXLZluSJ1 5fQ8tysevxjlCRqjmmTJB49ARIS4X0AK/3xGSDTYIBloXzShrlaC1MrB0TjBT8LFAvcN XVqw== X-Gm-Message-State: AOJu0YwnA+HYdG/tzK/r6cDq86fA9ccGxpyh7j3HPQAYw2eVB82tMxWi p2nz4FB2WGS1rZtUcu+q8+1+YXtMz0e7Bei5sSg= X-Google-Smtp-Source: AGHT+IGh11Sv2UTYyaDBm0fvWF1yTaF0q0K/3FBpShlGFsmhWs8FzStsXnrwOf1/cXv0izPH/LDZZzXKkDK2p1INADA= X-Received: by 2002:a05:622a:1e0e:b0:41b:826b:1be8 with SMTP id br14-20020a05622a1e0e00b0041b826b1be8mr4054792qtb.17.1697638834337; Wed, 18 Oct 2023 07:20:34 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20231018135423.14111-1-syalavarthi@marvell.com> In-Reply-To: <20231018135423.14111-1-syalavarthi@marvell.com> From: Jerin Jacob Date: Wed, 18 Oct 2023 19:50:08 +0530 Message-ID: Subject: Re: [PATCH v6 00/34] Implementation of revised ml/cnxk driver To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 7:24=E2=80=AFPM Srikanth Yalavarthi wrote: > > This patch series is an implementation of revised ml/cnxk driver > to support models compiled with TVM compiler framework. TVM models > use a hybrid mode for execution, with regions of the model executing > on the ML accelerator and the rest executing on CPU cores. > > This series of commits reorganizes the ml/cnxk driver and adds support > to execute multiple regions with-in a TVM model. > Fix this warning ### [PATCH] ml/cnxk: enable creation of mvtvm virtual device Warning in drivers/ml/cnxk/cn10k_ml_dev.c: Using rte_panic/rte_exit Fix as needed which is relevent ### [PATCH] ml/cnxk: add generic cnxk device structure WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #1778: FILE: drivers/ml/cnxk/cn10k_ml_ops.c:1316: + strncpy(xstats_map[idx].name, cn10k_mldev->xstats.entries[i].map.name, total: 0 errors, 1 warnings, 2276 lines checked ### [PATCH] ml/cnxk: add generic model and layer structures WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #117: FILE: drivers/ml/cnxk/cn10k_ml_model.c:379: + strncpy(layer->info.input[i].name, (char *)metadata->input1[i].input_name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #166: FILE: drivers/ml/cnxk/cn10k_ml_model.c:411: + strncpy(layer->info.input[i].name, (char *)metadata->input2[j].input_name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #221: FILE: drivers/ml/cnxk/cn10k_ml_model.c:449: + strncpy(layer->info.output[i].name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #255: FILE: drivers/ml/cnxk/cn10k_ml_model.c:472: + strncpy(layer->info.output[i].name, total: 0 errors, 4 warnings, 1905 lines checked ### [PATCH] ml/cnxk: update model load and unload functions WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #83: FILE: drivers/ml/cnxk/cn10k_ml_model.c:367: + strncpy(io_info->input[i].name, (char *)metadata->input1[i].input_name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #135: FILE: drivers/ml/cnxk/cn10k_ml_model.c:399: + strncpy(io_info->input[i].name, (char *)metadata->input2[j].input_name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #204: FILE: drivers/ml/cnxk/cn10k_ml_model.c:437: + strncpy(io_info->output[i].name, (char *)metadata->output1[i].output_name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #244: FILE: drivers/ml/cnxk/cn10k_ml_model.c:461: + strncpy(io_info->output[i].name, (char *)metadata->output2[j].output_name, total: 0 errors, 4 warnings, 1094 lines checked ### [PATCH] ml/cnxk: update device and model xstats functions WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #1100: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:856: WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #1100: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:856: + strncpy(xstats_map[idx].name, xs->map.name, RTE_ML_STR_MAX)= ; total: 0 errors, 1 warnings, 1248 lines checked ### [PATCH] ml/cnxk: fetch layer info and load TVM model WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #172: FILE: drivers/ml/cnxk/mvtvm_ml_ops.c:125: + strncpy(model->layer[layer_id].name, total: 0 errors, 1 warnings, 207 lines checked ### [PATCH] ml/cnxk: update internal info for TVM model WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #85: FILE: drivers/ml/cnxk/mvtvm_ml_model.c:175: + strncpy(model->mvtvm.info.input[i].name, metadata->input[i].name, WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #118: FILE: drivers/ml/cnxk/mvtvm_ml_model.c:208: + strncpy(model->mvtvm.info.output[i].name, metadata->output[i].name, total: 0 errors, 2 warnings, 173 lines checked ### [PATCH] ml/cnxk: enable reporting model runtime as xstats WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #113: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:243: + strcpy(suffix, "cycles"); WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #115: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:245: + strcpy(suffix, "ns"); total: 0 errors, 2 warnings, 477 lines checked