From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA424A04DD; Wed, 28 Oct 2020 10:12:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30257C321; Wed, 28 Oct 2020 10:09:28 +0100 (CET) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id DC567C770 for ; Wed, 28 Oct 2020 10:09:25 +0100 (CET) Received: by mail-il1-f195.google.com with SMTP id k1so4005730ilc.10 for ; Wed, 28 Oct 2020 02:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+3Mi991P1SF+WAku+dwvh51Wn3Pl3BZxS1unCeubknI=; b=pRJfLymMaUnQu3upMIna1qjAmDJnD8TzjOCkka25+G6kn2ypqK47SsdDWMSjeFBIGY FTe4lcsK/tqiR3ahlZC+7A1hEdpKniuGAkIFAXpWQC6XGR/K6SQ5XMCehytGmzoPOVbl v456Q3eyfnQYi9/1qb95OarpuUdM8Qu0P/lYzRYg5KDtsNRFY6NJhG16zvidPqc8QWTT K1kh78PaCb6s75GZ9szqgYhMDNFvyUFcB/TTWdXSwxwwedr5mguf0PH+nppLxDI1RMJ6 B9e71lW/MaiUcDyixS7qS5D/CW0u4oWKS7yyGAJDApDWfGtla0GCzYYE6vhpAYT41r6n 0bdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+3Mi991P1SF+WAku+dwvh51Wn3Pl3BZxS1unCeubknI=; b=qI98IcL9Gk+sMrpXRniEf7Y5HG/AfscxDKeT5H1D0/mXUYNxGp2IO4cO9q8EhNdtjb j/LRlZhiewfocp4ePO3+K/NEzoigkQDugsJ9EPuyMIbsOI1Bfij3RJHmF+1puybhfmhi 1wuj7zkuGdSmadz9SOQUthae5+JWDK2s7etMR4osXBdDNsyfZWNqorGsD+a3h7gMqxL8 oP6qJjx2n8kTl2hX2oDOUFjDH0EgQx0UqFPxS0CZzK2xti/ODXCUtXnzNv06gfMcxq/I 39YHdEvv9mCj3ewEtFV4j5kI24HlpXussoRPHU6F7dioWsQCdy+p6D94n4X8ybwbr4Lf ZYgQ== X-Gm-Message-State: AOAM531C9VTEXQ77oz26MYaf4ZOBkxxMf9FsUI12c3iUFBINb+AyBS1V VlnOTuF1IPwqheJQckk8ji5qTBtpWE5/vKrzXEo7dnJ9 X-Google-Smtp-Source: ABdhPJwJKHqK4j20xjBaQHe68jVAhOZhHW8d1wXR8bHuTHGYpZ8PdXJynpIERTxoCOuqm0gHVKIJGUERS+kxfI2g/UY= X-Received: by 2002:a92:1e02:: with SMTP id e2mr5176838ile.294.1603876164273; Wed, 28 Oct 2020 02:09:24 -0700 (PDT) MIME-Version: 1.0 References: <20201027221343.28551-1-david.marchand@redhat.com> <20201027221343.28551-8-david.marchand@redhat.com> In-Reply-To: From: Jerin Jacob Date: Wed, 28 Oct 2020 14:39:08 +0530 Message-ID: To: David Marchand Cc: "McDaniel, Timothy" , dpdk-dev , Jerin Jacob , Pavan Nikhilesh , Liang Ma , Peter Mccarthy , Harry van Haaren , Ray Kinsella , Neil Horman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 7/8] event: switch sequence number to dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 2:25 PM David Marchand wrote: > > On Wed, Oct 28, 2020 at 8:27 AM Jerin Jacob wrote: > > > diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h > > > index 9e3415e421..d4ad31da46 100644 > > > --- a/app/test-eventdev/test_order_common.h > > > +++ b/app/test-eventdev/test_order_common.h > > > > Could you change symbol name to rte_event_dev_selftest_seqn_dynfield_offset() > > to limit the scope only to self test. also, it is not required to expose > > rte_event_test_seqn_dynfield_register() in that case. > > How about moving this to rte_eventdev_pmd.h and make it a pmd only API? > => rte_event_pmd_ prefix +1 > > I would mark it rte_internal too. Ack. > > > -- > David Marchand >