From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67FA4A034E; Mon, 14 Feb 2022 16:29:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FBF741144; Mon, 14 Feb 2022 16:29:06 +0100 (CET) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by mails.dpdk.org (Postfix) with ESMTP id 78C414067E for ; Mon, 14 Feb 2022 16:29:04 +0100 (CET) Received: by mail-il1-f178.google.com with SMTP id e8so12563417ilm.13 for ; Mon, 14 Feb 2022 07:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LgpRx9RLqU0yvr0v6hZU/5QvRxbf+WO/l27D2+Cujes=; b=hp2OYVtiU1oK4rrM8ildALWCMIHzxcz0z+ly+U817Uv709gNoV9JRweKA+8BRrY6Fe sWBj54IWh7qjOz176u2n1t+xVSxhsult9zaJwbXF7L83hU9M+WWiF26JbqNIoCysHAj+ AXTeX0bhYmdmVqbsPXldaKhFNnIYEJa3yfwoDaKDGzvA0iFGQOV6dHyT8n/Bd3WXTj2b fWIPbAHme3rLWbFtMRg3uOI9unTzyBoasawZ5yJFDBsBAdLphvRPCD+uBfFATqINqt23 O8uNmlfV9UIY63x/xOd4KZzcPNzFG/LFCmnQD+iB7PMG3u9hh0A9la1x7WphaU2a4Llt oucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LgpRx9RLqU0yvr0v6hZU/5QvRxbf+WO/l27D2+Cujes=; b=cXS7d/pEeJl3ueVSWXHT6/s2Mmr1m9KWfkRmI2P0pOmNC0EBrtm171ADJJOlqpyllg RnHs8KMb/xle4X5BVS1LtwTnJrfMXajKAfrJ/UMtAhg4lmugeX+Smo79+aiJnnVolj10 CCMQ+VOS26j9b5StCQVdYoCSgjGozvwN5gTu5TfDoSXeb92bOxW4SZrfbUuTL9+u4TJF 6lSY8WQzuCSujDYxqkkx/3W5dj1mw/BbQe3aSv194wdGegqNtmKhZnKSzQ30DcPdniCK wQ7IcHCL5lYUk9Jz8U49D6zZxt/+bUoBqVNWOxhnBC6RF2GHo/eJJC/NiBNAtkaKLh76 JXgQ== X-Gm-Message-State: AOAM530Z5yeZVqa/SkIoice6BT3VnW3A13x/ajLMtdWebc4mSEMs8wbk itM+XrgvjNKQGlc/2KfZNsXU0I11tW+8fZXYGRw= X-Google-Smtp-Source: ABdhPJzZAz6I8vrzNQLxoPPchfALgXIfej73Gyd6MihAA5aN+99L2q5/8QwYYN4eV3HEVfken4zAYV1hwMTFvNGawsU= X-Received: by 2002:a05:6e02:1ca4:: with SMTP id x4mr8050236ill.262.1644852543797; Mon, 14 Feb 2022 07:29:03 -0800 (PST) MIME-Version: 1.0 References: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Mon, 14 Feb 2022 20:58:37 +0530 Message-ID: Subject: Re: [PATCH] eventdev/eth_rx: fix queue config get API To: Naga Harish K S V Cc: "Jayatheerthan, Jay" , Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V wrote: > > the memcpy size used in queue config get function is more than > the source size. Use correct size to avoid copy of unnecessary > data. > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > Signed-off-by: Naga Harish K S V Hi @Jayatheerthan, Jay Could you review it? > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index ae1e260c08..e44499e887 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > queue_conf->servicing_weight = queue_info->wt; > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > + memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event)); > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > -- > 2.23.0 >