From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66FBEA04F0; Mon, 13 Jan 2020 10:31:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C3301D5D0; Mon, 13 Jan 2020 10:31:38 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 862D71C2F7; Mon, 13 Jan 2020 10:31:36 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id c16so9046971ioo.8; Mon, 13 Jan 2020 01:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o2JRwZ1MomIXUGrHXR/mNndCky3U/oPT7SBPjksfILU=; b=Hg575Hxp7nJE2FT7P2NdMhD701Rm94gmCSMYOJ0P9b+PdcSgwODkIBxIiZUCSDKGJZ tv1yafpIbfb5Q6a2/B1LLPDVoh7S0g68iDjqOdlsDvLPLCPH4geZL4xpuQhioL/d2N82 DLJNm4Ng1c4YEQT6ESqbHGyHvjZu7yG6DXMt+8lXwS0RJnncfXRRTn2uLN+hAuTFUpAx DFUl3L/VcS257CUgjnprXrVOljMNg7qQSGDwHaIUfgPc2stbJFjdGo6EgIlJhkZg6vJ5 9oRmIobvq6rlMApvCmLw2sfK8M5ETE0xFgGvqFvvbqdYVdtoq+GhKMwy0IEAduaV2ErV HwZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o2JRwZ1MomIXUGrHXR/mNndCky3U/oPT7SBPjksfILU=; b=HldFS7eWERTNj4ysCdrHlK5p6sLWER0xW2rLSwuBQ2kEejyInFXwh9FLl5GyPKsLqI OsIuBQ65eGQMArxsmkYXLH4f9p8iaZttuzFXJxmHI5ZyQqPCMN6E1OX6yLgoLr9jJnEs YEVB/ilwkz0DRQZ0WjFzUWKEIZtCsYYL9UINnDiJYetOVdnF9w8vjdjWQbkRvIzKptCc 0HPw6yGNBAKuwNASnaRJp+mDbdXRx2wnvGdkYdABN+ZeyHGSUBMrThtk9ljg01zaDf5X OgPLwWFuI12WwBs1QqKu8zoO5fLyBhDJUMlud3yr6eEbPgxcdMv9LA4mxJm7/8uPY0wp 7wnQ== X-Gm-Message-State: APjAAAUN3uz0SWiECjp+8qFzHCJQRpIbJySQFq0I1CNgW+z1b6wEvKb9 xiW7E87DHOqSguVXFRWGhd5Zsnp+mz91C7v3nQ4= X-Google-Smtp-Source: APXvYqwh1L+x6jCb6xkrYK6RDBul+GbNkYl/cJbdw4qSxLTAW6nOlup30WnAhpJPprBzUKN0uLjedZePmPCRRZ/BWkc= X-Received: by 2002:a5e:8b44:: with SMTP id z4mr11860672iom.271.1578907895830; Mon, 13 Jan 2020 01:31:35 -0800 (PST) MIME-Version: 1.0 References: <1576173504-29467-1-git-send-email-hkalra@marvell.com> In-Reply-To: <1576173504-29467-1-git-send-email-hkalra@marvell.com> From: Jerin Jacob Date: Mon, 13 Jan 2020 15:01:19 +0530 Message-ID: To: Harman Kalra , Ferruh Yigit Cc: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix get supported ptype callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 12, 2019 at 11:29 PM Harman Kalra wrote: > > Setting up supported ptypes using testpmd command is failing > because supported_ptypes_get callback will never return ptypes > supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags > is zero by default in testpmd. > > Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeontx2/otx2_lookup.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c > index bcf2ff4e8..568557116 100644 > --- a/drivers/net/octeontx2/otx2_lookup.c > +++ b/drivers/net/octeontx2/otx2_lookup.c > @@ -17,7 +17,7 @@ > const uint32_t * > otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) > { > - struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > + RTE_SET_USED(eth_dev); > > static const uint32_t ptypes[] = { > RTE_PTYPE_L2_ETHER_QINQ, /* LB */ > @@ -56,10 +56,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) > RTE_PTYPE_UNKNOWN, > }; > > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F) > - return ptypes; > - else > - return NULL; > + return ptypes; > } > > int > -- > 2.18.0 >