From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8D6DA00BE; Tue, 3 May 2022 19:37:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5815340C35; Tue, 3 May 2022 19:37:27 +0200 (CEST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id 4731540691; Tue, 3 May 2022 19:37:26 +0200 (CEST) Received: by mail-il1-f180.google.com with SMTP id t4so10189447ilo.12; Tue, 03 May 2022 10:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A3Vi5lwKdc6vZIlvKWn/kRo5URncKwHONCcBRJvuX+o=; b=jNoOQDyQX4fCOX1yq80jZVPyDTI1XBp1WYcuBIYJajLbm5J1kW3YUSJXEH2Oxg+KSn RAN4rQiGf4ibUaItb19gvEn68YMopDMOXpRZXW6bnJhIIW1cL/iWsWxI1diMEIb0R+4Q BHFln50c0riQdg/ToK5yNjzEKactZTS7DPpsYrAokfnTem4roEo20WEg1hwc+M9tOhYz VTDEj3pR5hpvwhQ7DycFi0t8BHMqSbDoV2Gpu90wAG/KyVk2GdAbRbnxmP1NEoREyMxm EZZwMfFQohL2jGWMOJFUGUfUql7urvqfgRiHSHJAZWDnWgpRzfp/q97pp8Jl5dEAv30T vu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A3Vi5lwKdc6vZIlvKWn/kRo5URncKwHONCcBRJvuX+o=; b=EE4blNItHZ8UU9UBvO3jstQzUx+usMzP1yuLP9SuIjd7lIrL6X1pF4Z+TLkAj1tA/W h2xTF0P2FMIhHIiUaGs8s0o+XvehXePE9bfRT/NZQrYB81+2cAwX1y/2b2Xf9rsKwP/T QVW1SInDNSycBAf/3SO2Vnj9drfgOB5OntlWsgVZoDEJ0LwPoiKU835lra4aCJKqsvBG ehbPmhQUg/mo/2OgLpwpW4UzEWUDiR9gbG3fTtxenbPiZERfN/vzANnO4GB0GORnUK6X qO+4nJuZrMj6l2En1JROaXC8Ahtn9ThFuohWkZV9uGXs8AA4SckRY1LBM9vzyPM86rEF DVfw== X-Gm-Message-State: AOAM531HQ9TXVYYXbnyCJQSlQtOzk6jbEk0AZe9m/zAuJNy/W+wvhUzi 5dkrLwhGhUfgmRfaRlHR1kEoD+r8pzbKmNq7vmmOJKgfIZEgIA== X-Google-Smtp-Source: ABdhPJx8x2xAz/BpHWgXI8tcTC/If7YMji8p61kLHeWNZw1rHjGOjJR9aFQW5Co2f03LMkPei1+pgJYGIS9CG7ql08E= X-Received: by 2002:a05:6e02:1a03:b0:2cc:5211:fbae with SMTP id s3-20020a056e021a0300b002cc5211fbaemr7068353ild.75.1651599445522; Tue, 03 May 2022 10:37:25 -0700 (PDT) MIME-Version: 1.0 References: <20220422104709.20722-1-ndabilpuram@marvell.com> <20220422104709.20722-28-ndabilpuram@marvell.com> In-Reply-To: <20220422104709.20722-28-ndabilpuram@marvell.com> From: Jerin Jacob Date: Tue, 3 May 2022 23:06:59 +0530 Message-ID: Subject: Re: [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path To: Nithin Dabilpuram Cc: Jerin Jacob , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , Pavan Nikhilesh , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 22, 2022 at 4:20 PM Nithin Dabilpuram wrote: > > Fix multi-seg extraction in vwqe path to avoid updating mbuf[] > array until it is used via cq0 path. > > Fixes: 7fbbc981d54f ("event/cnxk: support vectorized Rx event fast path") > Cc: pbhagavatula@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Nithin Dabilpuram Please fix following check-gitlog.sh errors Wrong headline prefix: net/cnxk: add receive channel backpressure for SDP Is it candidate for Cc: stable@dpdk.org backport? common/cnxk: fix SQ flush sequence common/cnxk: fix issues in soft expiry disable path net/cnxk: optimize Rx fast path for security pkts > --- > drivers/net/cnxk/cn10k_rx.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h > index 00bec01..5ecb20f 100644 > --- a/drivers/net/cnxk/cn10k_rx.h > +++ b/drivers/net/cnxk/cn10k_rx.h > @@ -1673,10 +1673,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, > vst1q_u64((uint64_t *)mbuf2->rearm_data, rearm2); > vst1q_u64((uint64_t *)mbuf3->rearm_data, rearm3); > > - /* Store the mbufs to rx_pkts */ > - vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > - vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > - > if (flags & NIX_RX_MULTI_SEG_F) { > /* Multi segment is enable build mseg list for > * individual mbufs in scalar mode. > @@ -1695,6 +1691,10 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, > mbuf3, mbuf_initializer, flags); > } > > + /* Store the mbufs to rx_pkts */ > + vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > + vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > + > /* Mark mempool obj as "get" as it is alloc'ed by NIX */ > RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1); > RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1); > -- > 2.8.4 >