From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 80E05A04B6;
	Sun, 11 Oct 2020 11:54:46 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8FBB21D534;
	Sun, 11 Oct 2020 11:54:44 +0200 (CEST)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com
 [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 304F71BCDE
 for <dev@dpdk.org>; Sun, 11 Oct 2020 11:54:43 +0200 (CEST)
Received: by mail-io1-f68.google.com with SMTP id g7so14602470iov.13
 for <dev@dpdk.org>; Sun, 11 Oct 2020 02:54:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=Zl/DAF0BVo6WS36N08sufVLbSp2RhDQZwTJZ83WD6A4=;
 b=SPem6MwpSsRHwIkAadAHjSDmHdkrGdDUCvu/Sbi4zGguBI9IR5cQL/qHeC047b31pv
 hLL9QFSFejWMM8I88D+0PBcrK8kF2gp6+qdEYmdADHLAe8QSIHWTGpBJg5cENEBZZc1Z
 +//QezBaFFB5JUt8Hdr+e8kEaLLiZU1NPSFogehZ7knWPk5iEAXVeKMJwdag+rvW2OyX
 1kLqLyQZuxx6LVyDBkibyGWwW1igL8hlvF4DRok68J9Ym5QsWJNBZk5hM2rsvLv0Zmlh
 JNZhKPkZZm7kGet31XTsjb0D4o0EdDEQN7eWcshqxwX1TBk1sz/1gfWLFdjsBkVXVUc8
 LdWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Zl/DAF0BVo6WS36N08sufVLbSp2RhDQZwTJZ83WD6A4=;
 b=npMsAE9JDNI9O9sziMPCq5jKSnltQswoASk82l/dYCZ6wQEwo8klXqMa5yDYtx9c8D
 KoZyExPac9DPtWL5X53zlq2T6toTNrGZRwmxB+86GMth3yMKFwjIZDHKNl0wymR6nZ8u
 Mqb+VIk7uq0y94aJfmmqX+ox0GcqcbW5cAeAILCGWenN1+DZT3z0cpMjp1OheThCaIle
 Sq6ga4UfYRlreo8UxVqbogvn2jzj1z7ntBBbQ09CpYBoMN6G7hm9+6WHMr3A8hXGIFfc
 q4ySHtE83/HUK+OoEiAyOGkn5uR+/kyG+YIwfQde1bX1ySFI0m4ivlyKk1EYnGMYnigU
 u3eQ==
X-Gm-Message-State: AOAM533SU6OotLRJka+2xzgzYfoM+75Vrd1x3CKQqonRdLl3g+1pn8LM
 RWVmYZi/7sIjJpdA+qSG/j1ijUwxB7Xjaa01k/k=
X-Google-Smtp-Source: ABdhPJzn9BZeB/h3bSnMCUavgISX4qfL2mfnsI4LpGGq6eRrUuPEC/59NMl8uknZISwXpMDoP4CmCTgMylF6PqAKrVk=
X-Received: by 2002:a6b:ce1a:: with SMTP id p26mr12602098iob.94.1602410081413; 
 Sun, 11 Oct 2020 02:54:41 -0700 (PDT)
MIME-Version: 1.0
References: <1601928759-26696-1-git-send-email-timothy.mcdaniel@intel.com>
 <CALBAE1Ns_CosfJcFG5Eajfz6RhYP44MwU0ukKNEh-nmyDZ24iQ@mail.gmail.com>
In-Reply-To: <CALBAE1Ns_CosfJcFG5Eajfz6RhYP44MwU0ukKNEh-nmyDZ24iQ@mail.gmail.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sun, 11 Oct 2020 15:24:25 +0530
Message-ID: <CALBAE1PpvfUD1heWC2HZRhZF0Q6-tzH=pHtyVnLkjWk4WSsQ8w@mail.gmail.com>
To: Timothy McDaniel <timothy.mcdaniel@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>, 
 Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
 Gage Eads <gage.eads@intel.com>, 
 "Van Haaren, Harry" <harry.van.haaren@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eventdev: add PCI probe named
 convenience function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 8, 2020 at 9:56 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Tue, Oct 6, 2020 at 1:41 AM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> > Add new internal wrapper function for use by pci drivers as a
> > .probe function to attach to an event interface.  Same as
> > rte_event_pmd_pci_probe, except the caller can specify the name.
> >
> > Updated rte_event_pmd_pci_probe so as to not duplicate
> > code.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h | 44 ++++++++++++++++++++++--------
> >  1 file changed, 32 insertions(+), 12 deletions(-)
> >
>
> >   * @internal
> > + * Wrapper for use by pci drivers as a .probe function to attach to a event
> > + * interface.
> > + */
> > +static inline int
> > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> > +                           struct rte_pci_device *pci_dev,
> > +                           size_t private_data_size,
> > +                           eventdev_pmd_pci_callback_t devinit)
>
>
> rte_event_pmd_pci_probe() added in
> lib/librte_eventdev/rte_eventdev_version.map file.
> Please add the new function in the map file. With above change:
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>


@McDaniel, Timothy
Could you send the updated version, I would like to merge this for RC1.


>
>
>
> > +{
> > +       char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> > +
> > +       rte_pci_device_name(&pci_dev->addr, eventdev_name,
> > +                       sizeof(eventdev_name));
> > +
> > +       return rte_event_pmd_pci_probe_named(pci_drv,
> > +                                            pci_dev,
> > +                                            private_data_size,
> > +                                            devinit,
> > +                                            eventdev_name);
> > +}
> > +
> > +/**
> > + * @internal
> >   * Wrapper for use by pci drivers as a .remove function to detach a event
> >   * interface.
> >   */
> > --
> > 2.6.4
> >