From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5568E42C4D; Wed, 7 Jun 2023 15:26:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF56F40ED5; Wed, 7 Jun 2023 15:26:35 +0200 (CEST) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by mails.dpdk.org (Postfix) with ESMTP id 7E1A940698 for ; Wed, 7 Jun 2023 15:26:34 +0200 (CEST) Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6260a9ef126so55868476d6.2 for ; Wed, 07 Jun 2023 06:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686144394; x=1688736394; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eTE6xXu7r0cxc3IqwLJA1h/3HSieiEiFqOIK6YyU4/M=; b=ILilH7vRVUVCkGbjKunFeHbyv7oHpRIgIGIM8KXAG1KRvDHr2netjFmcgWy0wSR0mH b/41ZU6xxkbUy3Q6o5zTLr5lh1sS5AbuNG2QkesFNmubvlo91+OHmXLNSIMcOS5AEQXR WdBjHcKEL+LShoKoFyq7yEvM+cCMxv3Ndpyr5C4JpovMRIWNjQN3f/VJDXW2RjCcgaR/ ki4xzpKVLGBTmDYzh399LZwcQzXydaBp42aciERp+Vg1D7nThY5bc1b8ijJDW2i0Ttif yflgB57ZM/w4sUXMWjRbr7GOYio5cMF2sVqE6myp2nMFXUd5cbgMaKSlyAOaZc98UY2g xFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686144394; x=1688736394; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eTE6xXu7r0cxc3IqwLJA1h/3HSieiEiFqOIK6YyU4/M=; b=LDgqSQ5GWxvNRAUD/f+pYKnhWrUzQgmp9tB/xpKpaUsXX13PrSl8KqA8aL0pNbEk7l h4MGtRjHDI/ddBXG6NXRwNLaC8KSzC7Ij/PD/teiGUh/sjaUIZzFKcF3LpLLYChl/HPG I2LtBlTeKDtAFX2KcZlJCJX2dg77Db6/ZQ1gEUlO1hJLHRoMa7I84Fg7tag+O3lHDg8+ iMeYr8Wz8Mwf3AUv35q5k1CbzOkv+S0Z1vs/nf9bwZUe4KRhIM23GHya99KNAG6g5nq0 6N5XGVl4xxGmIgMKoIFLN9GjE5Zt+kR7vJFQ/LOMCpFdlCpPzWCLhHC9IdlSkT72n3YB yhfQ== X-Gm-Message-State: AC+VfDwwiutTZgseLBNBnNvXyC6+4Zt5XKLIyVreX/ppB4dEdHJdo8g7 Fd2sVrEWNglMYm9OUCekndYSnSkPUnvg+6TSGAan+hN7iEqlXg== X-Google-Smtp-Source: ACHHUZ6qAK4IIHzSZFjU5K0ZgHUpOTivpIy7Vtgi9EuL96hkvbqTOMS6KAa9Zuc0b+Yqb6g3slvvHO+wSkVaAGT17RQ= X-Received: by 2002:ad4:5bc4:0:b0:625:aa1a:b6dd with SMTP id t4-20020ad45bc4000000b00625aa1ab6ddmr2388419qvt.63.1686144393778; Wed, 07 Jun 2023 06:26:33 -0700 (PDT) MIME-Version: 1.0 References: <20230606144746.708388-1-zhirun.yan@intel.com> <20230607035144.1214492-1-zhirun.yan@intel.com> <20230607035144.1214492-14-zhirun.yan@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 7 Jun 2023 18:56:07 +0530 Message-ID: Subject: Re: [PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model To: "Yan, Zhirun" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 7, 2023 at 5:55=E2=80=AFPM Yan, Zhirun w= rote: > > > > > rte_graph_walk(struct rte_graph *graph) { > > > +#if !defined(RTE_GRAPH_MODEL_SELECT) || RTE_GRAPH_MODEL_SELECT > > =3D=3D > > > +RTE_GRAPH_MODEL_RTC > > > > Is nt defined instead of !defined? > > > > !defined(XX) means not defined XX. > What is nt defined means? #undef RTE_GRAPH_MODEL_SELECT or not #define RTE_GRAPH_MODEL_SELECT anywhere in .c file. > > > Use bracket around RTE_GRAPH_MODEL_SELECT =3D=3D RTE_GRAPH_MODEL_RTC. > > > Ok. > > > > > > rte_graph_walk_rtc(graph); > > > +#elif defined(RTE_GRAPH_MODEL_SELECT) && RTE_GRAPH_MODEL_SELECT > > =3D=3D > > > +RTE_GRAPH_MODEL_MCORE_DISPATCH > > > > Use bracket around RTE_GRAPH_MODEL_SELECT =3D=3D > Ok. > > > > > + rte_graph_walk_mcore_dispatch(graph); > > > +#else > > > + int model =3D rte_graph_worker_model_get(graph); > > > > Introduce rte_graph_worker_model_no_check_get() as commented earlier. > > Got it. >