From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42A33A057B; Wed, 1 Apr 2020 21:14:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BCF61C126; Wed, 1 Apr 2020 21:14:47 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 31EB61C121 for ; Wed, 1 Apr 2020 21:14:46 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id o3so962495ioh.2 for ; Wed, 01 Apr 2020 12:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UMBrFyzThQhHwfoEJNhU3LuF9gW4NJAN6zVEjn8nKAI=; b=K10DFtSV7Ad9suWLoher70P0je6w9+Tg2jjAectoC1L5HiWIr3+MM0FDpQfNlUMhu0 mt6YPwhChRyZwEW6n8y5ocki+7zu+3pObZ/KsiiKsYwJgniB3N+h2d2LEm7fJT9MEJXt xXnXstIy69+/EAwh7yg67qkjiQm8kW5c7hJu6ai80vLJhtzz6UjriUZzDIjbths8HTAQ /Gf5A6kRhFGbsA9LXS19olyvfvZEkXg4qCUl4/zKRFJfmaA0+8EyWJfKAme8KUJoVoJS glXv43xREF8tp9tKWOL9tcsyhHDUsFSnYltjwCg0n22xuqPXgqaCLP2vb+3meFHONZeB rYuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UMBrFyzThQhHwfoEJNhU3LuF9gW4NJAN6zVEjn8nKAI=; b=nIWUZS6yfGcAEvQjb/kLWaPYXQNxgNkVpnvaNuoBm1xIzRk1kRABIxFaZN/0dVu6zP POe2jv4FjLsOUVYIpQu2gl3gEHZqxcScmfe4BLs2vJ/B/FaXhB4C5ZS15YwdIF8BUjIR 9bANnMFvMRzl9Iq7YkxKhG7faZfKTJPGspsJQrIoBWkZltDhuNbGv4tSm7aU0DVO0XoP 0D5QWs26GXeTMEcwm8fd6ZOgBepeUpKbrgJ9saZkMmQZ0OXD8yPmENj7AqstBrfVNDhC dy7/4ATG1zXeD6Z0PwCiXknOVPQveuXurSjM0gE/sB/7xBw43VFSHqk4MIEJvg9Va/6b UdgQ== X-Gm-Message-State: ANhLgQ0Bb/f00GY01TBQsX6knNQ74RLBPdMkbdU3FGfCR6Du/3H8uVru trhKG9TbWpg/AokTY0ilYJMWV6JLF3KV9fjc1Yg= X-Google-Smtp-Source: ADFU+vvrSaC8Zat1YOK4yeTiGT7RhWtGqCuwid8AeulXNa2M41kmTQOypyuala6sS2Ia8kOAPx3JrEdXL1/NHrL0y3s= X-Received: by 2002:a6b:ef02:: with SMTP id k2mr19086441ioh.94.1585768484862; Wed, 01 Apr 2020 12:14:44 -0700 (PDT) MIME-Version: 1.0 References: <20200325211603.240288-1-jerinj@marvell.com> <20200329144342.1543749-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 2 Apr 2020 00:44:28 +0530 Message-ID: To: David Marchand Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , dev , Bruce Richardson , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Sunil Kumar Kori , "Yigit, Ferruh" , Andrew Rybchenko , Declan Doherty , Olivier Matz , Neil Horman , Ray Kinsella Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > wrote: > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand wrote: > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > > > I assume the patch content will be: > > > > > 1) Removing experimental API from app, lib, drivers, examples with > > > > > make and meson > > > > > 2) Have it enabled at the global level. > > > > > > > > examples are a special case as they can be compiled out of the dpdk sources. > > > > This is why I excluded them of the list in my mail before. > > > > > > There are a lot of examples already that have ALLOW_EXPERIMENTAL_API. > > > What is the issue in enabling ALLOW_EXPERIMENTAL_API in the in tree > > > example application? > > > > I did not say there is an issue in keeping this flag in the example makefiles. > > > > examples makefile should be self sufficient (like an external > > application makefile would be) and are called directly in our building > > test scripts: see devtools/test-meson-builds.sh. > > So I don't see how it would work if you remove this flag from all > > examples makefiles and rely on some global thing. > > Thanks for the clarification. I will update meson.build and Makefile in > examples. > > devtools/test-meson-builds.sh tests[1] the the below apps, > "cmdline helloworld l2fwd l3fwd skeleton time" > > What is your preference, Adding in all the examples or above selected ones? Since meson installing example application as well. I will update the effected examples with ALLOW_EXPERIMENTAL_API > > > [1] > # if pkg-config defines the necessary flags, test building some examples > if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then > export PKGCONF="pkg-config --define-prefix" > for example in cmdline helloworld l2fwd l3fwd skeleton timer; do > echo "## Building $example" > $MAKE -C > $DESTDIR/usr/local/share/dpdk/examples/$example clean all > done > fi > > > > > > > > > -- > > David Marchand > >